Skip to contentSkip to conversation

locking user space memory in kernel

DISCUSSION Libor Michalek 2 participants 2 messages Apr 8, 2004

lore
Share & tools
lore
#0 lore raw

----- Forwarded message from Manfred Spraul <[email protected]> -----

Quoted 7 lines

Date: Sun, 21 Mar 2004 12:31:59 +0100
From: Manfred Spraul <[email protected]>
To: Eli Cohen <[email protected]>
Cc: [email protected]
Subject: Re: locking user space memory in kernel

Quoted 8 lines

Hi Eli,

I think just get_user_pages() should be sufficient: the pages won't be swapped out. You don't need to set VM_LOCKED in vma->vm_flags to prevent the swap out. In the worst case, the pte is cleared a that will cause a soft page fault, but the physical address won't change. Multiple get_user_pages() calls on overlapping regions are ok, the page count is an atomic_t, at least 24-bit large.

The soft page fault is a problem if the device is going to write data
into the buffer and then notify the user that the buffer now contains valid data. If the soft page fault occurs before the device has written to the page list, once the user is notified of the write and reads the buffer, it will no longer be the same pages as the ones to which the device wrote. Is setting VM_LOCKED the only way to prevent the soft page fault and this issue?

-Libor

#1 lore raw
Quoted 11 lines · Libor Michalek

----- Forwarded message from Manfred Spraul <[email protected]> -----

Quoted 8 lines

Date: Sun, 21 Mar 2004 12:31:59 +0100
From: Manfred Spraul <[email protected]>
To: Eli Cohen <[email protected]>
Cc: [email protected]
Subject: Re: locking user space memory in kernel

Hi Eli,

Quoted 8 lines
Quoted 3 lines

I think just get_user_pages() should be sufficient: the pages won't be swapped out. You don't need to set VM_LOCKED in vma->vm_flags to prevent the swap out. In the worst case, the pte is cleared a that will cause a soft page fault, but the physical address won't change. Multiple get_user_pages() calls on overlapping regions are ok, the page count is an atomic_t, at least 24-bit large.

The soft page fault is a problem if the device is going to write data
into the buffer and then notify the user that the buffer now contains valid data. If the soft page fault occurs before the device has written to the page list, once the user is notified of the write and reads the buffer, it will no longer be the same pages as the ones to which the device wrote.

No. The physical addresses do not change due to a soft page fault.
A soft fault means that the page table entry is cleared, but that the physical page is still in the system memory. do_swap_page does a swap cache lookup and finds the original physical page in memory and maps it back to the virtual address. The physical page can't be dropped from the swap cache because your driver still holds one reference to the page - no swapout.

But fork() is a problem for get_user_pages(): You probably have to write an improved function (create_user_mapping/destroy_user_mapping) that handles fork correctly.
And add arch hooks into the new function - they are required for archs with incoherent cpu caches. Right now O_DIRECT doesn't flush the cpu caches, because it's impossible to implement it with get_user_pages(). It works, because the data cache is usually coherent and noone loads libraries with O_DIRECT.

--
Manfred