Skip to contentSkip to conversation

firewire: fix sourceID read from wrong quadlet

PATCH In review [email protected] 2 participants 2 messages Apr 16, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firewire: fix sourceID read from wrong quadlet

Quoted 1 line

From JiSheng Zhang <[email protected]>

In Asynchronous Receive Requests, the sourceID is in the second quadlet(OHCI specification, section 8.7.1).

--- linux-2.6.24.4/drivers/firewire/fw-transaction.c.orig 2008-04-14
20:57:48.294718721 +0800
+++ linux-2.6.24.4/drivers/firewire/fw-transaction.c 2008-04-14
20:58:07.083525930 +0800
@@ -650,7 +650,7 @@ fw_core_handle_request(struct fw_card *c

          HEADER_GET_OFFSET_HIGH(p->header[1]) << 32) | p->header[2];
     tcode       = HEADER_GET_TCODE(p->header[0]);
     destination = HEADER_GET_DESTINATION(p->header[0]);
-    source      = HEADER_GET_SOURCE(p->header[0]);
+    source      = HEADER_GET_SOURCE(p->header[1]);

spin_lock_irqsave(&address_handler_lock, flags); handler = lookup_enclosing_address_handler(&address_handler_list,

#1 lore raw
Quoted 3 lines · [email protected] wrote:

From JiSheng Zhang <[email protected]>

In Asynchronous Receive Requests, the sourceID is in the second quadlet(OHCI specification, section 8.7.1).

This has been fixed in Linux 2.6.25-rc1 by commit 478b233eda81bfe41307512b8336fd688c6553e0 . Thank you nevertheless,

Signature · 3 lines
Stefan Richter
-=====-==--- -=-- =----
http://arcgraph.de/sr/