Skip to contentSkip to conversation

fix arm/etherh.c allocation

PATCH In review Daniel Ritz 3 participants 3 messages Apr 20, 2004 – Apr 22, 2004

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Daniel Ritz

author
#0 lore raw

PATCH 1/1 fix arm/etherh.c allocation

russell, there's a part of my original patch you missed: allocation of the netdevice. doesn't need a comment.

against 2.6-bknow

rgds
-daniel

etherh.c renamed from drivers/net/arm/etherh.c +1 -1
@@ -574,7 +574,7 @@
 	if (ret)
 		goto out;
 
-	dev = alloc_ei_netdev();
+	dev = __alloc_ei_netdev(sizeof(struct etherh_priv));
 	if (!dev) {
 		ret = -ENOMEM;
 		goto release;
#1 lore raw

etherh.c

Quoted 11 lines · Daniel Ritz

russell, there's a part of my original patch you missed: allocation of the netdevice. doesn't need a comment.

against 2.6-bknow

rgds

(quoted diff) +0 -1
-daniel
etherh.c renamed from drivers/net/arm/etherh.c +0 -0

can one of you resend something that applies with 'patch -sp1'?

Jeff

#2 lore raw
Quoted 6 lines · Jeff Garzik

etherh.c

Quoted 2 lines · Daniel Ritz
etherh.c renamed from drivers/net/arm/etherh.c +0 -0

can one of you resend something that applies with 'patch -sp1'?

I've noticed this as well - I just end up fixing the patch headers manually. It's a BK bug unfortunately - if you provide a directory for bk diffs, it messes up like above, but if you give explicit files it doesn't.

Signature · 4 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core