Skip to contentSkip to conversation

arm64: dts: rockchip: set correct pwm0 pinctrl on rk3588-tiger

PATCH Applied Heiko Stuebner 2 participants 3 messages Jun 3, 2024 – Jun 8, 2024

Subsystems (2)
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: set correct pwm0 pinctrl on rk3588-tiger

From: Heiko Stuebner <[email protected]>

PWM0 on rk3588-tiger is connected to the BLT_CTRL pin of the Q7 connector meant as the name implies to control a backlight device.

Therefore set the correct M1 pinctrl variant for it. The M0 variant cannot ever be used because that pin is routed to a connector pin on the Q7 connector that is reserved for CAN use and the pin reachable by the M2 variant is reserved for the embedded MCU on the SoM.

Fixes 6173ef24b35b ("arm64: dts: rockchip: add RK3588-Q7 (Tiger) SoM")
---
 arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi +5 -0
index 0c1115cdee22c..f870f84da1e6d 100644
@@ -352,6 +352,11 @@ usb3_id: usb3-id {
 	};
 };
 
+&pwm0 {
+	pinctrl-0 = <&pwm0m1_pins>;
+	pinctrl-names = "default";
+};
+
 &saradc {
 	vref-supply = <&vcc_1v8_s0>;
 	status = "okay";
Signature · 7 lines
2.39.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v1 1/1
#1 lore raw

Hi Heiko,

Quoted 5 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

PWM0 on rk3588-tiger is connected to the BLT_CTRL pin of the Q7 connector meant as the name implies to control a backlight device.

If not used for backlight, it can be used as a General Purpose PWM Output according to the Qseven standard as well.

Quoted 7 lines

Therefore set the correct M1 pinctrl variant for it. The M0 variant cannot ever be used because that pin is routed to a connector pin on the Q7 connector that is reserved for CAN use and the pin reachable by the M2 variant is reserved for the embedded MCU on the SoM.

Fixes 6173ef24b35b ("arm64: dts: rockchip: add RK3588-Q7 (Tiger) SoM")

Thanks!
Quentin

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

author maintainer Applied
#2 lore raw
In reply to Heiko Stuebner
Quoted 11 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

PWM0 on rk3588-tiger is connected to the BLT_CTRL pin of the Q7 connector meant as the name implies to control a backlight device.

Therefore set the correct M1 pinctrl variant for it. The M0 variant cannot ever be used because that pin is routed to a connector pin on the Q7 connector that is reserved for CAN use and the pin reachable by the M2 variant is reserved for the embedded MCU on the SoM.

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: set correct pwm0 pinctrl on rk3588-tiger

      commit: a21d2cc2f9039023105bf9f9bf1acf324d5ebf9d

Best regards,

Signature · 6 lines
Heiko Stuebner <[email protected]>

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip