Fixing broken DSDT - code suggestions for comment please!
Hi ACPI list,
I have been trying to get ACPI running on my laptop but have found there are problems with the DSDT. I have followed some instructions on getting iasl and recompiling the DSDT but find some errors that go beyond the scope of the list at:
http://www.cpqlinux.com/acpi-howto.html#fix_broken_dsdt
The errors are:
dsdt.dsl 2149: Store (Local0, Local0)
Error 1013 - ^ Method local variable is not initialized (Local0)
This occurs several times in the code, a typical case is:
Method (_PS0, 0, NotSerialized)
{
Store (And (0xF0, TIA4), TIA4)
Store (0x01, _PSC)
Store (Local0, Local0)
}I'm guessing that is effectively a NOP so I can comment it out.
Later there are two other errors not mentioned in the FAQ:
dsdt.dsl 2390: Return (WQS (0x0E, Arg0))
Error 1029 - ^ Called method returns no value
dsdt.dsl 2395: Return (WQSB (0x0E, Arg0))
Error 1029 - Called method returns no value ^
The offending code is:
Method (WENR, 1, NotSerialized)
{
Return (WQS (0x0E, Arg0))
}
Method (WETR, 1, NotSerialized)
{
Return (WQSB (0x0E, Arg0))
}All the calls to those methods seem to discard any return value, eg:
If (\_SB.OKEC)
{
\_SB.PCI0.QSB.WENR (0x01F0)
}I couldn't find a reference to WETR
So I thought to not return anything:
Method (WENR, 1, NotSerialized)
{
/* Return (WQS (0x0E, Arg0))*/
WQS (0x0E, Arg0)
}
Method (WETR, 1, NotSerialized)
{
/* Return (WQSB (0x0E, Arg0))*/
WQSB (0x0E, Arg0)
}I am more than a bit wary about trying this for real so would appreciate
any comments on the dsdt code above. If the fixes are good then maybe
they could be incorporated into the FAQ?
Any comments gratefully received,
-Cam
-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
A message that is not in the archive (sent off-list or not yet received): 40A73460.2070407-Nk/[email protected]
Hi again ACPI list,
I'm really hoping someone with DSDT hacking experience will cast an eye over the DSDT patches I gave before (dated 16/05/04 10:29).
I also see some messages at boot time:
ACPI: Subsystem revision 20040326
ACPI: IRQ9 SCI: Level Trigger.
ACPI-1133: *** Error: Method execution failed
[\_SB_.PCI0.QSB_.WQS_] (Node 19f1a5bc), AE_NOT_EXIST
ACPI-1133: *** Error: Method execution failed
[\_SB_.PCI0.QSB_.WENR] (Node 19f1a77c), AE_NOT_EXIST
ACPI-1133: *** Error: Method execution failed [\_SB_.PCI0._INI]
(Node 19f2123c), AE_NOT_EXIST
ACPI: Interpreter enabled
Any suggestions how I can fix or work around these? Or any more links to useful guides to hacking the DSDT?
Thanks in advance,
-Cam
Signature · 8 lines
camilo-Nk/[email protected] <-- ------------------------------------------------------- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
Please verify that you still have this problem
when running the latest iasl:
http://www.intel.com/technology/IAPC/acpi/downloads.htm
Quoted 67 lines · Cam
Hi ACPI list,
I have been trying to get ACPI running on my laptop but have found there are problems with the DSDT. I have followed some instructions on getting iasl and recompiling the DSDT but find some errors that go beyond the scope of the list at:
http://www.cpqlinux.com/acpi-howto.html#fix_broken_dsdt
The errors are:
dsdt.dsl 2149: Store (Local0, Local0)
Error 1013 - ^ Method local variable
is not initialized (Local0)This occurs several times in the code, a typical case is:
Method (_PS0, 0, NotSerialized) { Store (And (0xF0, TIA4), TIA4) Store (0x01, _PSC) Store (Local0, Local0) }I'm guessing that is effectively a NOP so I can comment it out.
Later there are two other errors not mentioned in the FAQ:
dsdt.dsl 2390: Return (WQS (
0x0E, Arg0))
Error 1029 - ^ Called method returns no
valuedsdt.dsl 2395: Return (WQSB (
0x0E, Arg0))
Error 1029 - Called method returns no value ^The offending code is:
Method (WENR, 1, NotSerialized) { Return (WQS (0x0E, Arg0)) } Method (WETR, 1, NotSerialized) { Return (WQSB (0x0E, Arg0)) }All the calls to those methods seem to discard any return value, eg:
If (\_SB.OKEC) { \_SB.PCI0.QSB.WENR (0x01F0) }I couldn't find a reference to WETR
So I thought to not return anything:
Method (WENR, 1, NotSerialized)
{
/* Return (WQS (0x0E, Arg0))*/
Quoted 9 lines
WQS (0x0E, Arg0)
}
Method (WETR, 1, NotSerialized)
{
/* Return (WQSB (0x0E, Arg0))*/
WQSB (0x0E, Arg0)
}no. the problem is that WQS and WQSB need to have Return() statements.
Quoted 9 lines
I am more than a bit wary about trying this for real so would appreciate
any comments on the dsdt code above. If the fixes are good then maybe
they could be incorporated into the FAQ?Any comments gratefully received,
-Cam
Quoted 9 lines
-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
_______________________________________________
Acpi-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/acpi-devel
-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
A message that is not in the archive (sent off-list or not yet received): [email protected]
Len
thanks for the feedback and comments,
Quoted 4 lines · Len Brown
Please verify that you still have this problem
when running the latest iasl:
I was working with iasl-linux-20030918 which I think is the latest. Do you think the Store(Local0, Local0) is an iasl bug? I can send the dsdt binary if you are interested.
Quoted 9 lines
Quoted 9 lines
Later there are two other errors not mentioned in the FAQ:
dsdt.dsl 2390: Return (WQS (
0x0E, Arg0))
Error 1029 - ^ Called method returns no valuedsdt.dsl 2395: Return (WQSB (
0x0E, Arg0))
Error 1029 - Called method returns no value ^
[... my bad fix snipped ...]
Quoted 1 line
no. the problem is that WQS and WQSB need to have
Return()statements.
OK from another look at the code I see the declarations for the WQS and WQSB methods. I am struggling what to return from these. Zero? Arg0? Arg1? Some success/fail code? Any ideas? There are lots of calls to WQS and WQSB that mostly seem to discard the (not yet) returned value.
Method (WQSB, 2, NotSerialized)
{
If (LNot (LOr (\_SB.PCI0.ISA.EC0.FBAT,
\_SB.PCI0.ISA.EC0.FTMP)))
{
Store (0x01, \_SB.PCI0.ISA.EC0.FQSB)
And (Arg1, 0xFF, Local0)
ShiftRight (Arg1, 0x08, Local1)
And (Local1, 0xFF, Local1)
Acquire (\_SB.PCI0.ISA.EC0.BNKM, 0xFFFF)
Store (Local1, \_SB.PCI0.ISA.EC0.CMD3)
Store (Local0, \_SB.PCI0.ISA.EC0.CMD2)
Store (Arg0, \_SB.PCI0.ISA.EC0.CMD1)
Store (0xE9, \_SB.PCI0.ISA.EC0.CMCM)
Release (\_SB.PCI0.ISA.EC0.BNKM)
Store (0x00, \_SB.PCI0.ISA.EC0.FQSB)
}
}
Method (WQS, 2, NotSerialized)
{
While (LOr (\_SB.PCI0.ISA.EC0.FBAT,
\_SB.PCI0.ISA.EC0.FTMP)) {
Noop
}
Store (0x01, \_SB.PCI0.ISA.EC0.FQSB)
And (Arg1, 0xFF, Local0)
ShiftRight (Arg1, 0x08, Local1)
And (Local1, 0xFF, Local1)
Acquire (\_SB.PCI0.ISA.EC0.BNKM, 0xFFFF)
Store (Local1, \_SB.PCI0.ISA.EC0.CMD3)
Store (Local0, \_SB.PCI0.ISA.EC0.CMD2)
Store (Arg0, \_SB.PCI0.ISA.EC0.CMD1)
Store (0xE9, \_SB.PCI0.ISA.EC0.CMCM)
Release (\_SB.PCI0.ISA.EC0.BNKM)
Store (0x00, \_SB.PCI0.ISA.EC0.FQSB)
}-Cam
-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
A message that is not in the archive (sent off-list or not yet received): 40A95EB3.5070206-Nk/[email protected]
Quoted 5 lines · Cam
Len
thanks for the feedback and comments,
Len Brown wrote:
Quoted 8 lines
Quoted 4 lines
Please verify that you still have this problem
when running the latest iasl:I was working with iasl-linux-20030918 which I think is the latest. Do you think the
Store(Local0, Local0)is an iasl bug? I can send the dsdt binary if you are interested.
Follow the link above to download a version 6 months newer.
Quoted 54 lines
Quoted 11 lines
Quoted 11 lines
Later there are two other errors not mentioned in the FAQ:
dsdt.dsl 2390: Return (WQS (
0x0E, Arg0))
Error 1029 - ^ Called method returns no
valuedsdt.dsl 2395: Return (WQSB (
0x0E, Arg0))
Error 1029 - Called method returns no value ^[... my bad fix snipped ...]
Quoted 1 line
no. the problem is that WQS and WQSB need to have
Return()statements.OK from another look at the code I see the declarations for the WQS and WQSB methods. I am struggling what to return from these. Zero? Arg0? Arg1? Some success/fail code? Any ideas? There are lots of calls to WQS and WQSB that mostly seem to discard the (not yet) returned value.
Method (WQSB, 2, NotSerialized) { If (LNot (LOr (\_SB.PCI0.ISA.EC0.FBAT, \_SB.PCI0.ISA.EC0.FTMP))) { Store (0x01, \_SB.PCI0.ISA.EC0.FQSB) And (Arg1, 0xFF, Local0) ShiftRight (Arg1, 0x08, Local1) And (Local1, 0xFF, Local1) Acquire (\_SB.PCI0.ISA.EC0.BNKM, 0xFFFF) Store (Local1, \_SB.PCI0.ISA.EC0.CMD3) Store (Local0, \_SB.PCI0.ISA.EC0.CMD2) Store (Arg0, \_SB.PCI0.ISA.EC0.CMD1) Store (0xE9, \_SB.PCI0.ISA.EC0.CMCM) Release (\_SB.PCI0.ISA.EC0.BNKM) Store (0x00, \_SB.PCI0.ISA.EC0.FQSB) } } Method (WQS, 2, NotSerialized) { While (LOr (\_SB.PCI0.ISA.EC0.FBAT, \_SB.PCI0.ISA.EC0.FTMP)) { Noop } Store (0x01, \_SB.PCI0.ISA.EC0.FQSB) And (Arg1, 0xFF, Local0) ShiftRight (Arg1, 0x08, Local1) And (Local1, 0xFF, Local1)
Quoted 8 lines
Acquire (\_SB.PCI0.ISA.EC0.BNKM, 0xFFFF)
Store (Local1, \_SB.PCI0.ISA.EC0.CMD3)
Store (Local0, \_SB.PCI0.ISA.EC0.CMD2)
Store (Arg0, \_SB.PCI0.ISA.EC0.CMD1)
Store (0xE9, \_SB.PCI0.ISA.EC0.CMCM)
Release (\_SB.PCI0.ISA.EC0.BNKM)
Store (0x00, \_SB.PCI0.ISA.EC0.FQSB)
}usually the fix to the 'implicit return bug' is to return the value returned by the last method called. I guess here you'd return 0?
-Len
-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 5 lines · Len Brown
Quoted 4 lines · Cam
Quoted 3 lines · Len Brown
Please verify that you still have this problem
when running the latest iasl:
Quoted 7 lines
Quoted 5 lines
I was working with iasl-linux-20030918 which I think is the latest. Do you think the
Store(Local0, Local0)is an iasl bug? I can send the dsdt binary if you are interested.Follow the link above to download a version 6 months newer.
Following the link above, I see a newer version of iasl for Windows, but not for Linux. Is there a version of iasl newer than 20030918 for Linux? Am I missing something?
thanks,
Signature · 9 lines
-chris ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
A message that is not in the archive (sent off-list or not yet received): 20040520202950.GK5920-r/[email protected]
Chris
Quoted 2 lines
Following the link above, I see a newer version of iasl for Windows, but not for Linux. Is there a version of iasl newer than 20030918 for Linux? Am I missing something?
Get the sources for linux from that page.
For the record it did not give any different errrors in my case.
-Cam
Signature · 7 lines
camilo-Nk/[email protected] <-- ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click