Skip to contentSkip to conversation

Fix userspace inclusion of linux/fs.h (resend)

PATCH In review Måns Rullgård 2 participants 3 messages May 23, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix userspace inclusion of linux/fs.h (resend)

The patch below fixes compilation of userspace using linux/fs.h. The patch is against Linux 2.6.6. Please apply of fix some other way.

# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2004/05/16 22:34:26+02:00 [email protected]
# fix userspace use of linux/fs.h
#

# include/linux/fs.h
#   2004/05/16 22:28:34+02:00 [email protected] +3 -3
#   move some #includes inside #ifdef __KERNEL__ to allow userspace inclusion
# 
diff -Nru a/include/linux/fs.h b/include/linux/fs.h
--- a/include/linux/fs.h	2004-05-23 20:11:46 +02:00
+++ b/include/linux/fs.h	2004-05-23 20:11:46 +02:00
@@ -13,14 +13,11 @@
 #include <linux/types.h>
 #include <linux/kdev_t.h>
 #include <linux/ioctl.h>
-#include <linux/list.h>
 #include <linux/dcache.h>
 #include <linux/stat.h>
 #include <linux/cache.h>
-#include <linux/radix-tree.h>
 #include <linux/kobject.h>
 #include <asm/atomic.h>
-#include <linux/audit.h>

struct iovec;
struct nameidata;
@@ -213,6 +210,9 @@

#ifdef __KERNEL__

+#include <linux/list.h>
+#include <linux/radix-tree.h>
+#include <linux/audit.h>
#include <asm/semaphore.h>
#include <asm/byteorder.h>

Signature · 2 lines
Måns Rullgård
[email protected]
#1 lore raw
Quoted 2 lines · Måns Rullgård

The patch below fixes compilation of userspace using linux/fs.h. The patch is against Linux 2.6.6. Please apply of fix some other way.

Userspace should not be directly including the kernel headers.

Some dude maintains a "linux-libc-headers" package, you probably want that.

Jeff

#2 lore raw
Quoted 7 lines · Jeff Garzik
Quoted 2 lines · Måns Rullgård

The patch below fixes compilation of userspace using linux/fs.h. The patch is against Linux 2.6.6. Please apply of fix some other way.

Userspace should not be directly including the kernel headers.

Some dude maintains a "linux-libc-headers" package, you probably want that.

I still fail to see the point in maintaining three separate sets of header files, but that has been discussed in the past.

Signature · 2 lines
Måns Rullgård
[email protected]