ipr duplicate ioa reset fix

PATCH New Brian King 1 participant 1 message May 24, 2004

Subsystems (2)

SCSI IBM Power Linux RAID adapter

lore

Share & tools

lore

Brian King

author maintainer

2004-05-24 14:39 UTC #0 lore raw

PATCH 2/3 ipr duplicate ioa reset fix

Signature · 4 lines

-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center

This patch closes a window where if a device had a cancel all outstanding as a result of a check condition and the adapter was reset for some reason, a request sense would still be issued, which would end up timing out and issuing an additional adapter reset. It could also result in a leak of command blocks, depending on when it timed out.

---

 linux-2.6.6-bjking1/drivers/scsi/ipr.c |    6 ++++++
 1 files changed, 6 insertions(+)

drivers/scsi/ipr.c renamed from drivers/scsi/ipr.c~ipr_duplicate_ioa_reset_fix +6 -0

diff -puN drivers/scsi/ipr.c~ipr_duplicate_ioa_reset_fix drivers/scsi/ipr.c
@@ -3482,6 +3482,12 @@ static void ipr_reinit_ipr_cmnd_for_erp(
 static void ipr_erp_request_sense(struct ipr_cmnd *ipr_cmd)
 {
 	struct ipr_cmd_pkt *cmd_pkt = &ipr_cmd->ioarcb.cmd_pkt;
+	u32 ioasc = be32_to_cpu(ipr_cmd->ioasa.ioasc);
+
+	if (IPR_IOASC_SENSE_KEY(ioasc) > 0) {
+		ipr_erp_done(ipr_cmd);
+		return;
+	}
 
 	ipr_reinit_ipr_cmnd_for_erp(ipr_cmd);