Skip to contentSkip to conversation

use c99 struct initializer in hotcpu_notifier

PATCH New Nathan Lynch 1 participant 1 message Jun 2, 2004 CPU hotplug

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 use c99 struct initializer in hotcpu_notifier

Hi-

The hotcpu_notifier macro does not properly record the given priority in the notifier block. This causes trouble only for callers which specify a non-zero priority, of which there are none (yet).

Patch is against 2.6.7-rc2; please apply.

include/linux/cpu.h +2 -1
@@ -60,7 +60,8 @@ extern struct semaphore cpucontrol;
 #define unlock_cpu_hotplug()	up(&cpucontrol)
 #define lock_cpu_hotplug_interruptible() down_interruptible(&cpucontrol)
 #define hotcpu_notifier(fn, pri) {				\
-	static struct notifier_block fn##_nb = { fn, pri };	\
+	static struct notifier_block fn##_nb =			\
+		{ .notifier_call = fn, .priority = pri };	\
 	register_cpu_notifier(&fn##_nb);			\
 }
 int cpu_down(unsigned int cpu);