Skip to contentSkip to conversation

fix missing option in binutils version check

PATCH New Christian 1 participant 1 message Jun 10, 2004

lore
Share & tools
lore

Christian

author
#0 lore raw

PATCH 1/1 fix missing option in binutils version check

Quoted 8 lines · Olaf Hering
Quoted 8 lines
pomegranate:~# echo dssall | /usr/bin/as -o /tmp/x
{standard input}: Assembler messages:
{standard input}:1: Error: Unrecognized opcode: `dssall'
pomegranate:~# /usr/bin/as -v
GNU assembler version 2.15.91.0.1 (powerpc-suse-linux) using BFD
version 2.15.91.0.1 20040527 (SuSE Linux)
Quoted 7 lines
Quoted 4 lines

*** 2.6 kernels no longer buildcorrectly with old versions of binutils. *** Please upgrade your binutils to 2.12.1 or newer
make: *** [checkbin] Error 1
make: Target `all' not remade because of errors.

I talked to Alan, and -many is the correct fix.

seeing your new patch now which indeed exports "as" with this needed option i seem to understand now. somehow i was unable to apply your patch, so i patched by hand / made a new patch:

evil@sheep:/usr/src/linux-2.6$ cat ../as-dssall.diff | patch -p1 -s \
--dry-run
patch: **** malformed patch at line 6: ifdef CONFIG_6xx

Thank you,
Christian.
--
BOFH excuse #377:

Someone hooked the twisted pair wires into the answering machine.

arch/ppc/Makefile renamed from arch/ppc/Makefile.orig +2 -2
@@ -86,7 +86,7 @@
 
 ifdef CONFIG_6xx
 # Ensure this is binutils 2.12.1 (or 2.12.90.0.7) or later
-NEW_AS	:= $(shell echo dssall | $(AS) -o /dev/null >/dev/null 2>&1 ; echo $$?)
+NEW_AS := $(shell echo dssall | $(AS) -many -o /dev/null >/dev/null 2>&1 ; echo $$?)
 GOODVER	:= 2.12.1
 else
 NEW_AS	:= 0
@@ -94,7 +94,7 @@
 
 ifneq ($(NEW_AS),0)
 checkbin:
-	@echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build'
+	@echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build '
 	@echo 'correctly with old versions of binutils.'
 	@echo '*** Please upgrade your binutils to ${GOODVER} or newer'
 	@false