Skip to contentSkip to conversation

definition of CONFIG_MTD_DOCECC missing in drivers/mtd/devices/Config.in

PATCH Frantisek Rysanek 2 participants 2 messages Jun 28, 2004 – Jul 6, 2004 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

Dear MTD maintainers,

I've downloaded a "daily CVS snapshot" today:
mtd-snapshot-20040627.tar.bz2

I've noticed that CONFIG_MTD_DOCECC is missing in $KERNEL_SRC_DIR/drivers/mtd/devices/Config.in, which results in linker errors - unresolved calls to doc_decode_ecc(), that is defined in docecc.c.

Attached is a suggested patch (I hope).

Have a nice day, thanks for the great job that you're doing.

Frank Rysanek

The following section of this message contains a file attachment prepared for transmission using the Internet MIME message format. If you are using Pegasus Mail, or any other MIME-compliant system, you should be able to save it or view it from within your mailer. If you cannot, please ask your system administrator for assistance.

---- File information -----------

     File:  docecc.Config.in.patch
     Date:  28 Jun 2004, 8:31
     Size:  919 bytes.
     Type:  Binary
drivers/mtd/devices/Config.in +3 -0
@@ -31,6 +31,9 @@
    dep_tristate '  M-Systems Disk-On-Chip 2000 and Millennium' CONFIG_MTD_DOC2000 $CONFIG_MTD
    dep_tristate '  M-Systems Disk-On-Chip Millennium-only alternative driver (see help)' CONFIG_MTD_DOC2001 $CONFIG_MTD
    dep_tristate '  M-Systems Disk-On-Chip Millennium Plus driver (see help)' CONFIG_MTD_DOC2001PLUS $CONFIG_MTD
+   if [ "$CONFIG_MTD_DOC2001PLUS" = "y" -o "$CONFIG_MTD_DOC2001" = "y" -o "$CONFIG_MTD_DOC2000" = "y" -o "$CONFIG_MTD_DOC2001PLUS" = "m" -o "$CONFIG_MTD_DOC2001" = "m" -o "$CONFIG_MTD_DOC2000" = "m" ]; then
+      define_bool CONFIG_MTD_DOCECC y
+   fi
    if [ "$CONFIG_MTD_DOC2001PLUS" = "y" -o "$CONFIG_MTD_DOC2001" = "y" -o "$CONFIG_MTD_DOC2000" = "y" ]; then
       define_bool CONFIG_MTD_DOCPROBE y
    else
#1 lore raw

Re: definition of CONFIG_MTD_DOCECC missing indrivers/mtd/devices/Config.in

----- Original Message -----
From: "Frantisek Rysanek" <[email protected]>
Sent: Monday, June 28, 2004 3:40 AM
Subject: definition of CONFIG_MTD_DOCECC missing indrivers/mtd/devices/Config.in

Quoted 6 lines

I've noticed that CONFIG_MTD_DOCECC is missing in $KERNEL_SRC_DIR/drivers/mtd/devices/Config.in, which results in linker errors - unresolved calls to doc_decode_ecc(), that is defined in docecc.c.

Attached is a suggested patch (I hope).

Good catch; I forgot to add proper 2.4 support for this. Sorry! Fix commited to CVS, should be in the next snapshot.

-Dan Brown