drivers/char/rocket_int.h MIN/MAX removal
Subsystems (2)
PATCH 1/1 drivers/char/rocket_int.h MIN/MAX removal
Patch (against 2.6.7) removes unnecessary min/max macros and changes calls to use kernel.h macros instead.
Feedback is always welcome
Michael
drivers/char/rocket_int.h +0 -4
@@ -1241,10 +1241,6 @@#define TTY_ROCKET_MAJOR 46#define CUA_ROCKET_MAJOR 47 -#ifndef MIN -#define MIN (a,b) ((a) < (b) ? (a) : (b)) -#endif -#ifdef PCI_VENDOR_ID_RP #undef PCI_VENDOR_ID_RP#undef PCI_DEVICE_ID_RP8OCTA
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/1 drivers/char/riscom8.c MIN/MAX removal
Patch (against 2.6.7) removes unnecessary min/max macros and changes calls to use kernel.h macros instead.
Feedback is always welcome
Michael
drivers/char/riscom8.c +8 -12
@@ -75,10 +75,6 @@ ASYNC_SPD_HI | ASYNC_SPEED_VHI | ASYNC_SESSION_LOCKOUT | \ ASYNC_PGRP_LOCKOUT | ASYNC_CALLOUT_NOHUP) -#ifndef MIN -#define MIN (a,b) ((a) < (b) ? (a) : (b)) -#endif -#define RS_EVENT_WRITE_WAKEUP 0static struct riscom_board * IRQ_to_board[16 ];
@@ -107,7 +103,7 @@ };static struct riscom_port rc_port[RC_NBOARD *RC_NPORT ]; - +/* RISCom/8 I/O ports addresses (without address translation) */ static unsigned short rc_ioport[] = {#if 1
@@ -483,7 +479,7 @@rc_out (bp,CD180_TDR ,CD180_C_SBRK ); port->COR2 &= ~COR2_ETC ; } - count =MIN (port->break_length,0xff ); + count =min_t (int, port->break_length,0xff );rc_out (bp,CD180_TDR ,CD180_C_ESC );rc_out (bp,CD180_TDR ,CD180_C_DELAY );rc_out (bp,CD180_TDR , count);
@@ -1165,8 +1161,8 @@down (&tmp_buf_sem);while (1 ) {cli (); - c =MIN (count,MIN (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , -SERIAL_XMIT_SIZE - port->xmit_head)); + c =min_t (int, count,min (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , +SERIAL_XMIT_SIZE - port->xmit_head));if (c <=0 )break ;
@@ -1178,8 +1174,8 @@ }cli (); - c =MIN (c,MIN (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , -SERIAL_XMIT_SIZE - port->xmit_head)); + c =min_t (c,min (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , +SERIAL_XMIT_SIZE - port->xmit_head));memcpy (port->xmit_buf + port->xmit_head, tmp_buf, c); port->xmit_head = (port->xmit_head + c) & (SERIAL_XMIT_SIZE -1 ); port->xmit_cnt += c;
@@ -1193,8 +1189,8 @@ }else {while (1 ) {cli (); - c =MIN (count,MIN (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , -SERIAL_XMIT_SIZE - port->xmit_head)); + c =min_t (int, count,min (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , +SERIAL_XMIT_SIZE - port->xmit_head));if (c <=0 ) {restore_flags (flags);break ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/1 drivers/char/rocket.c MIN/MAX removal
In reply to Michael VeeckPatch (against 2.6.7) removes unnecessary min/max macros and changes calls to use kernel.h macros instead.
Feedback is always welcome
Michael
drivers/char/rocket.c +4 -4
@@ -389,7 +389,7 @@while (1 ) {if (tty->stopped || tty->hw_stopped)break ; - c =MIN (info->xmit_fifo_room,MIN (info->xmit_cnt,XMIT_BUF_SIZE - info->xmit_tail)); + c =min (info->xmit_fifo_room,min (info->xmit_cnt,XMIT_BUF_SIZE - info->xmit_tail));if (c <=0 || info->xmit_fifo_room <=0 )break ;sOutStrW (sGetTxRxDataIO (cp), (unsigned short *) (info->xmit_buf + info->xmit_tail), c /2 );
@@ -1661,7 +1661,7 @@* into FIFO. Use the write queue for temp storage. */ if (!tty->stopped && !tty->hw_stopped && info->xmit_cnt ==0 && info->xmit_fifo_room >0 ) { - c =MIN (count, info->xmit_fifo_room); + c =min (count, info->xmit_fifo_room); b = buf;if (from_user) {if (copy_from_user (info->xmit_buf, buf, c)) {
@@ -1671,7 +1671,7 @@if (info->tty ==0 ) goto end; b = info->xmit_buf; - c =MIN (c, info->xmit_fifo_room); + c =min (c, info->xmit_fifo_room); }/* Push data into FIFO, 2 bytes at a time */
@@ -1699,7 +1699,7 @@if (info->tty ==0 )/* Seemingly obligatory check... */ goto end; - c =MIN (count,MIN (XMIT_BUF_SIZE - info->xmit_cnt -1 ,XMIT_BUF_SIZE - info->xmit_head)); + c =min (count,min (XMIT_BUF_SIZE - info->xmit_cnt -1 ,XMIT_BUF_SIZE - info->xmit_head));if (c <=0 )break ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Re: [Kernel-janitors] [PATCH] drivers/char/riscom8.c MIN/MAX removal
In reply to Michael VeeckSorry, one bug was in the last patch, so heres the new one, against 2.6.8-rc1.
Quoted 6 lines · Michael Veeck
Patch (against 2.6.7) removes unnecessary min/max macros and changes calls to use
kernel.hmacros instead.Feedback is always welcome
Michael
drivers/char/riscom8.c +7 -12
@@ -75,10 +75,6 @@ ASYNC_SPD_HI | ASYNC_SPEED_VHI | ASYNC_SESSION_LOCKOUT | \ ASYNC_PGRP_LOCKOUT | ASYNC_CALLOUT_NOHUP) -#ifndef MIN -#define MIN (a,b) ((a) < (b) ? (a) : (b)) -#endif -#define RS_EVENT_WRITE_WAKEUP 0static struct riscom_board * IRQ_to_board[16 ];
@@ -454,7 +450,6 @@ static inline void rc_transmit(struct ristruct tty_struct *tty;unsigned char count; -if (!(port =rc_get_port (bp,"Transmit" )))return ;
@@ -483,7 +478,7 @@ static inline void rc_transmit(struct rirc_out (bp,CD180_TDR ,CD180_C_SBRK ); port->COR2 &= ~COR2_ETC ; } - count =MIN (port->break_length,0xff ); + count = min_t(unsigned char, port->break_length, 0xff);rc_out (bp,CD180_TDR ,CD180_C_ESC );rc_out (bp,CD180_TDR ,CD180_C_DELAY );rc_out (bp,CD180_TDR , count);
@@ -1165,8 +1160,8 @@ static int rc_write(struct tty_struct *down (&tmp_buf_sem);while (1 ) {cli (); - c =MIN (count,MIN (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , -SERIAL_XMIT_SIZE - port->xmit_head)); + c =min_t (int, count,min (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , +SERIAL_XMIT_SIZE - port->xmit_head));if (c <=0 )break ;
@@ -1178,8 +1173,8 @@ static int rc_write(struct tty_struct * }cli (); - c =MIN (c,MIN (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , -SERIAL_XMIT_SIZE - port->xmit_head)); + c =min_t (int, c,min (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , +SERIAL_XMIT_SIZE - port->xmit_head));memcpy (port->xmit_buf + port->xmit_head, tmp_buf, c); port->xmit_head = (port->xmit_head + c) & (SERIAL_XMIT_SIZE -1 ); port->xmit_cnt += c;
@@ -1193,8 +1188,8 @@ static int rc_write(struct tty_struct * }else {while (1 ) {cli (); - c =MIN (count,MIN (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , -SERIAL_XMIT_SIZE - port->xmit_head)); + c =min_t (int, count,min (SERIAL_XMIT_SIZE - port->xmit_cnt -1 , +SERIAL_XMIT_SIZE - port->xmit_head));if (c <=0 ) {restore_flags (flags);break ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors