amb_talk() (msleep)

Hi,

In continuing to replace, where appropriate, code with msleep() calls, I ran across drivers/atm/ambassador.c::amb_talk():

<snip>
// 2.2 second wait (must not touch doorbell during 2 second DMA test) timeout = HZ*22/10;
while (timeout)

    timeout = schedule_timeout (timeout);

// give the adapter another half second?
timeout = HZ/2;
<snip>

There is no call to set_current_state() before these timeouts are scheduled and thus they will return immediately. If someone could tell me which state (TASK_INTERRUPTIBLE or TASK_UNINTERRUPTIBLE) is desired, I can fix this and perhaps replace the calls with msleep().

Thanks,
Nish
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors