Skip to contentSkip to conversation

Fix buffer overflow in udevstart

PATCH In review Hannes Reinecke 2 participants 2 messages Jul 16, 2004 – Jul 17, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix buffer overflow in udevstart

Hi all,

this patch fixes a buffer overflow in udevstart. Quite nasty that it went overlooked for so long. Made our Opterons segfault.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke			[email protected]
SuSE Linux AG				S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de
udevstart.c renamed from udevstart.c.orig +1 -1
@@ -228,7 +228,7 @@
 				continue;
 
 			snprintf(dirname, MAX_PATHLEN, "%s/%s", SYSCLASS, dent->d_name);
-			dirname[MAX_PATHLEN] = '\0';
+			dirname[MAX_PATHLEN - 1] = '\0';
 			dir2 = opendir(dirname);
 			if (dir2 != NULL) {
 				for (dent2 = readdir(dir2); dent2 != NULL; dent2 = readdir(dir2)) {
#1 lore raw
Quoted 4 lines · Hannes Reinecke

Hi all,

this patch fixes a buffer overflow in udevstart. Quite nasty that it went overlooked for so long. Made our Opterons segfault.

Already fixed in the 030 release, but thanks anyway :)

greg k-h

-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id040&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel