Skip to contentSkip to conversation

Staging: qlge: Elemenate anomalies in driver's coding style.

PATCH In review Sam Muhammed 2 participants 4 messages Mar 18, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: qlge: Elemenate anomalies in driver's coding style.

This driver maintains a coding style of declaring variables and assigning values to them in separate lines. There are anomalies, elemenate them.

---
 drivers/staging/qlge/qlge_dbg.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/qlge/qlge_dbg.c +2 -1
index 1795533cbd3a..8bf592812518 100644
@@ -496,7 +496,8 @@ static int ql_get_mpi_shadow_regs(struct ql_adapter *qdev, u32 *buf)
 static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf,
 			   u32 offset, u32 count)
 {
-	int i, status = 0;
+	int i;
+	int status = 0;
 
 	for (i = 0; i < count; i++, buf++) {
 		status = ql_read_mpi_reg(qdev, offset + i, buf);
Signature · 1 line
2.20.1
#1 lore raw
Quoted 3 lines · Sam Muhammed

This driver maintains a coding style of declaring variables and assigning values to them in separate lines. There are anomalies, elemenate them.

I think I was not clear. When I suggested to do only one thing, rather than starting with a series, I meant that you should do one or the other of the things in your previous patch, but not both. If you make multiple changes to a file, they must be in a series, or Greg won't know in what order to apply them.

julia

Quoted 28 lines
---
 drivers/staging/qlge/qlge_dbg.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/qlge/qlge_dbg.c +2 -2
index 1795533cbd3a..8bf592812518 100644
@@ -496,7 +496,8 @@ static int ql_get_mpi_shadow_regs(struct ql_adapter *qdev, u32 *buf)
 static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf,
 			   u32 offset, u32 count)
 {
-	int i, status = 0;
+	int i;
+	int status = 0;
 
 	for (i = 0; i < count; i++, buf++) {
 		status = ql_read_mpi_reg(qdev, offset + i, buf);
--

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200318202747.4218-1-jane.pnx9%40gmail.com.

#2 lore raw
Quoted 7 lines · Julia Lawall
Quoted 3 lines · Sam Muhammed

This driver maintains a coding style of declaring variables and assigning values to them in separate lines. There are anomalies, elemenate them.

Quoted 9 lines

I think I was not clear. When I suggested to do only one thing, rather than starting with a series, I meant that you should do one or the other of the things in your previous patch, but not both. If you make multiple changes to a file, they must be in a series, or Greg won't know in what order to apply them.

julia

Oh, so this patch should have this one _logical_ change only? so i resend as v2? or resend as a new patch?
sorry it's a bit confusing.

Sam

Quoted 28 lines
Quoted 28 lines
---
 drivers/staging/qlge/qlge_dbg.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/qlge/qlge_dbg.c +2 -2
index 1795533cbd3a..8bf592812518 100644
@@ -496,7 +496,8 @@ static int ql_get_mpi_shadow_regs(struct ql_adapter *qdev, u32 *buf)
 static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf,
 			   u32 offset, u32 count)
 {
-	int i, status = 0;
+	int i;
+	int status = 0;
 
 	for (i = 0; i < count; i++, buf++) {
 		status = ql_read_mpi_reg(qdev, offset + i, buf);
--

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200318202747.4218-1-jane.pnx9%40gmail.com.

#3 lore raw
Quoted 14 lines · Sam Muhammed
Quoted 13 lines · Julia Lawall
Quoted 3 lines · Sam Muhammed

This driver maintains a coding style of declaring variables and assigning values to them in separate lines. There are anomalies, elemenate them.

I think I was not clear. When I suggested to do only one thing, rather than starting with a series, I meant that you should do one or the other of the things in your previous patch, but not both. If you make multiple changes to a file, they must be in a series, or Greg won't know in what order to apply them.

Quoted 7 lines
Quoted 3 lines

julia

Oh, so this patch should have this one _logical_ change only? so i resend as v2? or resend as a new patch?
sorry it's a bit confusing.

You have sent two patches on the same file. Each one indeed does have only one change. But since they are affecting the same file, to submit both of them, you have to make a series, to indicate the other in which they are applied.

Since this is your first patch, I would suggest to forget about this patch and forget about the series, and just get the patch with the blank lines accepted.

That one needs to be a v3 now, because you have sent two previous versions. As compared to v2 you are just adding the versioning information. As compared to v1 you are dropping the declaration splitting change to only do one thing.

julia

Quoted 34 lines

Sam

Quoted 28 lines
Quoted 28 lines
---
 drivers/staging/qlge/qlge_dbg.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/qlge/qlge_dbg.c +2 -2
index 1795533cbd3a..8bf592812518 100644
@@ -496,7 +496,8 @@ static int ql_get_mpi_shadow_regs(struct ql_adapter *qdev, u32 *buf)
 static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf,
 			   u32 offset, u32 count)
 {
-	int i, status = 0;
+	int i;
+	int status = 0;
 
 	for (i = 0; i < count; i++, buf++) {
 		status = ql_read_mpi_reg(qdev, offset + i, buf);
--

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200318202747.4218-1-jane.pnx9%40gmail.com.