Skip to contentSkip to conversation

cnm-wave-fw: update firmware name to wave521c_k3_codec_fw.bin

PATCH In review Praneeth Bajjuri 2 participants 3 messages Oct 25, 2022 – Oct 26, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cnm-wave-fw: update firmware name to wave521c_k3_codec_fw.bin

update firmware name to wave521c_k3_codec_fw.bin to align with linux-firmware main branch. the following patch is part of ti-linux-firmware thru mainline sync.

commit 48407ffd ("cnm: update chips&media wave521c firmware.")

---
 recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb +3 -3
index b5ad3e31..75b8ce21 100644
@@ -21,9 +21,9 @@ S = "${WORKDIR}/git"
 TARGET_WAVE521C = "wave521c_codec_fw.bin"
 
 SOURCE_WAVE521C = "wave521c_codec_fw.bin"
-SOURCE_WAVE521C_j721s2-evm = "wave521c_j721s2_codec_fw.bin"
-SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_j721s2_codec_fw.bin"
-SOURCE_WAVE521C_j784s4-evm = "wave521c_j721s2_codec_fw.bin"
+SOURCE_WAVE521C_j721s2-evm = "wave521c_k3_codec_fw.bin"
+SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_k3_codec_fw.bin"
+SOURCE_WAVE521C_j784s4-evm = "wave521c_k3_codec_fw.bin"
 
 ALTERNATIVE_LINK_NAME[wave521c_codec_fw.bin] = "${base_libdir}/firmware/${TARGET_WAVE521C}"
 ALTERNATIVE_TARGET[wave521c_codec_fw.bin] = "${base_libdir}/firmware/cnm/${TARGET_WAVE521C}"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 16 lines · Praneeth Bajjuri

update firmware name to wave521c_k3_codec_fw.bin to align with linux-firmware main branch. the following patch is part of ti-linux-firmware thru mainline sync.

commit 48407ffd ("cnm: update chips&media wave521c firmware.")

---
  recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb +0 -0
index b5ad3e31..75b8ce21 100644

recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb S = "${WORKDIR}/git" · line 26

Quoted 9 lines
recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb +3 -3
@@ -21,9 +21,9 @@ S = "${WORKDIR}/git"
  TARGET_WAVE521C = "wave521c_codec_fw.bin"
 
  SOURCE_WAVE521C = "wave521c_codec_fw.bin"
-SOURCE_WAVE521C_j721s2-evm = "wave521c_j721s2_codec_fw.bin"
-SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_j721s2_codec_fw.bin"
-SOURCE_WAVE521C_j784s4-evm = "wave521c_j721s2_codec_fw.bin"
+SOURCE_WAVE521C_j721s2-evm = "wave521c_k3_codec_fw.bin"
+SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_k3_codec_fw.bin"
+SOURCE_WAVE521C_j784s4-evm = "wave521c_k3_codec_fw.bin"

I'm going to say No to this patch. The only reason I set the file up the way I did was because of the name of the orig file: wave521c_j721s2_codec_fw.bin

If all of the platforms will now use the same file, then I would rather eliminate the machine overrides and just change the default setting for SOURCE_WAVE521C to be the "correct" value.

I'll put out an alternative patch here in a few minutes.

Quoted 2 lines
recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb +0 -0
  ALTERNATIVE_LINK_NAME[wave521c_codec_fw.bin] = "${base_libdir}/firmware/${TARGET_WAVE521C}"
  ALTERNATIVE_TARGET[wave521c_codec_fw.bin] = "${base_libdir}/firmware/cnm/${TARGET_WAVE521C}"
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#2 lore raw
Quoted 31 lines · Ryan Eatmon
Quoted 18 lines · Praneeth Bajjuri

update firmware name to wave521c_k3_codec_fw.bin to align with linux-firmware main branch. the following patch is part of ti-linux-firmware thru mainline sync.

commit 48407ffd ("cnm: update chips&media wave521c firmware.")

---
  recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 6 +++---

  1 file changed, 3 insertions(+), 3 deletions(-)
recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb +0 -0
index b5ad3e31..75b8ce21 100644
@@ -21,9 +21,9 @@ S = "${WORKDIR}/git"

  TARGET_WAVE521C = "wave521c_codec_fw.bin"
  SOURCE_WAVE521C = "wave521c_codec_fw.bin"

recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb S = "${WORKDIR}/git" · line 26

Quoted 6 lines
recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb +3 -3
-SOURCE_WAVE521C_j721s2-evm = "wave521c_j721s2_codec_fw.bin"
-SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_j721s2_codec_fw.bin"
-SOURCE_WAVE521C_j784s4-evm = "wave521c_j721s2_codec_fw.bin"
+SOURCE_WAVE521C_j721s2-evm = "wave521c_k3_codec_fw.bin"
+SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_k3_codec_fw.bin"
+SOURCE_WAVE521C_j784s4-evm = "wave521c_k3_codec_fw.bin"

I'm going to say No to this patch.  The only reason I set the file up the way I did was because of the name of the orig file: wave521c_j721s2_codec_fw.bin

Quoted 3 lines

If all of the platforms will now use the same file, then I would rather eliminate the machine overrides and just change the default setting for SOURCE_WAVE521C to be the "correct" value.

I'll put out an alternative patch here in a few minutes.

Thanks for quick review. Sounds good to me.

Quoted 6 lines
Quoted 5 lines

  ALTERNATIVE_LINK_NAME[wave521c_codec_fw.bin] = "${base_libdir}/firmware/${TARGET_WAVE521C}" ALTERNATIVE_TARGET[wave521c_codec_fw.bin] = "${base_libdir}/firmware/cnm/${TARGET_WAVE521C}"