ath5k: write beacon control register twice when resetting tsf
PATCH 1/1 ath5k: write beacon control register twice when resetting tsf
According to the newly-released Atheros HAL code, asserting the TSF reset bit will toggle a hardware internal state, resulting in a spurious reset on the next chip reset. Whenever we force a TSF bit, write the bit twice to clear the internal signal.
---
This was the only major difference I found between code we're currently using in pcu.c and its equivalents in the HAL. See comment in ar5212ResetTsf. This is only compile-tested.
(There are other differences but they are in the key setup code or beacon setup code that we are not using right now.)
drivers/net/wireless/ath5k/pcu.c | 14 +++++++++++++- 1 files changed, 13 insertions(+), 1 deletions(-)
drivers/net/wireless/ath5k/pcu.c +13 -1
@@ -633,8 +633,20 @@ u64 ath5k_hw_get_tsf64(struct ath5k_hw *ah)*/ void ath5k_hw_reset_tsf (struct ath5k_hw *ah) { +u32 val; +ATH5K_TRACE (ah->ah_sc); -AR5K_REG_ENABLE_BITS (ah,AR5K_BEACON ,AR5K_BEACON_RESET_TSF ); + + val =ath5k_hw_reg_read (ah,AR5K_BEACON ) |AR5K_BEACON_RESET_TSF ; + +/* +* Each write to the RESET_TSF bit toggles a hardware internal +* signal to reset TSF, but if left high it will cause a TSF reset +* on the next chip reset as well. Thus we always write the value +* twice to clear the signal. +*/ +ath5k_hw_reg_write (ah, val,AR5K_BEACON ); +ath5k_hw_reg_write (ah, val,AR5K_BEACON ); }/*
Signature · 4 lines
1.5.4.2.182.gb3092 -- Bob Copeland %% www.bobcopeland.com
2008/9/28 Bob Copeland <[email protected]>:
Quoted 47 lines
According to the newly-released Atheros HAL code, asserting the TSF reset bit will toggle a hardware internal state, resulting in a spurious reset on the next chip reset. Whenever we force a TSF bit, write the bit twice to clear the internal signal.
Signed-off-by Bob Copeland <[email protected]>---
This was the only major difference I found between code we're currently using in
pcu.cand its equivalents in the HAL. See comment in ar5212ResetTsf. This is only compile-tested.(There are other differences but they are in the key setup code or beacon setup code that we are not using right now.)
drivers/net/wireless/ath5k/pcu.c | 14 +++++++++++++- 1 files changed, 13 insertions(+), 1 deletions(-)drivers/net/wireless/ath5k/pcu.c +13
-2@@ -633,8 +633,20 @@ u64 ath5k_hw_get_tsf64(struct ath5k_hw *ah)*/ void ath5k_hw_reset_tsf (struct ath5k_hw *ah) { +u32 val; +ATH5K_TRACE (ah->ah_sc); -AR5K_REG_ENABLE_BITS (ah,AR5K_BEACON ,AR5K_BEACON_RESET_TSF ); + + val =ath5k_hw_reg_read (ah,AR5K_BEACON ) |AR5K_BEACON_RESET_TSF ; + +/* +* Each write to the RESET_TSF bit toggles a hardware internal +* signal to reset TSF, but if left high it will cause a TSF reset +* on the next chip reset as well. Thus we always write the value +* twice to clear the signal. +*/ +ath5k_hw_reg_write (ah, val,AR5K_BEACON ); +ath5k_hw_reg_write (ah, val,AR5K_BEACON ); }/* -- 1.5.4.2.182.gb3092
Quoted 8 lines
--
Bob Copeland %% www.bobcopeland.com_______________________________________________
ath5k-devel mailing list
[email protected]
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Signature · 3 lines
GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick