Skip to contentSkip to conversation

IPMI Watchdog patch

PATCH Corey Minyard 1 participant 1 message Aug 2, 2004

Subsystems (2)
Documentation IPMI
lore
Share & tools
lore

Corey Minyard

author
#0 lore raw

Andrew,

The following patch is ready for inclusion; it makes the IPMI watchdog more consistent with the other watchdog drivers.

I have tested this and it seems to work correctly. I also added docs for the interface change.

- support disabling watchdog by writing 'V' to device.
- unify printk()
- use atomic bit operations on ipmi_wdog_open

Signed-off-by Arkadiusz Miskiewicz <[email protected]>
Signed-off-by Corey Minyard <[email protected]>
Documentation/IPMI.txt +5 -0
Index: linux-ipmi/Documentation/IPMI.txt
===================================================================
@@ -496,3 +496,8 @@
 Note that if you use the NMI preaction for the watchdog, you MUST
 NOT use nmi watchdog mode 1.  If you use the NMI watchdog, you
 must use mode 2.
+
+Once you open the watchdog timer, you must write a 'V' character to the
+device to close it, or the timer will not stop.  This is a new semantic
+for the driver, but makes it consistent with the rest of the watchdog
+drivers in Linux.
drivers/char/ipmi/ipmi_watchdog.c +42 -27

209 lines not on this page · raw message