arm64: dts: rockchip: Add dma-names to uart-bluetooth rk3566 devices
Subsystems (2)
This is a single patch which adds the dma-names property to the uart node with a bluetooth subnode on Pine64's rk356x devices.
But that property can potentially be added to several other devices, but I have zero familiarity with them or their community, so I choose not to add it to those devices, but inform people via this cover letter.
The dts/dtsi files I found as potential candidates are:
- rk3566-anbernic-rgxx3.dtsi
- rk3566-box-demo.dts
- rk3566-powkiddy-rk2023.dtsi
- rk3566-powkiddy-x55.dts
- rk3566-radxa-cm3.dtsi
- rk3566-rock-3c.dts
- rk3566-roc-pc.dts
- rk3568-rock-3a.dts
PATCH 1/1 arm64: dts: rockchip: Add dma-names to uart1 on Pine64 rk3566 devices
Similar to bf6f26deb0e8 ("arm64: dts: rockchip: Add dma-names to uart1 on quartz64-b") also add the dma-names property to the other rk3566 devices from Pine64 with bluetooth functionality.
--- arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 1 + arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi | 1 + 3 files changed, 3 insertions(+)
arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi +1 -0
@@ -674,6 +674,7 @@ &tsadc { }; &uart1 { + dma-names = "tx", "rx"; pinctrl-0 = <&uart1m0_ctsn>, <&uart1m0_rtsn>, <&uart1m0_xfer>; pinctrl-names = "default"; uart-has-rtscts;
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +1 -0
@@ -738,6 +738,7 @@ &uart0 { }; &uart1 { + dma-names = "tx", "rx"; pinctrl-names = "default"; pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>; status = "okay";
arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi +1 -0
@@ -614,6 +614,7 @@ &tsadc { }; &uart1 { + dma-names = "tx", "rx"; pinctrl-names = "default"; pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>; uart-has-rtscts;
Signature · 1 line
2.45.2
Re: [PATCH] arm64: dts: rockchip: Add dma-names to uart1 on Pine64 rk3566 devices
Quoted 40 lines · Diederik de Haas
Similar to
bf6f26deb0e8("arm64: dts: rockchip: Add dma-names to uart1 on quartz64-b") also add the dma-names property to the other rk3566 devices from Pine64 with bluetooth functionality.Signed-off-by Diederik de Haas <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 1 + arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi | 1 + 3 files changed, 3 insertions(+)arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi +1
-0@@ -674,6 +674,7 @@ &tsadc { }; &uart1 { + dma-names = "tx", "rx"; pinctrl-0 = <&uart1m0_ctsn>, <&uart1m0_rtsn>, <&uart1m0_xfer>; pinctrl-names = "default"; uart-has-rtscts;arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +1
-0@@ -738,6 +738,7 @@ &uart0 { }; &uart1 { + dma-names = "tx", "rx"; pinctrl-names = "default"; pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>; status = "okay";arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi +0
-0
arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi &tsadc { · line 620
Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi +1
-0@@ -614,6 +614,7 @@ &tsadc { }; &uart1 { + dma-names = "tx", "rx"; pinctrl-names = "default"; pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>; uart-has-rtscts;
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH] arm64: dts: rockchip: Add dma-names to uart1 on Pine64 rk3566 devices
In reply to Diederik de HaasQuoted 5 lines · Diederik de Haas
Similar to
bf6f26deb0e8("arm64: dts: rockchip: Add dma-names to uart1 on quartz64-b") also add the dma-names property to the other rk3566 devices from Pine64 with bluetooth functionality.
Applied, thanks!
[1/1] arm64: dts: rockchip: Add dma-names to uart1 on Pine64 rk3566 devices
commit: 3087576e1c706bcd3623b48478ea8c9b23173107
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>
Quoted 6 lines · Diederik de Haas
This is a single patch which adds the dma-names property to the uart node with a bluetooth subnode on Pine64's rk356x devices.
But that property can potentially be added to several other devices, but I have zero familiarity with them or their community, so I choose not to add it to those devices, but inform people via this cover letter.
Thank you, but based on past experience the bluetooth failed to work when I had the DMA names present (which is why I removed them on my devices). I will however test it again to confirm that is still the case or not.
Quoted 10 lines
The dts/dtsi files I found as potential candidates are:
-rk3566-anbernic-rgxx3.dtsi
-rk3566-box-demo.dts
-rk3566-powkiddy-rk2023.dtsi
-rk3566-powkiddy-x55.dts
-rk3566-radxa-cm3.dtsi
-rk3566-rock-3c.dts
-rk3566-roc-pc.dts
-rk3568-rock-3a.dts
Quoted 11 lines · On Monday, 8 July 2024 18:05:05 CEST Chris Morgan wrote:
Quoted 6 lines
This is a single patch which adds the dma-names property to the uart node with a bluetooth subnode on Pine64's rk356x devices.
But that property can potentially be added to several other devices, but I have zero familiarity with them or their community, so I choose not to add it to those devices, but inform people via this cover letter.
Thank you, but based on past experience the bluetooth failed to work when I had the DMA names present (which is why I removed them on my devices). I will however test it again to confirm that is still the case or not.
That is very well possible as I had specifically you in mind when I chose to only apply it to Pine64 devices (as I could directly contact those people). I had a vague recollection that there was 'something' with bluetooth on devices you added.
Thus it seemed better to inform people of the possibility, but let the actual implementation up to them.
Cheers,
Diederik