Skip to contentSkip to conversation

CVS: alsa-kernel/core pcm_native.c,1.102,1.103

alsa-cvslog James Courtier-Dutton 1 participant 1 message Aug 10, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

There is a bug in this patch!

Quoted 16 lines · Jaroslav Kysela

Update of /cvsroot/alsa/alsa-kernel/core
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv32435

Modified Files:
pcm_native.c
Log Message:
Serialize runtime->status->state access

Index: pcm_native.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/core/pcm_native.c,v retrieving revision 1.102
retrieving revision 1.103
diff -u -r1.102 -r1.103

pcm_native.c +0 -0

<snip>

pcm_native.c line 479

Quoted 9 lines
pcm_native.c +1 -1
@@ -473,11 +479,16 @@
 static int snd_pcm_sw_params(snd_pcm_substream_t * substream, snd_pcm_sw_params_t *params)
 {
 	snd_pcm_runtime_t *runtime;
+
 	snd_assert(substream != NULL, return -ENXIO);
 	runtime = substream->runtime;
 	snd_assert(runtime != NULL, return -ENXIO);
-	if (runtime->status->state == SNDRV_PCM_STATE_OPEN)

The following line should be "lock" and not "unlock"

pcm_native.c line 494

Quoted 9 lines
pcm_native.c +5 -0
+	snd_pcm_stream_unlock_irq(substream);
+	if (runtime->status->state == SNDRV_PCM_STATE_OPEN) {
+		snd_pcm_stream_unlock_irq(substream);
 		return -EBADFD;
+	}
+	snd_pcm_stream_unlock_irq(substream);
 
 	if (params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST)
 		return -EINVAL;

<snip>

-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285