Skip to contentSkip to conversation

Remove wildcard on KBUILD_OUTPUT

PATCH Applied Coywolf Qi Hunt 2 participants 2 messages Aug 12, 2004 – Aug 15, 2004 4 messages not in the archive Kbuild

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Coywolf Qi Hunt

author
#4 lore raw

PATCH 1/1 Remove wildcard on KBUILD_OUTPUT

Quoted 6 lines · [email protected] wrote:
Quoted 5 lines

You misunderstood me.
This patch removes unnecessary wildcard on KBUILD_OUTPUT and unused VPATH. If it looks ok, I'd like to send it to lkml and akpm.

Quoted 7 lines

Try building a kernel where you use O= to specify another output directory. Try with an existing and a non-existing directory.

You will see why both are needed.

I searched VPATH in the manual. I was wrong on removing VPATH. But I still think wildcard is unnecessary.

I did build kernel with another output directory, both existing and non-existing before mailling you. And even when KBUILD_OUTPUT contains wildcard. Ok, I just saw Kai's reply. I Needn't further explain.

Quoted 5 lines · Kai Germaschewski
Quoted 4 lines

Try building a kernel where you use O= to specify another output directory. Try with an existing and a non-existing directory.

Quoted 7 lines

I suspect that the patch works, if $(shell ...) returns what's written to stdout, KBUILD_OUTPUT would be empty and thus the wildcard unnecessary. Of course I'm too lazy to test it out, too...

--Kai

Signed-off-by Coywolf Qi Hunt <[email protected]>
Makefile +0 -0
@@ -102,7 +102,7 @@ ifneq ($(KBUILD_OUTPUT),)

# check that the output directory actually exists
saved-output := $(KBUILD_OUTPUT)
KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT) && /bin/pwd)
-$(if $(wildcard $(KBUILD_OUTPUT)),, \
+$(if $(KBUILD_OUTPUT),, \
     $(error output directory "$(saved-output)" does not exist))

.PHONY: $(MAKECMDGOALS)

Signature · 3 lines
Coywolf Qi Hunt
Homepage http://greatcn.org/~coywolf/
Admin of http://GreatCN.org and http://LoveCN.org
Applied
#5 lore raw
Quoted 4 lines · Coywolf Qi Hunt
Quoted 2 lines · [email protected] wrote:
Quoted 2 lines

You misunderstood me.
This patch removes unnecessary wildcard on KBUILD_OUTPUT

Applied, thanks.

Sam