dt-bindings: phy: bcm-ns-usb3-phy: convert to yaml
Subsystems (2)
PATCH 1/1 dt-bindings: phy: bcm-ns-usb3-phy: convert to yaml
From: Rafał Miłecki <[email protected]>
1. Change syntax from txt to yaml
2. Drop "Driver for" from the title
3. Drop "reg = <0x0>;" from example (noticed by dt_binding_check)
4. Specify license
---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?
This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
[0] https://lkml.org/lkml/2020/2/18/1084
--- .../bindings/phy/bcm-ns-usb3-phy.txt | 34 ---------- .../bindings/phy/bcm-ns-usb3-phy.yaml | 62 +++++++++++++++++++ 2 files changed, 62 insertions(+), 34 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txt create mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml
Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txt deleted +0 -34
@@ -1,34 +0,0 @@ -Driver for Broadcom Northstar USB 3.0 PHY - -Required properties: - -- compatible: one of: "brcm,ns-ax-usb3-phy", "brcm,ns-bx-usb3-phy". -- reg: address of MDIO bus device -- usb3-dmp-syscon: phandle to syscon with DMP (Device Management Plugin) - registers -- #phy-cells: must be 0 - -Initialization of USB 3.0 PHY depends on Northstar version. There are currently -three known series: Ax, Bx and Cx. -Known A0: BCM4707 rev 0 -Known B0: BCM4707 rev 4, BCM53573 rev 2 -Known B1: BCM4707 rev 6 -Known C0: BCM47094 rev 0 - -Example: - mdio: mdio@0 { - reg = <0x0>; - #size-cells = <1>; - #address-cells = <0>; - - usb3-phy@10 { - compatible = "brcm,ns-ax-usb3-phy"; - reg = <0x10>; - usb3-dmp-syscon = <&usb3_dmp>; - #phy-cells = <0>; - }; - }; - - usb3_dmp: syscon@18105000 { - reg = <0x18105000 0x1000>; - };
Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml new file +62 -0
62 lines not on this page · raw message
Signature · 1 line
2.27.0
PATCH 1/1 dt-bindings: phy: bcm-ns-usb2-phy: convert to yaml
From: Rafał Miłecki <[email protected]>
1. Convert from txt to yaml
2. Drop "Driver for" from the title
3. Document "#phy-cells"
4. Fix example node name (noticed by dt_binding_check)
5. Add #include to example (noticed by dt_binding_check)
6. Specify license
---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?
This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
[0] https://lkml.org/lkml/2020/2/18/1084
--- .../bindings/phy/bcm-ns-usb2-phy.txt | 21 ------- .../bindings/phy/bcm-ns-usb2-phy.yaml | 59 +++++++++++++++++++ 2 files changed, 59 insertions(+), 21 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.txt create mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.yaml
Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.txt deleted +0 -21
@@ -1,21 +0,0 @@ -Driver for Broadcom Northstar USB 2.0 PHY - -Required properties: -- compatible: brcm,ns-usb2-phy -- reg: iomem address range of DMU (Device Management Unit) -- reg-names: "dmu", the only needed & supported reg right now -- clocks: USB PHY reference clock -- clock-names: "phy-ref-clk", the only needed & supported clock right now - -To initialize USB 2.0 PHY driver needs to setup PLL correctly. To do this it -requires passing phandle to the USB PHY reference clock. - -Example: - usb2-phy { - compatible = "brcm,ns-usb2-phy"; - reg = <0x1800c000 0x1000>; - reg-names = "dmu"; - #phy-cells = <0>; - clocks = <&genpll BCM_NSP_GENPLL_USB_PHY_REF_CLK>; - clock-names = "phy-ref-clk"; - };
Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.yaml new file +59 -0
59 lines not on this page · raw message
Signature · 1 line
2.27.0
Re: [PATCH] dt-bindings: phy: bcm-ns-usb2-phy: convert to yaml
Quoted 18 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
1. Convert from txt to yaml
2. Drop "Driver for" from the title
3. Document "#phy-cells"
4. Fix example node name (noticed bydt_binding_check)
5. Add #include to example (noticed bydt_binding_check)
6. Specify licenseSigned-off-by Rafał Miłecki <[email protected]>---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See:Documentation/devicetree/bindings/submitting-patches.rst
Quoted 8 lines
[0] https://lkml.org/lkml/2020/2/18/1084
--- .../bindings/phy/bcm-ns-usb2-phy.txt | 21 ------- .../bindings/phy/bcm-ns-usb2-phy.yaml | 59 +++++++++++++++++++ 2 files changed, 59 insertions(+), 21 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.txt create mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.yaml
Re: [PATCH] dt-bindings: phy: bcm-ns-usb2-phy: convert to yaml
In reply to Rafał MiłeckiQuoted 14 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
1. Convert from txt to yaml
2. Drop "Driver for" from the title
3. Document "#phy-cells"
4. Fix example node name (noticed bydt_binding_check)
5. Add #include to example (noticed bydt_binding_check)
6. Specify licenseSigned-off-by Rafał Miłecki <[email protected]>---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?
Quoted 5 lines
This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See:Documentation/devicetree/bindings/submitting-patches.rst
Same thing here.
Kishon, Vinod: I sent this patch back in December, it was Reviewed-by Rob, but never accepted.
Could you push this patch to the linux-phy.git?
Quoted 100 lines
--- .../bindings/phy/bcm-ns-usb2-phy.txt | 21 ------- .../bindings/phy/bcm-ns-usb2-phy.yaml | 59 +++++++++++++++++++ 2 files changed, 59 insertions(+), 21 deletions(-)delete mode 100644
Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.txtcreate mode 100644Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.yamlDocumentation/devicetree/bindings/phy/bcm-ns-usb2-phy.txt deleted +0
-21@@ -1,21 +0,0 @@ -Driver for Broadcom Northstar USB 2.0 PHY - -Required properties: -- compatible: brcm,ns-usb2-phy -- reg: iomem address range of DMU (Device Management Unit) -- reg-names: "dmu", the only needed & supported reg right now -- clocks: USB PHY reference clock -- clock-names: "phy-ref-clk", the only needed & supported clock right now - -To initialize USB 2.0 PHY driver needs to setup PLL correctly. To do this it -requires passing phandle to the USB PHY reference clock. - -Example: - usb2-phy { - compatible = "brcm,ns-usb2-phy"; - reg = <0x1800c000 0x1000>; - reg-names = "dmu"; - #phy-cells = <0>; - clocks = <&genpll BCM_NSP_GENPLL_USB_PHY_REF_CLK>; - clock-names = "phy-ref-clk"; - };Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.yaml new file +59
-0@@ -0,0 +1,59 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/bcm-ns-usb2-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom Northstar USB 2.0 PHY + +description: > + To initialize USB 2.0 PHY driver needs to setup PLL correctly. + To do this it requires passing phandle to the USB PHY reference clock. + +maintainers: + - Rafał Miłecki <[email protected]> + +properties: + compatible: + const: brcm,ns-usb2-phy + + reg: + items: + - description: iomem address range of DMU (Device Management Unit) + + reg-names: + items: + - const: dmu + + clocks: + items: + - description: USB PHY reference clock + + clock-names: + items: + - const: phy-ref-clk + + "#phy-cells": + const: 0 + +required: + - compatible + - reg + - reg-names + - clocks + - clock-names + - "#phy-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/bcm-nsp.h> + phy@1800c000 { + compatible = "brcm,ns-usb2-phy"; + reg = <0x1800c000 0x1000>; + reg-names = "dmu"; + clocks = <&genpll BCM_NSP_GENPLL_USB_PHY_REF_CLK>; + clock-names = "phy-ref-clk"; + #phy-cells = <0>; + };
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Vinod Koul
maintainerQuoted 6 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
1. Change syntax from txt to yaml
2. Drop "Driver for" from the title
3. Drop "reg = <0x0>;" from example (noticed bydt_binding_check)
4. Specify license
You missed Ccing Rob
Quoted 9 lines
Signed-off-by Rafał Miłecki <[email protected]>---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See:Documentation/devicetree/bindings/submitting-patches.rst
That is okay, it is a warning ;-)
Quoted 119 lines
[0] https://lkml.org/lkml/2020/2/18/1084
--- .../bindings/phy/bcm-ns-usb3-phy.txt | 34 ---------- .../bindings/phy/bcm-ns-usb3-phy.yaml | 62 +++++++++++++++++++ 2 files changed, 62 insertions(+), 34 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txt create mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yamlDocumentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txt deleted +0
-34@@ -1,34 +0,0 @@ -Driver for Broadcom Northstar USB 3.0 PHY - -Required properties: - -- compatible: one of: "brcm,ns-ax-usb3-phy", "brcm,ns-bx-usb3-phy". -- reg: address of MDIO bus device -- usb3-dmp-syscon: phandle to syscon with DMP (Device Management Plugin) - registers -- #phy-cells: must be 0 - -Initialization of USB 3.0 PHY depends on Northstar version. There are currently -three known series: Ax, Bx and Cx. -Known A0: BCM4707 rev 0 -Known B0: BCM4707 rev 4, BCM53573 rev 2 -Known B1: BCM4707 rev 6 -Known C0: BCM47094 rev 0 - -Example: - mdio: mdio@0 { - reg = <0x0>; - #size-cells = <1>; - #address-cells = <0>; - - usb3-phy@10 { - compatible = "brcm,ns-ax-usb3-phy"; - reg = <0x10>; - usb3-dmp-syscon = <&usb3_dmp>; - #phy-cells = <0>; - }; - }; - - usb3_dmp: syscon@18105000 { - reg = <0x18105000 0x1000>; - };Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml new file +62
-0@@ -0,0 +1,62 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/bcm-ns-usb3-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom Northstar USB 3.0 PHY + +description: | + Initialization of USB 3.0 PHY depends on Northstar version. There are currently + three known series: Ax, Bx and Cx. + Known A0: BCM4707 rev 0 + Known B0: BCM4707 rev 4, BCM53573 rev 2 + Known B1: BCM4707 rev 6 + Known C0: BCM47094 rev 0 + +maintainers: + - Rafał Miłecki <[email protected]> + +properties: + compatible: + enum: + - brcm,ns-ax-usb3-phy + - brcm,ns-bx-usb3-phy + + reg: + description: address of MDIO bus device + maxItems: 1 + + usb3-dmp-syscon: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the DMP (Device Management Plugin) syscon + + "#phy-cells": + const: 0 + +required: + - compatible + - reg + - usb3-dmp-syscon + - "#phy-cells" + +additionalProperties: false + +examples: + - | + mdio { + #address-cells = <1>; + #size-cells = <0>; + + usb3-phy@10 { + compatible = "brcm,ns-ax-usb3-phy"; + reg = <0x10>; + usb3-dmp-syscon = <&usb3_dmp>; + #phy-cells = <0>; + }; + }; + + usb3_dmp: syscon@18105000 { + reg = <0x18105000 0x1000>; + };Signature · 1 line
2.27.0
Signature · 1 line
~Vinod
Vinod Koul
maintainerQuoted 7 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
1. Change syntax from txt to yaml
2. Drop "Driver for" from the title
3. Drop "reg = <0x0>;" from example (noticed bydt_binding_check)
4. Specify license
Quoted 8 lines
Signed-off-by Rafał Miłecki <[email protected]>---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See:Documentation/devicetree/bindings/submitting-patches.rst
I am seeing warnings for indentation:
Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation) Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:20:12: [warning] wrong indentation: expected 12 but found 11 (indentation) Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:26:9: [warning] wrong indentation: expected 10 but found 8 (indentation) Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation) Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:30:9: [warning] wrong indentation: expected 10 but found 8 (indentation) Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:51:6: [warning] wrong indentation: expected 4 but found 5 (indentation) Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:71:11: [warning] wrong indentation: expected 9 but found 10 (indentation) Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:80:11: [warning] wrong indentation: expected 9 but found 10 (indentation) Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:88:11: [warning] wrong indentation: expected 9 but found 10 (indentation)
Can you pls fix those as well
Signature · 1 line
~Vinod
Quoted 29 lines · Vinod Koul
Quoted 7 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
1. Change syntax from txt to yaml
2. Drop "Driver for" from the title
3. Drop "reg = <0x0>;" from example (noticed bydt_binding_check)
4. Specify licenseQuoted 8 lines
Signed-off-by Rafał Miłecki <[email protected]>---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See:Documentation/devicetree/bindings/submitting-patches.rstI am seeing warnings for indentation:
Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:20:12: [warning] wrong indentation: expected 12 but found 11 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:26:9: [warning] wrong indentation: expected 10 but found 8 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:30:9: [warning] wrong indentation: expected 10 but found 8 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:51:6: [warning] wrong indentation: expected 4 but found 5 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:71:11: [warning] wrong indentation: expected 9 but found 10 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:80:11: [warning] wrong indentation: expected 9 but found 10 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:88:11: [warning] wrong indentation: expected 9 but found 10 (indentation)
Quoted 1 line
Can you pls fix those as well
Sure, just note, it's a different YAML file (I missed that initially and was triple checking my bcm-ns-usb3-phy.yaml ;) ). So I'll handle it using a different patch.
Quoted 30 lines · Rafał Miłecki
Quoted 29 lines · Vinod Koul
Quoted 7 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
1. Change syntax from txt to yaml
2. Drop "Driver for" from the title
3. Drop "reg = <0x0>;" from example (noticed bydt_binding_check)
4. Specify licenseQuoted 8 lines
Signed-off-by Rafał Miłecki <[email protected]>---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See:Documentation/devicetree/bindings/submitting-patches.rstI am seeing warnings for indentation:
Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:20:12: [warning] wrong indentation: expected 12 but found 11 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:26:9: [warning] wrong indentation: expected 10 but found 8 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:30:9: [warning] wrong indentation: expected 10 but found 8 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:51:6: [warning] wrong indentation: expected 4 but found 5 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:71:11: [warning] wrong indentation: expected 9 but found 10 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:80:11: [warning] wrong indentation: expected 9 but found 10 (indentation)Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:88:11: [warning] wrong indentation: expected 9 but found 10 (indentation)
Quoted 5 lines
Quoted 1 line
Can you pls fix those as well
Sure, just note, it's a different YAML file (I missed that initially and was triple checking my
bcm-ns-usb3-phy.yaml;) ). So I'll handle it using a different patch.
Oh, that file doesn't actualy exist in tree yet. I guess you meant to reply to Florian's patch [PATCH] dt-bindings: phy: Convert Broadcom SATA PHY to YAML
Quoted 16 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
1. Change syntax from txt to yaml
2. Drop "Driver for" from the title
3. Drop "reg = <0x0>;" from example (noticed bydt_binding_check)
4. Specify licenseSigned-off-by Rafał Miłecki <[email protected]>---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See:Documentation/devicetree/bindings/submitting-patches.rst
Quoted 8 lines
[0] https://lkml.org/lkml/2020/2/18/1084
--- .../bindings/phy/bcm-ns-usb3-phy.txt | 34 ---------- .../bindings/phy/bcm-ns-usb3-phy.yaml | 62 +++++++++++++++++++ 2 files changed, 62 insertions(+), 34 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txt create mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml
Hi,
Quoted 12 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
1. Change syntax from txt to yaml
2. Drop "Driver for" from the title
3. Drop "reg = <0x0>;" from example (noticed bydt_binding_check)
4. Specify licenseSigned-off-by Rafał Miłecki <[email protected]>---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?
Quoted 5 lines
This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See:Documentation/devicetree/bindings/submitting-patches.rst
Kishon, Vinod: I sent this patch back in December, it was Reviewed-by Rob, but never accepted.
Could you push this patch to the linux-phy.git?
Quoted 116 lines
--- .../bindings/phy/bcm-ns-usb3-phy.txt | 34 ---------- .../bindings/phy/bcm-ns-usb3-phy.yaml | 62 +++++++++++++++++++ 2 files changed, 62 insertions(+), 34 deletions(-)delete mode 100644
Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txtcreate mode 100644Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yamlDocumentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txt deleted +0
-34@@ -1,34 +0,0 @@ -Driver for Broadcom Northstar USB 3.0 PHY - -Required properties: - -- compatible: one of: "brcm,ns-ax-usb3-phy", "brcm,ns-bx-usb3-phy". -- reg: address of MDIO bus device -- usb3-dmp-syscon: phandle to syscon with DMP (Device Management Plugin) - registers -- #phy-cells: must be 0 - -Initialization of USB 3.0 PHY depends on Northstar version. There are currently -three known series: Ax, Bx and Cx. -Known A0: BCM4707 rev 0 -Known B0: BCM4707 rev 4, BCM53573 rev 2 -Known B1: BCM4707 rev 6 -Known C0: BCM47094 rev 0 - -Example: - mdio: mdio@0 { - reg = <0x0>; - #size-cells = <1>; - #address-cells = <0>; - - usb3-phy@10 { - compatible = "brcm,ns-ax-usb3-phy"; - reg = <0x10>; - usb3-dmp-syscon = <&usb3_dmp>; - #phy-cells = <0>; - }; - }; - - usb3_dmp: syscon@18105000 { - reg = <0x18105000 0x1000>; - };Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml new file +62
-0@@ -0,0 +1,62 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/bcm-ns-usb3-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom Northstar USB 3.0 PHY + +description: | + Initialization of USB 3.0 PHY depends on Northstar version. There are currently + three known series: Ax, Bx and Cx. + Known A0: BCM4707 rev 0 + Known B0: BCM4707 rev 4, BCM53573 rev 2 + Known B1: BCM4707 rev 6 + Known C0: BCM47094 rev 0 + +maintainers: + - Rafał Miłecki <[email protected]> + +properties: + compatible: + enum: + - brcm,ns-ax-usb3-phy + - brcm,ns-bx-usb3-phy + + reg: + description: address of MDIO bus device + maxItems: 1 + + usb3-dmp-syscon: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the DMP (Device Management Plugin) syscon + + "#phy-cells": + const: 0 + +required: + - compatible + - reg + - usb3-dmp-syscon + - "#phy-cells" + +additionalProperties: false + +examples: + - | + mdio { + #address-cells = <1>; + #size-cells = <0>; + + usb3-phy@10 { + compatible = "brcm,ns-ax-usb3-phy"; + reg = <0x10>; + usb3-dmp-syscon = <&usb3_dmp>; + #phy-cells = <0>; + }; + }; + + usb3_dmp: syscon@18105000 { + reg = <0x18105000 0x1000>; + };
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Vinod Koul
maintainerQuoted 19 lines · Rafał Miłecki
Hi,
Quoted 16 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
1. Change syntax from txt to yaml
2. Drop "Driver for" from the title
3. Drop "reg = <0x0>;" from example (noticed bydt_binding_check)
4. Specify licenseSigned-off-by Rafał Miłecki <[email protected]>---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See:Documentation/devicetree/bindings/submitting-patches.rst
Quoted 6 lines
Quoted 1 line
Kishon, Vinod: I sent this patch back in December, it was Reviewed-by Rob, but never accepted.
Could you push this patch to the linux-phy.git?
Can you please rebase and resent me this patch. I am trying to streamline patches now using phy ml and pw instance so that we dont miss anything..
Thanks
Signature · 6 lines
~Vinod -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Quoted 22 lines · Vinod Koul
Quoted 21 lines · Rafał Miłecki
Hi,
Quoted 17 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
1. Change syntax from txt to yaml
2. Drop "Driver for" from the title
3. Drop "reg = <0x0>;" from example (noticed bydt_binding_check)
4. Specify licenseSigned-off-by Rafał Miłecki <[email protected]>---
I think this should go through linux-phy tree. Kishon, Vinod, can you take this patch?This patch generates a false positive checkpatch.pl warning [0].
Please ignore:
WARNING: DT binding docs and includes should be a separate patch. See:Documentation/devicetree/bindings/submitting-patches.rst
Quoted 8 lines
Quoted 4 lines
Kishon, Vinod: I sent this patch back in December, it was Reviewed-by Rob, but never accepted.
Could you push this patch to the linux-phy.git?
Can you please rebase and resent me this patch. I am trying to streamline patches now using phy ml and pw instance so that we dont miss anything..
Both patches apply cleanly. Maybe your mail client malformed them for you?
They are accessible in the devicetree-bindings patchwork:
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/
You can apply both patches doing e.g.:
curl https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/mbox/ | git am curl https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/mbox/ | git am
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy