Skip to contentSkip to conversation

: Remove unnecessary memset in packet schedulers

PATCH Applied Patrick McHardy 2 participants 2 messages Aug 17, 2004

Subsystems (3)
Networking Network drivers Traffic control (tc)
lore
Share & tools
lore

Patrick McHardy

author
#0 lore raw

PATCH 1/1 : Remove unnecessary memset in packet schedulers

This patch removes some more unnecessary memsets in packet schedulers. The qdisc's private data is already set to 0 in qdisc_create/qdisc_create_dflt.

# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2004/08/17 01:30:30+02:00 [email protected]
# [PKT_SCHED]: remove unnecessary memsets in packet schedulers
#
# Signed-off-by: Patrick McHardy <[email protected]>
#

# net/sched/sch_ingress.c
#   2004/08/17 01:30:10+02:00 [email protected] +0 -8
#   [PKT_SCHED]: remove unnecessary memsets in packet schedulers
# 
# net/sched/sch_htb.c
#   2004/08/17 01:30:10+02:00 [email protected] +0 -1
#   [PKT_SCHED]: remove unnecessary memsets in packet schedulers
# 
# net/sched/sch_hfsc.c
#   2004/08/17 01:30:10+02:00 [email protected] +0 -1
#   [PKT_SCHED]: remove unnecessary memsets in packet schedulers
# 
# net/sched/sch_dsmark.c
#   2004/08/17 01:30:10+02:00 [email protected] +0 -2
#   [PKT_SCHED]: remove unnecessary memsets in packet schedulers
# 
# net/sched/sch_atm.c
#   2004/08/17 01:30:10+02:00 [email protected] +0 -1
#   [PKT_SCHED]: remove unnecessary memsets in packet schedulers
# 
diff -Nru a/net/sched/sch_atm.c b/net/sched/sch_atm.c
--- a/net/sched/sch_atm.c	2004-08-17 01:35:21 +02:00
+++ b/net/sched/sch_atm.c	2004-08-17 01:35:21 +02:00
@@ -573,7 +573,6 @@
 	struct atm_qdisc_data *p = PRIV(sch);

DPRINTK("atm_tc_init(sch %p,[qdisc %p],opt %p)\n",sch,p,opt);
- memset(p,0,sizeof(*p));
p->flows = &p->link;
if(!(p->link.q = qdisc_create_dflt(sch->dev,&pfifo_qdisc_ops)))
p->link.q = &noop_qdisc;

net/sched/sch_dsmark.c +0 -2
diff -Nru a/net/sched/sch_dsmark.c b/net/sched/sch_dsmark.c
@@ -331,8 +331,6 @@
 	    !tb[TCA_DSMARK_INDICES-1] ||
 	    RTA_PAYLOAD(tb[TCA_DSMARK_INDICES-1]) < sizeof(__u16))
                 return -EINVAL;
-	memset(p,0,sizeof(*p));
-	p->filter_list = NULL;
 	p->indices = *(__u16 *) RTA_DATA(tb[TCA_DSMARK_INDICES-1]);
 	if (!p->indices)
 		return -EINVAL;
net/sched/sch_hfsc.c +0 -1
diff -Nru a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
@@ -1553,7 +1553,6 @@
 		return -EINVAL;
 	qopt = RTA_DATA(opt);
 
-	memset(q, 0, sizeof(struct hfsc_sched));
 	sch->stats_lock = &sch->dev->queue_lock;
 
 	q->defcls = qopt->defcls;
net/sched/sch_htb.c +0 -1
diff -Nru a/net/sched/sch_htb.c b/net/sched/sch_htb.c
@@ -1277,7 +1277,6 @@
 				HTB_VER >> 16,HTB_VER & 0xffff,gopt->version);
 		return -EINVAL;
 	}
-	memset(q,0,sizeof(*q));
 	q->debug = gopt->debug;
 	HTB_DBG(0,1,"htb_init sch=%p handle=%X r2q=%d\n",sch,sch->handle,gopt->rate2quantum);
net/sched/sch_ingress.c +0 -8
diff -Nru a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c
@@ -289,9 +289,6 @@
 #endif
 #endif
                                                                                 
-	if (NULL == p)
-		goto error;
-
 #ifndef CONFIG_NET_CLS_ACT
 #ifdef CONFIG_NETFILTER
 	if (!nf_registered) {

@@ -305,8 +302,6 @@
 #endif
 
 	DPRINTK("ingress_init(sch %p,[qdisc %p],opt %p)\n",sch,p,opt);
-	memset(p, 0, sizeof(*p));
-	p->filter_list = NULL;
 	p->q = &noop_qdisc;
 	return 0;
 error:

@@ -346,9 +341,6 @@
 		p->filter_list = tp->next;
 		tcf_destroy(tp);
 	}
-	memset(p, 0, sizeof(*p));
-	p->filter_list = NULL;
-
 #if 0
 /* for future use */
 	qdisc_destroy(p->q);
Applied
#1 lore raw
Quoted 3 lines · On Tue, 17 Aug 2004 02:07:32 +0200 Patrick McHardy <[email protected]> wrote:

This patch removes some more unnecessary memsets in packet schedulers. The qdisc's private data is already set to 0 in qdisc_create/qdisc_create_dflt.

Applied.