Skip to contentSkip to conversation

2.6.8.1-mm1: oops with firmware loading

DISCUSSION Maneesh Soni 2 participants 2 messages Aug 17, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 11 lines · Andrew Morton

Begin forwarded message:

Date: Tue, 17 Aug 2004 15:28:18 +0200
From: Manuel Lauss <[email protected]>
To: [email protected], [email protected]
Cc: [email protected]
Subject: 2.6.8.1-mm1: oops with firmware loading

Quoted 5 lines

Hi,

The new sysfs-backingstore patches cause an oops when I ifup a prism54 based device, heres the dmesg section:

My fault, a bad typo in fs/sysfs/bin.c.

Manuel, can you try this change in fs/sysfs/bin.c

bin.c renamed from bin.c.orig +2 -2
@@ -60,8 +60,8 @@
 static int
 flush_write(struct dentry *dentry, char *buffer, loff_t offset, size_t count)
 {
-	struct bin_attribute *attr = to_bin_attr(dentry->d_parent);
-	struct kobject *kobj = to_kobj(dentry);
+	struct bin_attribute *attr = to_bin_attr(dentry);
+	struct kobject *kobj = to_kobj(dentry->d_parent);
 
 	return attr->write(kobj, buffer, offset, count);
 }

Andrew, How do I send the patch? I think hand editting will also work.

Thanks
Maneesh

Signature · 6 lines
Maneesh Soni
Linux Technology Center, 
IBM Austin
email: [email protected]
Phone: 1-512-838-1896 Fax: 
T/L : 6781896
#2 lore raw

Maneesh Soni wrote:

[...]

Quoted 3 lines

My fault, a bad typo in fs/sysfs/bin.c.

Manuel, can you try this change in fs/sysfs/bin.c

<patch snipped>

yup, works, thanks!

Signature · 2 lines
Manuel Lauss
Student HSSE / FH Hagenberg