Skip to contentSkip to conversation

asm-i386/smpboot.h: fix gcc 3.4 compilation

PATCH In review O.Sezer 2 participants 2 messages Aug 26, 2004

lore
Share & tools
lore

O.Sezer

author
#0 lore raw

PATCH 5/6 asm-i386/smpboot.h: fix gcc 3.4 compilation

Didn't look at the code much but how about removing the label as the -ac tree does?

include/asm-i386/smpboot.h +0 -1
diff -urN 28pre2/include/asm-i386/smpboot.h 28pre2_acx/include/asm-i386/smpboot.h
@@ -129,7 +129,6 @@
 			/*round robin the interrupts*/
 			cpu = (cpu+1)%smp_num_cpus;
 			return cpu_to_physical_apicid(cpu);
-		default:
 	}
 	return cpu_online_map;
 }
#1 lore raw
Quoted 3 lines · O.Sezer

Didn't look at the code much but how about removing the label as the -ac tree does?

I remember I once had to add an empty default case in a switch/case in one of my programs to stop gcc from complaining. I think it is the same here and the 'default' does not harm anyway.

And please remember, as a rule of thumb, if it does not change semantics nor the code produced, please try to avoid moving parts of the stable kernel. There are many people who have to apply other patches on top of a vanilla kernel and who don't like it very much when they get rejects just because of a recent code "beautification".

Regards,
Willy

Quoted 11 lines

diff -urN 28pre2/include/asm-i386/smpboot.h 28pre2_acx/include/asm-i386/smpboot.h

include/asm-i386/smpboot.h +0 -1
@@ -129,7 +129,6 @@
 			/*round robin the interrupts*/
 			cpu = (cpu+1)%smp_num_cpus;
 			return cpu_to_physical_apicid(cpu);
-		default:
 	}
 	return cpu_online_map;
 }