Skip to contentSkip to conversation

python3-requests-toolbelt: Remove py3-mock from rdeps

PATCH In review Khem Raj 3 participants 5 messages Jul 6, 2020 – Jul 7, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 python3-requests-toolbelt: Remove py3-mock from rdeps

python3-mock does not exist as independent package

---
 .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb   | 1 -
 1 file changed, 1 deletion(-)
meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb +0 -1
index e075c019d0..27d122cd52 100644
@@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
 RDEPENDS_${PN}-ptest += " \
 	${PYTHON_PN}-pytest \
 	${PYTHON_PN}-betamax \
-	${PYTHON_PN}-mock \
 "
 
 do_install_ptest() {
Signature · 1 line
2.27.0
#1 lore raw
Quoted 2 lines · Khem Raj

python3-mock does not exist as independent package

Sakib,
Perhaps you were bringing it in from meta-cloud-services?
http://layers.openembedded.org/layerindex/recipe/120255/

Quoted 27 lines
---
 .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb   | 1 -
 1 file changed, 1 deletion(-)
(quoted diff) +0 -0

python3-requests-toolbelt_0.9.1.bb b/meta-python/recipes-devtools/python/ python3-requests-toolbelt_0.9.1.bb
index e075c019d0..27d122cd52 100644
--- a/meta-python/recipes-devtools/python/ python3-requests-toolbelt_0.9.1.bb
+++ b/meta-python/recipes-devtools/python/ python3-requests-toolbelt_0.9.1.bb

meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb +0 -2
@@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
 RDEPENDS_${PN}-ptest += " \
        ${PYTHON_PN}-pytest \
        ${PYTHON_PN}-betamax \
-       ${PYTHON_PN}-mock \
 "
 
 do_install_ptest() {
--

2.27.0

author
#2 lore raw
Quoted 11 lines · Tim Orling

On Mon, Jul 6, 2020 at 7:51 AM Khem Raj <[email protected] <mailto:[email protected]>> wrote:

python3-mock does not exist as independent package

Sakib,
Perhaps you were bringing it in from meta-cloud-services?
http://layers.openembedded.org/layerindex/recipe/120255/

yeah, I have dropped the ptest addition patch for now which means I can drop this one too, so please send a v2 with this fixed as well along with other review comments addressed.

Quoted 34 lines
    Signed-off-by: Khem Raj <[email protected] <mailto:[email protected]>>
    Cc: Sakib Sajal <[email protected]
    <mailto:[email protected]>>
    ---
      .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
    <http://python3-requests-toolbelt_0.9.1.bb>   | 1 -
      1 file changed, 1 deletion(-)

    diff --git
    a/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
    <http://python3-requests-toolbelt_0.9.1.bb>
    b/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
    <http://python3-requests-toolbelt_0.9.1.bb>
    index e075c019d0..27d122cd52 100644
    ---
    a/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
    <http://python3-requests-toolbelt_0.9.1.bb>
    +++
    b/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
    <http://python3-requests-toolbelt_0.9.1.bb>
    @@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
      RDEPENDS_${PN}-ptest += " \
             ${PYTHON_PN}-pytest \
             ${PYTHON_PN}-betamax \
    -       ${PYTHON_PN}-mock \
      "

      do_install_ptest() {
    -- 
    2.27.0
#3 lore raw
In reply to Tim Orling
Quoted 10 lines · Tim Orling

On Mon, Jul 6, 2020 at 7:51 AM Khem Raj <[email protected] <mailto:[email protected]>> wrote:

python3-mock does not exist as independent package

Sakib,
Perhaps you were bringing it in from meta-cloud-services?
http://layers.openembedded.org/layerindex/recipe/120255/

Yeah, he's been adding things to support python3-requests-toolbelt (with my help), but we missed that dependency. I think requests-toolbelt is minor enough (while being a useful addition) that it should be in meta-python alongside python3-requests, so for completeness' sake we should move python3-mock in as well.

Quoted 37 lines

    Signed-off-by: Khem Raj <[email protected]
    <mailto:[email protected]>>
    Cc: Sakib Sajal <[email protected]
    <mailto:[email protected]>>
    ---
     .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
    <http://python3-requests-toolbelt_0.9.1.bb>  | 1 -
     1 file changed, 1 deletion(-)

    diff --git
    a/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
    <http://python3-requests-toolbelt_0.9.1.bb>
    b/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
    <http://python3-requests-toolbelt_0.9.1.bb>
    index e075c019d0..27d122cd52 100644
    ---
    a/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
    <http://python3-requests-toolbelt_0.9.1.bb>
    +++
    b/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
    <http://python3-requests-toolbelt_0.9.1.bb>
    @@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
     RDEPENDS_${PN}-ptest += " \
            ${PYTHON_PN}-pytest \
            ${PYTHON_PN}-betamax \
    -       ${PYTHON_PN}-mock \
     "

     do_install_ptest() {
    -- 
    2.27.0
#4 lore raw
Quoted 14 lines · Trevor Gamblin

On 7/6/20 11:01 AM, Tim Orling wrote:

Quoted 2 lines · Khem Raj

python3-mock does not exist as independent package

Sakib,
Perhaps you were bringing it in from meta-cloud-services?
http://layers.openembedded.org/layerindex/recipe/120255/

Quoted 7 lines

Yeah, he's been adding things to support python3-requests-toolbelt (with my help), but we missed that dependency. I think requests-toolbelt is minor enough (while being a useful addition) that it should be in meta-python alongside python3-requests, so for completeness' sake we should move python3-mock in as well.

There are other things that need python3-mock to run ptests (not that I remember an example off the top of my head at the moment), so I agree this makes sense. Please coordinate with meta-cloud-services maintainers to make sure they don’t have any concerns.

Quoted 32 lines
Quoted 29 lines
---
 .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb   | 1 -
 1 file changed, 1 deletion(-)
(quoted diff) +0 -0

python3-requests-toolbelt_0.9.1.bb b/meta-python/recipes-devtools/python/ python3-requests-toolbelt_0.9.1.bb
index e075c019d0..27d122cd52 100644
--- a/meta-python/recipes-devtools/python/ python3-requests-toolbelt_0.9.1.bb
+++ b/meta-python/recipes-devtools/python/ python3-requests-toolbelt_0.9.1.bb

meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb +0 -2
@@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
 RDEPENDS_${PN}-ptest += " \
        ${PYTHON_PN}-pytest \
        ${PYTHON_PN}-betamax \
-       ${PYTHON_PN}-mock \
 "
 
 do_install_ptest() {
--

2.27.0