Skip to contentSkip to conversation

scsi: ufs: core: Remove unused field in struct ufs_hba

PATCH Applied Keoseong Park 4 participants 5 messages Mar 24, 2022 – Apr 7, 2022 1 message not in the archive SCSI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20220324070146epcms2p577d43ce3e7cbd36aa964f3842e49b2ba@epcms2p5

#1 lore raw

PATCH 1/1 scsi: ufs: core: Remove unused field in struct ufs_hba

Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba. Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing sysfs entries.") removed all code using that field.

---
 drivers/scsi/ufs/ufshcd.h | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/ufs/ufshcd.h +0 -2
index 88c20f3608c2..94f545be183a 100644
@@ -820,8 +820,6 @@ struct ufs_hba {
 	enum ufs_pm_level rpm_lvl;
 	/* Desired UFS power management level during system PM */
 	enum ufs_pm_level spm_lvl;
-	struct device_attribute rpm_lvl_attr;
-	struct device_attribute spm_lvl_attr;
 	int pm_op_in_progress;
 
 	/* Auto-Hibernate Idle Timer register value */
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#2 lore raw
Quoted 5 lines

Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba. Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing sysfs entries.") removed all code using that field.

Quoted 19 lines
---
 drivers/scsi/ufs/ufshcd.h | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/ufs/ufshcd.h index renamed from drivers/scsi/ufs/ufshcd.h +0 -0

88c20f3608c2..94f545be183a 100644

drivers/scsi/ufs/ufshcd.h +0 -3
@@ -820,8 +820,6 @@ struct ufs_hba {
        enum ufs_pm_level rpm_lvl;
        /* Desired UFS power management level during system PM */
        enum ufs_pm_level spm_lvl;
-       struct device_attribute rpm_lvl_attr;
-       struct device_attribute spm_lvl_attr;
        int pm_op_in_progress;
 
        /* Auto-Hibernate Idle Timer register value */
--

2.17.1

Reviewed-by on v1 1/1
#3 lore raw
In reply to Keoseong Park
Quoted 14 lines · Keoseong Park

Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba. Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing sysfs entries.") removed all code using that field.

---
  drivers/scsi/ufs/ufshcd.h | 2 --
  1 file changed, 2 deletions(-)
drivers/scsi/ufs/ufshcd.h +0 -0
index 88c20f3608c2..94f545be183a 100644

drivers/scsi/ufs/ufshcd.h struct ufs_hba { · line 825

Quoted 8 lines
drivers/scsi/ufs/ufshcd.h +0 -2
@@ -820,8 +820,6 @@ struct ufs_hba {
  	enum ufs_pm_level rpm_lvl;
  	/* Desired UFS power management level during system PM */
  	enum ufs_pm_level spm_lvl;
-	struct device_attribute rpm_lvl_attr;
-	struct device_attribute spm_lvl_attr;
  	int pm_op_in_progress;
 
  	/* Auto-Hibernate Idle Timer register value */
#4 lore raw
In reply to Keoseong Park

Keoseong,

Quoted 3 lines

Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba. Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing sysfs entries.") removed all code using that field.

Applied to 5.18/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#5 lore raw
In reply to Keoseong Park
Quoted 5 lines · Keoseong Park

Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba. Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing sysfs entries.") removed all code using that field.

Applied to 5.18/scsi-fixes, thanks!

[1/1] scsi: ufs: core: Remove unused field in struct ufs_hba

      https://git.kernel.org/mkp/scsi/c/8ee15ea779c3
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering