Skip to contentSkip to conversation

Obvious compile fix for net/ipv4/ipconfig.c

PATCH In review Andre Noll 2 participants 2 messages Sep 9, 2004

Subsystems (2)
lore
Share & tools
lore

Andre Noll

author
#0 lore raw

PATCH 1/1 Obvious compile fix for net/ipv4/ipconfig.c

The undeclared variable in ic_bootp_recv was introduced by Peter's previous IPCONFIG patch (Logical change 1.21935).

Index: linux-2.5/net/ipv4/ipconfig.c
===================================================================
RCS file: /var/cvs/repository/linux-2.5/net/ipv4/ipconfig.c,v retrieving revision 1.41

net/ipv4/ipconfig.c +1 -1
diff -u -r1.41 ipconfig.c
@@ -825,7 +825,7 @@
 	struct bootp_pkt *b;
 	struct iphdr *h;
 	struct ic_device *d;
-	int len, ext_len;
+	int len, ext_len, i;
 
 	/* Perform verifications before taking the lock.  */
 	if (skb->pkt_type == PACKET_OTHERHOST)
Signature · 1 line
Andre Noll, http://www.mathematik.tu-darmstadt.de/~noll
#1 lore raw
Quoted 2 lines · Andre Noll

The undeclared variable in ic_bootp_recv was introduced by Peter's previous IPCONFIG patch (Logical change 1.21935).

I fixed this by changing the for loop to a memcmp(), I think that this conveys the intention of the code more clearly. David already accepted that patch and it should be making it's way upstream as we speak.

peter