Fix serial hangs when CONFIG_SERIAL_MULTI is defined
PATCH 1/1 Fix serial hangs when CONFIG_SERIAL_MULTI is defined
Hi
The following patch fixes the hangs in the serial port when outputting very early.
Testing for global vars early in the boot sequence has unintended consequences so just we check by the GD RELOC flag which is safe to do anytime.
Regards
Pantelis
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: serial-fix.changelog
Url: http://lists.denx.de/pipermail/u-boot/attachments/20040914/4b7a4900/attachment.txt
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: serial-fix.diffstat
Url: http://lists.denx.de/pipermail/u-boot/attachments/20040914/4b7a4900/attachment-0001.txt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: serial-fix.patch
Type: text/x-patch
Size: 2171 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040914/4b7a4900/attachment.bin
PATCH 1/1 Fix serial hangs when CONFIG_SERIAL_MULTI is defined
common/serial.c line 109
Quoted 11 lines · Pantelis Antoniou
common/serial.c +2
-0@@ -102,6 +102,8 @@ {struct serial_device *s; +return 0 ; +for (s = serial_devices; s; s = s->next) {if (strcmp (s->name, name) ==0 )
Hi,
is it intentional that you disable the body of that function? If yes, why not remove it entirely?
Cheers
Anders
PATCH 1/1 Fix serial hangs when CONFIG_SERIAL_MULTI is defined
Quoted 17 lines · Anders Larsen
common/serial.c line 109
Quoted 11 lines · Pantelis Antoniou
common/serial.c +2
-0@@ -102,6 +102,8 @@ {struct serial_device *s; +return 0 ; +for (s = serial_devices; s; s = s->next) {if (strcmp (s->name, name) ==0 )Hi,
Quoted 8 lines
is it intentional that you disable the body of that function? If yes, why not remove it entirely?
Cheers
Anders
OBVIOUSLY IT IS WRONG.
Damn, good catch.
Remove the return 0 please.
Regards
Pantelis
PATCH 1/1 Fix serial hangs when CONFIG_SERIAL_MULTI is defined
Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 3 lines
is it intentional that you disable the body of that function? If yes, why not remove it entirely?
...
Quoted 5 lines
OBVIOUSLY IT IS WRONG.
Damn, good catch.
Remove the return 0 please.
Please submit a fixed patch.
Best regards,
Wolfgang Denk
Signature · 5 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de ...computer hardware progress is so fast. No other technology since civilization began has seen six orders of magnitude in performance- price gain in 30 years. - Fred Brooks, Jr.
PATCH 1/1 Fix serial hangs when CONFIG_SERIAL_MULTI is defined
Quoted 11 lines · Wolfgang Denk
Quoted 2 lines · In message <[email protected]> you wrote:
Quoted 2 lines
is it intentional that you disable the body of that function? If yes, why not remove it entirely?
...
Quoted 4 lines
OBVIOUSLY IT IS WRONG.
Damn, good catch.
Quoted 9 lines
Quoted 1 line
Remove the return 0 please.
Please submit a fixed patch.
Best regards,
Wolfgang Denk
Rediffed patch included.
Regards
Pantelis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: serial-fix.patch
Type: text/x-patch
Size: 2023 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040914/410627e5/attachment.bin
PATCH 1/1 Fix serial hangs when CONFIG_SERIAL_MULTI is defined
In reply to Pantelis AntoniouQuoted 3 lines · In message <[email protected]> you wrote:
* Patch by Pantelis Antoniou, 14 Sep 2004:
Fix early serial hang whenCONFIG_SERIAL_MULTIis defined.
Added (slightly modified to keep the code readable).
Best regards,
Wolfgang Denk
Signature · 5 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de If the car industry behaved like the computer industry over the last 30 years, a Rolls-Royce would cost $5, get 300 miles per gallon, and blow up once a year killing all passengers inside.