Skip to contentSkip to conversation

test: eal: update base-virtaddr parameter test

PATCH Applied Aaron Conole 3 participants 3 messages Jul 20, 2023 – Jul 22, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test: eal: update base-virtaddr parameter test

When 97435d7906 ("net/bnxt: update Truflow core") was applied, it introduced a number of static variables. These ended up filling the lower address space enough that on some platforms, the min addr for heap address to start was not within the range specified by base-virtaddr. This is dependent on both build and link time options.

The simplest resolution is to just update the base virtaddr parameter to move the rte config location.

---
 app/test/test_eal_flags.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
app/test/test_eal_flags.c +1 -1
index d2b91e2075..148e9098e8 100644
@@ -1017,7 +1017,7 @@ test_misc_flags(void)
 
 	/* try running with base-virtaddr param */
 	const char *argv13[] = {prgname, "--file-prefix=virtaddr",
-			"--base-virtaddr=0x12345678"};
+			"--base-virtaddr=0x23456789"};
 
 	/* try running with --vfio-intr INTx flag */
 	const char *argv14[] = {prgname, "--file-prefix=intr",
Signature · 1 line
2.40.1
#1 lore raw
Quoted 7 lines · Aaron Conole

When 97435d7906 ("net/bnxt: update Truflow core") was applied, it introduced a number of static variables. These ended up filling the lower address space enough that on some platforms, the min addr for heap address to start was not within the range specified by base-virtaddr. This is dependent on both build and link time options.

Quoted 6 lines

The simplest resolution is to just update the base virtaddr parameter to move the rte config location.

ACK.
I tested again and the test passed with this change. Thanks.

Quoted 20 lines
---
 app/test/test_eal_flags.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
app/test/test_eal_flags.c +1 -2
index d2b91e2075..148e9098e8 100644
@@ -1017,7 +1017,7 @@ test_misc_flags(void)
 
        /* try running with base-virtaddr param */
        const char *argv13[] = {prgname, "--file-prefix=virtaddr",
-                       "--base-virtaddr=0x12345678"};
+                       "--base-virtaddr=0x23456789"};
 
        /* try running with --vfio-intr INTx flag */
        const char *argv14[] = {prgname, "--file-prefix=intr",
--

2.40.1

#2 lore raw

20/07/2023 16:07, Ajit Khaparde:

Quoted 8 lines · Aaron Conole
Quoted 7 lines

When 97435d7906 ("net/bnxt: update Truflow core") was applied, it introduced a number of static variables. These ended up filling the lower address space enough that on some platforms, the min addr for heap address to start was not within the range specified by base-virtaddr. This is dependent on both build and link time options.

Quoted 8 lines
Quoted 6 lines

The simplest resolution is to just update the base virtaddr parameter to move the rte config location.

ACK.
I tested again and the test passed with this change. Thanks.

Applied, thanks.