v4l: xilinx: fix typo in formats table
Subsystems (3)
PATCH 1/1 v4l: xilinx: fix typo in formats table
In formats table the entry for CFA pattern "rggb" has GRBG fourcc. This patch fixes it.
--- drivers/media/platform/xilinx/xilinx-vip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/xilinx/xilinx-vip.c +1 -1
@@ -36,7 +36,7 @@ static const struct xvip_video_format xvip_video_formats[] = { {XVIP_VF_MONO_SENSOR ,8 ,"mono" ,MEDIA_BUS_FMT_Y8_1X8 , 1, V4L2_PIX_FMT_GREY, "Greyscale 8-bit" }, { XVIP_VF_MONO_SENSOR, 8, "rggb", MEDIA_BUS_FMT_SRGGB8_1X8, - 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit RGGB" }, + 1, V4L2_PIX_FMT_SRGGB8, "Bayer 8-bit RGGB" }, { XVIP_VF_MONO_SENSOR, 8, "grbg", MEDIA_BUS_FMT_SGRBG8_1X8, 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit GRBG" }, { XVIP_VF_MONO_SENSOR, 8, "gbrg", MEDIA_BUS_FMT_SGBRG8_1X8,
Signature · 1 line
2.17.1
Hi Andrea,
Thank you for the patch.
Quoted 6 lines · On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
In formats table the entry for CFA pattern "rggb" has GRBG fourcc. This patch fixes it.
Signed-off-by Mirco Di Salvo <[email protected]>Signed-off-by Andrea Merello <[email protected]>
Michal, should I take the patch in my tree ?
Quoted 18 lines
--- drivers/media/platform/xilinx/xilinx-vip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/media/platform/xilinx/xilinx-vip.cindex 311259129504..e9567cdfb89b 100644drivers/media/platform/xilinx/xilinx-vip.c +1
-1@@ -36,7 +36,7 @@ static const struct xvip_video_format xvip_video_formats[] = { { XVIP_VF_MONO_SENSOR, 8, "mono", MEDIA_BUS_FMT_Y8_1X8, 1, V4L2_PIX_FMT_GREY, "Greyscale 8-bit" }, { XVIP_VF_MONO_SENSOR, 8, "rggb", MEDIA_BUS_FMT_SRGGB8_1X8, - 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit RGGB" }, + 1, V4L2_PIX_FMT_SRGGB8, "Bayer 8-bit RGGB" }, { XVIP_VF_MONO_SENSOR, 8, "grbg", MEDIA_BUS_FMT_SGRBG8_1X8, 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit GRBG" }, { XVIP_VF_MONO_SENSOR, 8, "gbrg", MEDIA_BUS_FMT_SGBRG8_1X8,
Signature · 3 lines
Regards, Laurent Pinchart
Hi Laurent,
Quoted 8 lines · Laurent Pinchart
Hi Andrea,
Thank you for the patch.
Quoted 3 lines · On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
In formats table the entry for CFA pattern "rggb" has GRBG fourcc. This patch fixes it.
Quoted 7 lines
Quoted 3 lines
Signed-off-by Mirco Di Salvo <[email protected]>Signed-off-by Andrea Merello <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>Michal, should I take the patch in my tree ?
definitely. I am not collecting patches for media tree.
Thanks,
Michal
Laurent Pinchart
maintainerHi Michal,
Quoted 9 lines · On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote:
Quoted 8 lines · Laurent Pinchart
Quoted 6 lines · On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
In formats table the entry for CFA pattern "rggb" has GRBG fourcc. This patch fixes it.
Signed-off-by Mirco Di Salvo <[email protected]>Signed-off-by Andrea Merello <[email protected]>
Quoted 5 lines
Quoted 3 lines
Reviewed-by Laurent Pinchart <[email protected]>Michal, should I take the patch in my tree ?
definitely. I am not collecting patches for media tree.
Taken in my tree.
By the way, have we reached any conclusion regarding https://lkml.org/lkml/
2017/12/18/112 ?
Signature · 3 lines
Regards, Laurent Pinchart
Hi Laurent,
Quoted 14 lines · Laurent Pinchart
Hi Michal,
Quoted 11 lines · On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote:
Quoted 10 lines · Laurent Pinchart
Quoted 6 lines · On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
In formats table the entry for CFA pattern "rggb" has GRBG fourcc. This patch fixes it.
Signed-off-by Mirco Di Salvo <[email protected]>Signed-off-by Andrea Merello <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Michal, should I take the patch in my tree ?
definitely. I am not collecting patches for media tree.
Taken in my tree.
By the way, have we reached any conclusion regarding https://lkml.org/lkml/
2017/12/18/112 ?
Xilinx has started to use SPDX without any issue. It means conversion should be fine to do.
Thanks,
Michal
Laurent Pinchart
maintainerHi Michal,
Quoted 17 lines · On Monday, 1 October 2018 16:28:32 EEST Michal Simek wrote:
Quoted 16 lines · Laurent Pinchart
Quoted 14 lines · On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote:
Quoted 11 lines · Laurent Pinchart
Quoted 6 lines · On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
In formats table the entry for CFA pattern "rggb" has GRBG fourcc. This patch fixes it.
Signed-off-by Mirco Di Salvo <[email protected]>Signed-off-by Andrea Merello <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>Michal, should I take the patch in my tree ?
definitely. I am not collecting patches for media tree.
Quoted 8 lines
Quoted 5 lines
Taken in my tree.
By the way, have we reached any conclusion regarding
https://lkml.org/lkml/
2017/12/18/112 ?Xilinx has started to use SPDX without any issue. It means conversion should be fine to do.
That's good to know, I'll resubmit the patch then, and CC you to get an ack.
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 22 lines · Laurent Pinchart
Hi Michal,
Quoted 19 lines · On Monday, 1 October 2018 16:28:32 EEST Michal Simek wrote:
Quoted 18 lines · Laurent Pinchart
Quoted 9 lines · On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote:
Quoted 8 lines · Laurent Pinchart
Quoted 6 lines · On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
In formats table the entry for CFA pattern "rggb" has GRBG fourcc. This patch fixes it.
Signed-off-by Mirco Di Salvo <[email protected]>Signed-off-by Andrea Merello <[email protected]>Quoted 5 lines
Quoted 3 lines
Reviewed-by Laurent Pinchart <[email protected]>Michal, should I take the patch in my tree ?
definitely. I am not collecting patches for media tree.
Taken in my tree.
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
By the way, have we reached any conclusion regarding
https://lkml.org/lkml/
2017/12/18/112 ?Xilinx has started to use SPDX without any issue. It means conversion should be fine to do.
That's good to know, I'll resubmit the patch then, and CC you to get an ack.
Sure go ahead.
M