Skip to contentSkip to conversation

md: add atomic mode switching when removing disk

PATCH New tada keisuke 1 participant 1 message Apr 18, 2024 MD RAID

lore
Share & tools
lore
#0 lore raw

PATCH v2 9/11 md: add atomic mode switching when removing disk

This patch depends on patch 08.

To minimize the number of execution of atomic mode switching, not only adding atomic mode switching, but also remove judgment is divided into two stages. Latency is minimized because only rdev to be removed is switched to atomic mode, not all rdevs.

---
 drivers/md/md.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/md/md.c +10 -2
index 7e6966e65d0d..5f785353353d 100644
@@ -9291,8 +9291,11 @@ static bool rdev_removeable(struct md_rdev *rdev)
 		return false;
 
 	/* Fautly rdev is not used, it's safe to remove it. */
-	if (test_bit(Faulty, &rdev->flags))
-		return true;
+	if (nr_pending_is_percpu_mode(rdev) && test_bit(Faulty, &rdev->flags)) {
+		percpu_ref_switch_to_atomic_sync(&rdev->nr_pending);
+		if (nr_pending_is_zero(rdev))
+			return true;
+	}
 
 	/* Journal disk can only be removed if it's faulty. */
 	if (test_bit(Journal, &rdev->flags))
@@ -9346,6 +9349,11 @@ static bool md_spares_need_change(struct mddev *mddev)
 {
 	struct md_rdev *rdev;
 
+	rdev_for_each_rcu(rdev, mddev) {
+		if (test_bit(Faulty, &rdev->flags))
+			percpu_ref_switch_to_atomic_sync(&rdev->nr_pending);
+	}
+
 	rcu_read_lock();
 	rdev_for_each_rcu(rdev, mddev) {
 		if (rdev_removeable(rdev) || rdev_addable(rdev)) {
Signature · 1 line
2.34.1