: Fix free_netdev after failed alloc_netdev in ipip_init
Subsystems (2)
PATCH 4/7 : Fix free_netdev after failed alloc_netdev in ipip_init
Same problem as in ip_gre:
Passing a NULL-ptr to free_netdev is wrong.
# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2004/10/03 20:41:00+02:00 [email protected]
# [IPV4]: Fix free_netdev after failed alloc_netdev in ipip_init
#
# Signed-off-by: Patrick McHardy <[email protected]>
#
# net/ipv4/ipip.c # 2004/10/03 20:40:18+02:00 [email protected] +5 -4 # [IPV4]: Fix free_netdev after failed alloc_netdev in ipip_init # # Signed-off-by: Patrick McHardy <[email protected]> # diff -Nru a/net/ipv4/ipip.c b/net/ipv4/ipip.c --- a/net/ipv4/ipip.c 2004-10-03 22:20:28 +02:00 +++ b/net/ipv4/ipip.c 2004-10-03 22:20:28 +02:00 @@ -876,18 +876,19 @@ ipip_tunnel_setup); if (!ipip_fb_tunnel_dev) { err = -ENOMEM; - goto fail; + goto err1; }
ipip_fb_tunnel_dev->init = ipip_fb_tunnel_init;
if ((err = register_netdev(ipip_fb_tunnel_dev)))
- goto fail;
+ goto err2;
out:
return err;
- fail:
- xfrm4_tunnel_deregister(&ipip_handler);
+ err2:
free_netdev(ipip_fb_tunnel_dev);
+ err1:
+ xfrm4_tunnel_deregister(&ipip_handler);
goto out;
}