Skip to contentSkip to conversation

: Fix ipip_fb_tunnel_dev leak in ipip_fini

PATCH In review Patrick McHardy 1 participant 1 message Oct 3, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 5/7 : Fix ipip_fb_tunnel_dev leak in ipip_fini

ipip_fb_tunnel_dev doesn't have a destructor set
and is not freed manually. Set the destructor in
ipip_tunnel_setup to fix the leak.

# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2004/10/03 20:42:17+02:00 [email protected]
# [IPV4]: Fix ipip_fb_tunnel_dev leak in ipip_fini
#
# Signed-off-by: Patrick McHardy <[email protected]>
#

# net/ipv4/ipip.c
#   2004/10/03 20:41:38+02:00 [email protected] +1 -1
#   [IPV4]: Fix ipip_fb_tunnel_dev leak in ipip_fini
#   
#   Signed-off-by: Patrick McHardy <[email protected]>
# 
diff -Nru a/net/ipv4/ipip.c b/net/ipv4/ipip.c
--- a/net/ipv4/ipip.c	2004-10-03 22:20:49 +02:00
+++ b/net/ipv4/ipip.c	2004-10-03 22:20:49 +02:00
@@ -246,7 +246,6 @@
 	nt = dev->priv;
 	SET_MODULE_OWNER(dev);
 	dev->init = ipip_tunnel_init;
-	dev->destructor = free_netdev;
 	nt->parms = *parms;

if (register_netdevice(dev) < 0) {
@@ -784,6 +783,7 @@
dev->get_stats = ipip_tunnel_get_stats;
dev->do_ioctl = ipip_tunnel_ioctl;
dev->change_mtu = ipip_tunnel_change_mtu;
+ dev->destructor = free_netdev;

dev->type = ARPHRD_TUNNEL;
dev->hard_header_len = LL_MAX_HEADER + sizeof(struct iphdr);