Skip to contentSkip to conversation

: Missing rtnl_unlock in register_vlan_device error path

PATCH In review Patrick McHardy 1 participant 1 message Oct 3, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 7/7 : Missing rtnl_unlock in register_vlan_device error path

rtnl_unlock is not called in the out_free_unregister error path.

# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2004/10/03 20:44:53+02:00 [email protected]
# [VLAN]: Missing rtnl_unlock in register_vlan_device error path
#
# Signed-off-by: Patrick McHardy <[email protected]>
#

# net/8021q/vlan.c
#   2004/10/03 20:44:27+02:00 [email protected] +1 -1
#   [VLAN]: Missing rtnl_unlock in register_vlan_device error path
#   
#   Signed-off-by: Patrick McHardy <[email protected]>
# 
diff -Nru a/net/8021q/vlan.c b/net/8021q/vlan.c
--- a/net/8021q/vlan.c	2004-10-03 22:21:30 +02:00
+++ b/net/8021q/vlan.c	2004-10-03 22:21:30 +02:00
@@ -537,7 +537,7 @@

out_free_unregister:
unregister_netdev(new_dev);
- goto out_put_dev;
+ goto out_unlock;

out_free_newdev:
free_netdev(new_dev);