PATCH] firewire: add padding to some struct
Hi,
Quoted 8 lines
From: Stefan Richter <[email protected]> Reply-To:
To: JiSheng Zhang <[email protected]>
Subject: Re: PATCH] firewire: add padding to some struct Date:Fri, 18 Jul 2008 13:38:25 +0200Quoted 1 line · JiSheng Zhang
If p is a pointer to struct
fw_cdev_event_response),p->datawill point to
the
Quoted 2 lines
Quoted 2 lines
padding data rather than the right place, it will cause problem under some platforms. For example, in the function
handle_device_eventof
libraw1394(ported
Quoted 6 lines
Quoted 6 lines
to juju stack):
.....
caseFW_CDEV_EVENT_RESPONSE:rc = u64_to_ptr(u->response.closure); if (rc->data != NULL) memcpy(rc->data, u->response.data, rc->length);//here it will lost the last
four
Quoted 7 lines
Quoted 6 lines
bytes
errcode = juju_to_raw1394_errcode(u->response.rcode);.....
Although this problem can be solved by add the offset to the pointer, but the member:__u32 data[0] lost its original meaning.
Quoted 7 lines
I don't understand what the problem is. As long as both kernel and library use "response.data" or "&response +
offsetof(typeof(response), data)", they will write and read at the correct location.There would be a problem if one of the two used "&response + sizeof(response)" instead. Does this happen anywhere? If so, then these places need to be fixed, not the struct definition.
yes, complete_transaction in fw-cdev.c, it queues the response and data.
how about adding __attribute__((packed)) to the two struct definition? It will not break abi compatibility.
Thanks in advance,
JiSheng
include/linux/firewire-cdev.h +2 -2
@@ -93,7 +93,7 @@ struct fw_cdev_event_response {__u32 rcode;__u32 length;__u32 data[0 ]; -}; +} __attribute__((packed));/** * struct fw_cdev_event_request - Sent on incoming request to an address region
@@ -144,7 +144,7 @@ struct fw_cdev_event_iso_interrupt {__u32 cycle;__u32 header_length;__u32 header[0 ]; -}; +} __attribute__((packed));/** * union fw_cdev_event - Convenience union of fw_cdev_event_ types