Skip to contentSkip to conversation

pcnet32: use unsigned 1-bit fields

PATCH Applied Randy.Dunlap 2 participants 2 messages Oct 10, 2004 – Oct 15, 2004

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Randy.Dunlap

author
#0 lore raw

PATCH 1/1 pcnet32: use unsigned 1-bit fields

1-bit fields should be unsigned. Keeps sparse happy, keeps gcc straight.

~Randy

Fix sparse warning and tell gcc that 1-bit fields are unsigned. drivers/net/pcnet32.c:362:21: warning: dubious one-bit signed bitfield

Signed-off-by Randy Dunlap <[email protected]>

diffstat:=

 drivers/net/pcnet32.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/pcnet32.c renamed from drivers/net/pcnet32.c~pcnet_bits +3 -3
diff -Naurp ./drivers/net/pcnet32.c~pcnet_bits ./drivers/net/pcnet32.c
@@ -359,9 +359,9 @@ struct pcnet32_private {
     struct net_device_stats stats;
     char		tx_full;
     int			options;
-    int	shared_irq:1,			/* shared irq possible */
-	dxsuflo:1,			/* disable transmit stop on uflo */
-	mii:1;				/* mii port available */
+    unsigned int	shared_irq:1,	/* shared irq possible */
+			dxsuflo:1,	/* disable transmit stop on uflo */
+			mii:1;		/* mii port available */
     struct net_device	*next;
     struct mii_if_info	mii_if;
     struct timer_list	watchdog_timer;