Skip to contentSkip to conversation

skfp: remove assignment expression in conditional (sparse)

PATCH In review Randy.Dunlap 2 participants 4 messages Oct 10, 2004 – Oct 15, 2004

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Randy.Dunlap

author
#0 lore raw

PATCH 1/1 skfp: remove assignment expression in conditional (sparse)

Fix sparse warning:
drivers/net/skfp/hwmtm.c:1904:20: warning: assignment expression in conditional

Signature · 1 line
~Randy

Fix sparse warning:
drivers/net/skfp/hwmtm.c:1904:20: warning: assignment expression in conditional

Signed-off-by Randy Dunlap <[email protected]>

diffstat:=

 drivers/net/skfp/hwmtm.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/net/skfp/hwmtm.c renamed from drivers/net/skfp/hwmtm.c~skfp_expr +1 -1
diff -Naurp ./drivers/net/skfp/hwmtm.c~skfp_expr ./drivers/net/skfp/hwmtm.c
@@ -1901,7 +1901,7 @@ void smt_send_mbuf(struct s_smc *smc, SM
 	}
 
 	if (!smc->hw.mac_ring_is_up || frag_count > queue->tx_free) {
-		if (frame_status &= ~LAN_TX) {
+		if ((frame_status &= ~LAN_TX) != 0) {
 			DB_TX("Ring is down: terminate LAN_TX",0,0,2) ;
 		}
 		else {
#1 lore raw
Quoted 21 lines · Randy.Dunlap

Fix sparse warning:
drivers/net/skfp/hwmtm.c:1904:20: warning: assignment expression in conditional

------------------------------------------------------------------------

Fix sparse warning:
drivers/net/skfp/hwmtm.c:1904:20: warning: assignment expression in conditional

Signed-off-by Randy Dunlap <[email protected]>

diffstat:=

 drivers/net/skfp/hwmtm.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -Naurp ./drivers/net/skfp/hwmtm.c~skfp_expr ./drivers/net/skfp/hwmtm.c

drivers/net/skfp/hwmtm.c void smt_send_mbuf(struct s_smc *smc, SM · line 1904

Quoted 5 lines
drivers/net/skfp/hwmtm.c renamed from drivers/net/skfp/hwmtm.c~skfp_expr +1 -1
@@ -1901,7 +1901,7 @@ void smt_send_mbuf(struct s_smc *smc, SM
 	}
 
 	if (!smc->hw.mac_ring_is_up || frag_count > queue->tx_free) {
-		if (frame_status &= ~LAN_TX) {
+		if ((frame_status &= ~LAN_TX) != 0) {

I would prefer to fix a 'assignment expression in conditional' warning by splitting the assignment and the test.

Jeff

author
#2 lore raw

PATCH 1/1 skfp: remove assignment expression in conditional (sparse)(v2)

Quoted 3 lines

I would prefer to fix a 'assignment expression in conditional' warning by splitting the assignment and the test.

Jeff

OK, here you are.

Signature · 1 line
~Randy

Fix sparse warning:
drivers/net/skfp/hwmtm.c:1904:20: warning: assignment expression in conditional

Signed-off-by Randy Dunlap <[email protected]>

diffstat:=

 drivers/net/skfp/hwmtm.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)
drivers/net/skfp/hwmtm.c renamed from drivers/net/skfp/hwmtm.c~skfp_expr +2 -1
diff -Naurp ./drivers/net/skfp/hwmtm.c~skfp_expr ./drivers/net/skfp/hwmtm.c
@@ -1901,7 +1901,8 @@ void smt_send_mbuf(struct s_smc *smc, SM
 	}
 
 	if (!smc->hw.mac_ring_is_up || frag_count > queue->tx_free) {
-		if (frame_status &= ~LAN_TX) {
+		frame_status &= ~LAN_TX;
+		if (frame_status) {
 			DB_TX("Ring is down: terminate LAN_TX",0,0,2) ;
 		}
 		else {
Applied
#3 lore raw

Re: [PATCH] skfp: remove assignment expression in conditional (sparse)(v2)

applied