Skip to contentSkip to conversation

Tasklet usage?

DISCUSSION Pierre Ossman 3 participants 8 messages Oct 15, 2004 – Oct 16, 2004

lore
Share & tools
lore
#0 lore raw

My driver needs to spend a lot of time inside the interrupt handler (draining a FIFO). I suspect this might cause problems blocking other interrupt handlers so I was thinking about moving this into a tasklet. Not being to familiar with tasklets, a few questions pop up.

* Will a tasklet scheduled from the interrupt handler be executed as soon as interrupt handling is done?
* Can tasklets be preempted?
* If a tasklet gets scheduled while running, will it be executed once more? (Needed if I get another FIFO interrupt while the tasklet is just exiting).

The FIFO is a bit small so time is of the essence. That's why this routine is in the interrupt handler to begin with.

Rgds
Pierre Ossman

#1 lore raw
Quoted 4 lines · Pierre Ossman

My driver needs to spend a lot of time inside the interrupt handler (draining a FIFO). I suspect this might cause problems blocking other interrupt handlers so I was thinking about moving this into a tasklet. Not being to familiar with tasklets, a few questions pop up.

* Will a tasklet scheduled from the interrupt handler be executed as soon as interrupt handling is done?

I don't _think_ they are guaranteed to be executed immediately after the
interrupt handler top half is complete, but they will execute before
the next return to user space (read: they will complete before user processes run again).

Quoted 1 line

* Can tasklets be preempted?

A tasklet can get preempted by a hard interrupt, but tasklets run in interrupt context, so don't do anything in a tasklet that can call schedule.

Quoted 2 lines

* If a tasklet gets scheduled while running, will it be executed once more? (Needed if I get another FIFO interrupt while the tasklet is just exiting).

IIRC, a tasklet will execute once for every time tasklet_schedule is called.

HTH
Neil

Signature · 8 lines
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *[email protected]
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/
#2 lore raw
Quoted 5 lines · Neil Horman
Quoted 1 line · Pierre Ossman

* Can tasklets be preempted?

A tasklet can get preempted by a hard interrupt, but tasklets run in interrupt context, so don't do anything in a tasklet that can call schedule.

Being preempted by hard interrupts is sort of the point of moving the stuff to a tasklet. Just as long as other tasklets and user space cannot preempt it.

Are there any concerns when it comes to locking and tasklets? I've tried finding kernel-locking-HOWTO referenced in kernel-docs.txt but the link is dead and I can't find a mirror.

Rgds
Pierre

#3 lore raw
Quoted 8 lines · Pierre Ossman
Quoted 6 lines · Neil Horman
Quoted 1 line · Pierre Ossman

* Can tasklets be preempted?

Quoted 7 lines
Quoted 1 line

A tasklet can get preempted by a hard interrupt, but tasklets run in interrupt context, so don't do anything in a tasklet that can call schedule.

Being preempted by hard interrupts is sort of the point of moving the stuff to a tasklet. Just as long as other tasklets and user space cannot preempt it.

Are there any concerns when it comes to locking and tasklets? I've tried finding kernel-locking-HOWTO referenced in kernel-docs.txt but the link is dead and I can't find a mirror.

Locking in tasklets needs to be done the same way locking in interrupt handlers is done. The only caveat that I can think of is that in the event that you are accessing data shared with code that runs outisde of the tasklet, you probably need to use spin_lock_bh to disable softirqs in the latter code. In your environment, it would typically replace the use of spin_lock_irq[save|restore].

HTH
Neil

Quoted 3 lines

Rgds
Pierre

Signature · 8 lines
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *[email protected]
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/
#4 lore raw
In reply to Pierre Ossman

As I was digging through the functions there was one thing that struck me. The parameter for the tasklet is of type unsigned long, not void*. Since the parameter in most cases is a pointer this might cause problems on 64-bit systems. Or does the kernel do some magic to map kernel memory in the first 4 GB?

Rgds
Pierre

#5 lore raw

Pierre> As I was digging through the functions there was one thing Pierre> that struck me. The parameter for the tasklet is of type Pierre> unsigned long, not void*. Since the parameter in most Pierre> cases is a pointer this might cause problems on 64-bit Pierre> systems. Or does the kernel do some magic to map kernel Pierre> memory in the first 4 GB?

unsigned long will be 64 bits on a 64-bit system. There are many places in the Linux kernel where we assume that void * and long are the same size.

- Roland

#6 lore raw
Quoted 7 lines · Roland Dreier

unsigned long will be 64 bits on a 64-bit system. There are many places in the Linux kernel where we assume that void * and long are the same size.

- Roland

Just out of curiosity, how do you declare a 32-bit int then? I thought longlong would be the 64-bit int under gcc and long stay as it is.

Rgds
Pierre

#7 lore raw

Pierre> Just out of curiosity, how do you declare a 32-bit int Pierre> then? I thought longlong would be the 64-bit int under gcc Pierre> and long stay as it is.

int is still 32 bits on all Linux platforms (as far as I know). To make it explicit you can use s32.

- Roland