Skip to contentSkip to conversation

tg3: reading eeprom via ethtool: not __init

PATCH In review Randy.Dunlap 2 participants 2 messages Oct 20, 2004 – Oct 21, 2004

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Randy.Dunlap

author
#0 lore raw

PATCH 1/1 tg3: reading eeprom via ethtool: not __init

Signature · 2 lines
-- 
~Randy

tg3_get_eeprom calls: tg3_nvram_read_using_eeprom __init:
but the latter cannot be __init if it can be called (via ethtool) after driver-init:
Error: ./drivers/net/tg3.o .text refers to 0000000000007220 R_X86_64_PC32 .init.text+0xfffffffffffffffc
Error: ./drivers/net/tg3.o .text refers to 000000000000725d R_X86_64_PC32 .init.text+0xfffffffffffffffc
Error: ./drivers/net/tg3.o .text refers to 00000000000072a7 R_X86_64_PC32 .init.text+0xfffffffffffffffc
Error: ./drivers/net/tg3.o .text refers to 00000000000072e8 R_X86_64_PC32 .init.text+0xfffffffffffffffc

Signed-off-by Randy Dunlap <[email protected]>

diffstat:=

 drivers/net/tg3.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/tg3.c renamed from drivers/net/tg3.c~tg3_init +4 -4
diff -Naurp ./drivers/net/tg3.c~tg3_init ./drivers/net/tg3.c
@@ -6319,8 +6319,8 @@ static int tg3_get_eeprom_len(struct net
 	return EEPROM_CHIP_SIZE;
 }
 
-static int __devinit tg3_nvram_read_using_eeprom(struct tg3 *tp,
-						 u32 offset, u32 *val);
+static int tg3_nvram_read_using_eeprom(struct tg3 *tp,
+					u32 offset, u32 *val);
 static int tg3_get_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom, u8 *data)
 {
 	struct tg3 *tp = dev->priv;

@@ -6851,8 +6851,8 @@ static void __devinit tg3_nvram_init(str
 	}
 }
 
-static int __devinit tg3_nvram_read_using_eeprom(struct tg3 *tp,
-						 u32 offset, u32 *val)
+static int tg3_nvram_read_using_eeprom(struct tg3 *tp,
+					u32 offset, u32 *val)
 {
 	u32 tmp;
 	int i;