eth1394: dev file [Report about error: unknown bus]

PATCH In review Randy.Dunlap 3 participants 4 messages Oct 20, 2004 – Oct 21, 2004

lore

Share & tools

lore

Randy.Dunlap

author

2004-10-20 23:26 UTC #0 lore raw

PATCH 1/1 eth1394: dev file [Report about error: unknown bus]

Quoted 19 lines · Kay Sievers

Quoted 6 lines · Paul Blazejowski
Quoted 3 lines · Kay Sievers
Quoted 2 lines
'/class/net/eth1' properly (no device symlink) or the sysfs-support of your device's driver needs to be fixed
Quoted 7 lines
Quoted 2 lines
What driver creates the eth1 device? It needs to crete the "device" symlink and the maintainer should know.
eth1 Link encap:UNSPEC HWaddr
8A-1C-C7-FF-FF-00-20-ED-00-00-00-00-00-00-00-00
is created by the eth1394 driver.
[CC: to the 1394 devel-list]

Quoted 7 lines

The eth1394.c driver needs to create the symlinks in its sysfs representation to get support for modern userspace integration. Most networkd drivers use:
  SET_NETDEV_DEV(dev, &pdev->dev);
to do that.

Paul,
Can you test this patch, please?

Thanks,

Signature · 1 line

~Randy

linux-269-bk4
description

diffstat:=

drivers/ieee1394/eth1394.c renamed from drivers/ieee1394/eth1394.c~eth1394_sysfs +1 -0

diff -Naurp ./drivers/ieee1394/eth1394.c~eth1394_sysfs ./drivers/ieee1394/eth1394.c
@@ -600,6 +600,7 @@ static void ether1394_add_host (struct h
         }
 
 	SET_MODULE_OWNER(dev);
+	SET_NETDEV_DEV(dev, &host->device);
 
 	priv = netdev_priv(dev);

Paul Blazejowski

2004-10-21 04:09 UTC #1 lore raw

Quoted 24 lines · Randy.Dunlap

Quoted 23 lines · Kay Sievers
Quoted 6 lines · Paul Blazejowski
Quoted 3 lines · Kay Sievers
Quoted 2 lines
'/class/net/eth1' properly (no device symlink) or the sysfs-support of your device's driver needs to be fixed
Quoted 7 lines
Quoted 2 lines
What driver creates the eth1 device? It needs to crete the "device" symlink and the maintainer should know.
eth1 Link encap:UNSPEC HWaddr
8A-1C-C7-FF-FF-00-20-ED-00-00-00-00-00-00-00-00
is created by the eth1394 driver.
[CC: to the 1394 devel-list]
The eth1394.c driver needs to create the symlinks in its sysfs representation to get support for modern userspace integration. Most networkd drivers use:

Quoted 8 lines

Quoted 3 lines
  SET_NETDEV_DEV(dev, &pdev->dev);
to do that.
Paul,
Can you test this patch, please?
Thanks,

Randy applied the patch to kernel 2.6.9 and now eth1394 creates symlink under /sys/class/net/eth2

lrwxrwxrwx 1 root root 0 2004-10-20 23:58 device
-> ../../../devices/pci0000:00/0000:00:0d.0/fw-host0/

Thank you,

Paul

Signature · 1 line

FreeBSD -- The Power to Serve!

Randy.Dunlap

author

2004-10-21 04:10 UTC #2 lore raw

In reply to Randy.Dunlap

Quoted 42 lines · Paul Blazejowski

Quoted 27 lines · Randy.Dunlap
Quoted 25 lines · Kay Sievers
Quoted 7 lines · Paul Blazejowski
Quoted 3 lines · Kay Sievers
Quoted 2 lines
'/class/net/eth1' properly (no device symlink) or the sysfs-support of your device's driver needs to be fixed
Quoted 7 lines
Quoted 2 lines
What driver creates the eth1 device? It needs to crete the "device" symlink and the maintainer should know.
eth1 Link encap:UNSPEC HWaddr
8A-1C-C7-FF-FF-00-20-ED-00-00-00-00-00-00-00-00
is created by the eth1394 driver.
[CC: to the 1394 devel-list]
The eth1394.c driver needs to create the symlinks in its sysfs representation to get support for modern userspace integration. Most networkd drivers use:
Quoted 8 lines
Quoted 3 lines
SET_NETDEV_DEV(dev, &pdev->dev);
to do that.
Paul,
Can you test this patch, please?
Thanks,
Randy applied the patch to kernel 2.6.9 and now eth1394 creates symlink under /sys/class/net/eth2

Quoted 6 lines

lrwxrwxrwx 1 root root 0 2004-10-20 23:58 device
-> ../../../devices/pci0000:00/0000:00:0d.0/fw-host0/
Thank you,
Paul

So is this correct? Does it do the right thing?

Signature · 12 lines

~Randy


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Kay Sievers

2004-10-21 07:57 UTC #3 lore raw

In reply to Randy.Dunlap

Quoted 5 lines · Paul Blazejowski

Quoted 3 lines · Randy.Dunlap
Quoted 3 lines
Randy applied the patch to kernel 2.6.9 and now eth1394 creates symlink under /sys/class/net/eth2

Quoted 8 lines

Quoted 8 lines
Quoted 6 lines
lrwxrwxrwx 1 root root 0 2004-10-20 23:58 device
-> ../../../devices/pci0000:00/0000:00:0d.0/fw-host0/
Thank you,
Paul
So is this correct? Does it do the right thing?

Yes, I think so.
Randy, thanks a lot for the fast fix.

Quoted 2 lines

udev still complains about bus specific file
unavailable

I hopefully fixed this one now.
Paul, I will send a new patch in reply to your other mail.

Thanks,
Kay

-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel