Skip to contentSkip to conversation

package/dhcpcd: bump version to 7.2.2

PATCH New Victor Huesca 2 participants 3 messages May 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/dhcpcd: bump version to 7.2.2

---
 package/dhcpcd/dhcpcd.hash | 6 +++---
 package/dhcpcd/dhcpcd.mk   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
package/dhcpcd/dhcpcd.hash +3 -3
index 605e87609e..6769cdac49 100644
@@ -1,4 +1,4 @@
-# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.0.3.tar.xz.distinfo.asc
-sha256	a255d9aecceb1c77a9862f1c0d31a48ba37aab5ef2ca5ad76fc7a907b6ea292e	dhcpcd-7.0.3.tar.xz
+# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.2.2.tar.xz.distinfo
+sha256	3db7ff18cba9274da1d2176fb3c7cbe23926a8e58d5c8e244ad55c62d38ba09e	dhcpcd-7.2.2.tar.xz
 # Locally calculated
-sha256	b120a64b92cfb2453b61df4457a3c0eb163ef9c1c397822826756a31581f3947	LICENSE
+sha256	213fc1a704cecdb322276fa7c95891fd1c23137d9ab572af1fc5e91b48762303	LICENSE
package/dhcpcd/dhcpcd.mk +1 -1
index ae16c340d6..a0f0c2bf42 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-DHCPCD_VERSION = 7.0.3
+DHCPCD_VERSION = 7.2.2
 DHCPCD_SOURCE = dhcpcd-$(DHCPCD_VERSION).tar.xz
 DHCPCD_SITE = http://roy.marples.name/downloads/dhcpcd
 DHCPCD_DEPENDENCIES = host-pkgconf
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 package/dhcpcd: bump version to 7.2.2

Hello Victor,

Quoted 11 lines · On Fri, 17 May 2019 11:22:32 +0200 Victor Huesca <[email protected]>…
---
 package/dhcpcd/dhcpcd.hash | 6 +++---
 package/dhcpcd/dhcpcd.mk   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
package/dhcpcd/dhcpcd.hash +0 -0
index 605e87609e..6769cdac49 100644

package/dhcpcd/dhcpcd.hash line 4

Quoted 7 lines
package/dhcpcd/dhcpcd.hash +3 -3
@@ -1,4 +1,4 @@
-# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.0.3.tar.xz.distinfo.asc
-sha256	a255d9aecceb1c77a9862f1c0d31a48ba37aab5ef2ca5ad76fc7a907b6ea292e	dhcpcd-7.0.3.tar.xz
+# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.2.2.tar.xz.distinfo
+sha256	3db7ff18cba9274da1d2176fb3c7cbe23926a8e58d5c8e244ad55c62d38ba09e	dhcpcd-7.2.2.tar.xz
 # Locally calculated
-sha256	b120a64b92cfb2453b61df4457a3c0eb163ef9c1c397822826756a31581f3947	LICENSE
+sha256	213fc1a704cecdb322276fa7c95891fd1c23137d9ab572af1fc5e91b48762303	LICENSE

When the LICENSE file has changed, we like to have an explanation in the commit log about what changed. This way, we are sure the actual change in the license file has been verified by someone, especially to make sure that the license terms of the package have not changed.

Most of the time, the change is just that the copyright year has been updated, but it's always important to check that. So just do a diff between the old LICENSE and the new LICENSE file to see what the differences are, and summarize that in the commit log.

Otherwise, looks good to me. Did you use ./utils/test-pkg to verify that everything was building fine for this package after the version bump ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/dhcpcd: bump version to 7.2.2

Hello Thomas,

Quoted 9 lines · On Fri, 17 May 2019 11:26 +0200 Thomas Petazzoni…

When the LICENSE file has changed, we like to have an explanation in the commit log about what changed. This way, we are sure the actual change in the license file has been verified by someone, especially to make sure that the license terms of the package have not changed.

Most of the time, the change is just that the copyright year has been updated, but it's always important to check that. So just do a diff between the old LICENSE and the new LICENSE file to see what the differences are, and summarize that in the commit log.

You're right it was just the copyright year that has been updated to 2019. I will submit a new patch according to it.

Quoted 3 lines

Otherwise, looks good to me. Did you use ./utils/test-pkg to verify that everything was building fine for this package after the version bump ?

Yes, all test passed with success.

Victor

Signature · 3 lines
Victor Huesca, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com