raw1394: __copy_from_user check

PATCH New Daniel Drake 1 participant 1 message Nov 14, 2004

lore

Share & tools

lore

Daniel Drake

author

2004-11-14 21:14 UTC #0 lore raw

PATCH 2/3 raw1394: __copy_from_user check

Add a check for the return value of __copy_to_user Depends on the previous whitespace fix patch.

Signed-off-by Daniel Drake <[email protected]>

drivers/ieee1394/raw1394.c renamed from drivers/ieee1394/raw1394.c.orig +4 -1

@@ -447,9 +447,12 @@ static ssize_t raw1394_read(struct file 
 			req->req.error = RAW1394_ERROR_MEMFAULT;
 		}
 	}
-	__copy_to_user(buffer, &req->req, sizeof(req->req));
 
 	free_pending_request(req);
+
+	if (__copy_to_user(buffer, &req->req, sizeof(req->req)))
+		return -EFAULT;
+
 	return sizeof(struct raw1394_request);
 }