Possible alternate 4 level pagetables?
Subsystems (11)
RFC 1/1 Possible alternate 4 level pagetables?
Hi Andi,
Just looking at your 4 level page tables patch, I wondered why the extra level isn't inserted between pgd and pmd, as that would appear to be the least intrusive (conceptually, in the generic code). Also it maybe matches more closely the way that the 2->3 level conversion was done.
I've been toying with it a little bit. It is mainly just starting with your code and doing straight conversions, although I also attempted to implement a better compatibility layer that does the pagetable "folding" for you if you don't need to use the full range of them.
Caveats are that there is still something slightly broken with it on i386, and so I haven't looked at x86-64 yet. I don't see why this wouldn't work though.
I've called the new level 'pud'. u for upper or something.
Sorry the patch isn't in very good shape at the moment - I won't have time to work on it for a week, so I thought this would be a good point just to solicit initial comments.
Patches against recent -bk. patch 1/4 attached.
Thanks,
Nick
---
linux-2.6-npiggin/include/asm-generic/pgtable-nopmd.h | 47 +++++++++++++++ linux-2.6-npiggin/include/asm-i386/mmzone.h | 1 linux-2.6-npiggin/include/asm-i386/page.h | 6 - linux-2.6-npiggin/include/asm-i386/pgalloc.h | 7 -- linux-2.6-npiggin/include/asm-i386/pgtable-2level-defs.h | 2 linux-2.6-npiggin/include/asm-i386/pgtable-2level.h | 27 +------- linux-2.6-npiggin/include/asm-i386/pgtable-3level.h | 7 ++ linux-2.6-npiggin/include/asm-i386/pgtable.h | 14 +--- 8 files changed, 68 insertions(+), 43 deletions(-)
include/asm-generic/pgtable-nopmd.h new file +47 -0
@@ -0,0 +1,47 @@ +#ifndef _PGTABLE_NOPMD_H +#define _PGTABLE_NOPMD_H + +#define PMD_SHIFT PGDIR_SHIFT +#define PTRS_PER_PMD 1 +#define PMD_SIZE (1UL << PMD_SHIFT) +#define PMD_MASK (~(PMD_SIZE-1)) + +/* +* The "pgd_xxx()" functions here are trivial for a folded two-level +* setup: the pmd is never bad, and a pmd always exists (as it's folded +* into the pgd entry) +*/ +#define pgd_none (pmd) 0 +#define pgd_bad (pmd) 0 +#define pgd_present (pmd) 1 +#define pgd_clear (xp) do { } while (0) +#define pgd_ERROR (pmd) do { } while (0) + +#define pgd_populate (mm, pmd, pte) do { } while (0) +#define pgd_populate_kernel (mm, pmd, pte) do { } while (0) + +/* +* (pmds are folded into pgds so this doesn't get actually called, +* but the define is needed for a generic inline function.) +*/ +#define set_pmd (pmdptr, pmdval) set_pgd(((pgd_t *)pmdptr), __pgd(pmd_val(pmdval))) + +#define pmd_offset (pgd, address) ((pmd_t *)(pgd)) + +#define pmd_val (x) (pgd_val((x).pmd)) +#define __pmd (x) ((pmd_t) { (x) } ) + +#define pmd_page (pmd) (pgd_page(*(pgd_t *)&(pmd))) +#define pmd_page_kernel (pmd) (pgd_page_kernel(*(pgd_t *)&(pmd))) + +/* +* allocating and freeing a pmd is trivial: the 1-entry pmd is +* inside the pgd, so has no extra memory associated with it. +*/ +#define pmd_alloc_one (mm, address) NULL +#define pmd_free (x) do { } while (0) +#define __pmd_free_tlb (tlb, x) do { } while (0) + +typedef struct {pgd_t pmd; }pmd_t ; + +#endif /* _PGTABLE_NOPMD_H */
include/asm-i386/pgtable-2level.h renamed from include/asm-i386/pgtable-2level.h~3level-cleanup +4 -23
@@ -1,22 +1,12 @@#ifndef _I386_PGTABLE_2LEVEL_H#define _I386_PGTABLE_2LEVEL_H +#include <asm-generic/pgtable-nopmd.h> +#define pte_ERROR (e) \ printk("%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, (e).pte_low)#define pmd_ERROR (e) \ printk("%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e)) -#define pgd_ERROR (e) \ - printk("%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pgd_val(e)) - -/* -* The "pgd_xxx()" functions here are trivial for a folded two-level -* setup: the pgd is never bad, and a pmd always exists (as it's folded -* into the pgd entry) -*/ -static inline int pgd_none (pgd_t pgd) {return 0 ; } -static inline int pgd_bad (pgd_t pgd) {return 0 ; } -static inline int pgd_present (pgd_t pgd) {return 1 ; } -#define pgd_clear (xp) do { } while (0)/* * Certain architectures need to do special things when PTEs
@@ -25,20 +15,11 @@ static inline int pgd_present(pgd_t pgd)*/ #define set_pte (pteptr, pteval) (*(pteptr) = pteval)#define set_pte_atomic (pteptr, pteval) set_pte(pteptr,pteval) -/* -* (pmds are folded into pgds so this doesn't get actually called, -* but the define is needed for a generic inline function.) -*/ -#define set_pmd (pmdptr, pmdval) (*(pmdptr) = pmdval) +#define set_pgd (pgdptr, pgdval) (*(pgdptr) = pgdval) -#define pgd_page (pgd) \ -((unsigned long) __va(pgd_val(pgd) & PAGE_MASK)) +#define pgd_page (pgd) (pfn_to_page(pgd_val(pgd) >> PAGE_SHIFT)) -static inline pmd_t *pmd_offset (pgd_t * dir,unsigned long address) -{ -return (pmd_t *) dir; -}#define ptep_get_and_clear (xp) __pte(xchg(&(xp)->pte_low, 0))#define pte_same (a, b) ((a).pte_low == (b).pte_low)#define pte_page (x) pfn_to_page(pte_pfn(x))
include/asm-i386/page.h renamed from include/asm-i386/page.h~3level-cleanup +2 -4
@@ -46,11 +46,12 @@ typedef struct { unsigned long pte_low,typedef struct {unsigned long long pmd; }pmd_t ;typedef struct {unsigned long long pgd; }pgd_t ;typedef struct {unsigned long long pgprot; }pgprot_t ; +#define pmd_val (x) ((x).pmd)#define pte_val (x) ((x).pte_low | ((unsigned long long)(x).pte_high << 32)) +#define __pmd (x) ((pmd_t) { (x) } )#define HPAGE_SHIFT 21#else typedef struct {unsigned long pte_low; }pte_t ; -typedef struct {unsigned long pmd; }pmd_t ;typedef struct {unsigned long pgd; }pgd_t ;typedef struct {unsigned long pgprot; }pgprot_t ;#define boot_pte_t pte_t/* or would you rather have a typedef */
@@ -66,13 +67,10 @@ typedef struct { unsigned long pgprot; }#define HAVE_ARCH_HUGETLB_UNMAPPED_AREA #endif - -#define pmd_val (x) ((x).pmd)#define pgd_val (x) ((x).pgd)#define pgprot_val (x) ((x).pgprot)#define __pte (x) ((pte_t) { (x) } ) -#define __pmd (x) ((pmd_t) { (x) } )#define __pgd (x) ((pgd_t) { (x) } )#define __pgprot (x) ((pgprot_t) { (x) } )
include/asm-i386/pgtable-2level-defs.h renamed from include/asm-i386/pgtable-2level-defs.h~3level-cleanup +0 -2
@@ -12,8 +12,6 @@* the i386 is two-level, so we don't really have any * PMD directory physically. */ -#define PMD_SHIFT 22 -#define PTRS_PER_PMD 1#define PTRS_PER_PTE 1024
diff -puN include/asm-generic/pgtable.h~3level-cleanup include/asm-generic/pgtable.h
include/asm-i386/pgtable-3level.h renamed from include/asm-i386/pgtable-3level.h~3level-cleanup +7 -0
@@ -73,6 +73,11 @@ static inline void pgd_clear (pgd_t * pg#define pgd_page (pgd) \ ((unsigned long) __va(pgd_val(pgd) & PAGE_MASK)) +#define pmd_page (pmd) (pfn_to_page(pmd_val(pmd) >> PAGE_SHIFT)) + +#define pmd_page_kernel (pmd) \ +((unsigned long) __va(pmd_val(pmd) & PAGE_MASK)) +/* Find an entry in the second-level page table.. */ #define pmd_offset (dir, address) ((pmd_t *) pgd_page(*(dir)) + \ pmd_index(address))
@@ -142,4 +147,6 @@ static inline pmd_t pfn_pmd(unsigned lon#define __pte_to_swp_entry (pte) ((swp_entry_t){ (pte).pte_high })#define __swp_entry_to_pte (x) ((pte_t){ 0, (x).val }) +#define __pmd_free_tlb (tlb, x) do { } while (0) +#endif /* _I386_PGTABLE_3LEVEL_H */
include/asm-i386/pgalloc.h renamed from include/asm-i386/pgalloc.h~3level-cleanup +3 -4
@@ -39,16 +39,15 @@ static inline void pte_free(struct page#define __pte_free_tlb (tlb,pte) tlb_remove_page((tlb),(pte)) +#ifdef CONFIG_X86_PAE /* -* allocating and freeing a pmd is trivial: the 1-entry pmd is -* inside the pgd, so has no extra memory associated with it. -* (In the PAE case we free the pmds as part of the pgd.) +* In the PAE case we free the pmds as part of the pgd. */ -#define pmd_alloc_one (mm, addr) ({ BUG(); ((pmd_t *)2); })#define pmd_free (x) do { } while (0)#define __pmd_free_tlb (tlb,x) do { } while (0)#define pgd_populate (mm, pmd, pte) BUG() +#endif #define check_pgt_cache () do { } while (0)
include/asm-i386/pgtable.h renamed from include/asm-i386/pgtable.h~3level-cleanup +5 -9
@@ -50,12 +50,12 @@ void paging_init(void);*/ #ifdef CONFIG_X86_PAE # include <asm/pgtable-3level-defs.h> +# define PMD_SIZE (1UL << PMD_SHIFT) +# define PMD_MASK (~(PMD_SIZE-1))#else # include <asm/pgtable-2level-defs.h> #endif -#define PMD_SIZE (1UL << PMD_SHIFT) -#define PMD_MASK (~(PMD_SIZE-1))#define PGDIR_SIZE (1UL << PGDIR_SHIFT)#define PGDIR_MASK (~(PGDIR_SIZE-1))
@@ -293,15 +293,11 @@ static inline pte_t pte_modify(pte_t pte#define page_pte (page) page_pte_prot(page, __pgprot(0)) -#define pmd_page_kernel (pmd) \ -((unsigned long) __va(pmd_val(pmd) & PAGE_MASK)) - -#ifndef CONFIG_DISCONTIGMEM -#define pmd_page (pmd) (pfn_to_page(pmd_val(pmd) >> PAGE_SHIFT)) -#endif /* !CONFIG_DISCONTIGMEM */ +#define pgd_page_kernel (pgd) \ +((unsigned long) __va(pgd_val(pgd) & PAGE_MASK))#define pmd_large (pmd) \ - ((pmd_val(pmd) & (_PAGE_PSE|_PAGE_PRESENT)) == (_PAGE_PSE|_PAGE_PRESENT)) +((pmd_val(pmd) & (_PAGE_PSE|_PAGE_PRESENT)) == (_PAGE_PSE|_PAGE_PRESENT))/* * the pgd page can be thought of an array like this: pgd_t[PTRS_PER_PGD]
include/asm-i386/mmzone.h renamed from include/asm-i386/mmzone.h~3level-cleanup +0 -1
@@ -116,7 +116,6 @@ static inline struct pglist_data *pfn_to (unsigned long )(__page - __zone->zone_mem_map) \ + __zone->zone_start_pfn; \ }) -#define pmd_page (pmd) (pfn_to_page(pmd_val(pmd) >> PAGE_SHIFT))#ifdef CONFIG_X86_NUMAQ /* we have contiguous memory on NUMA-Q */ #define pfn_valid (pfn) ((pfn) < num_physpages)
_
2/4
---
linux-2.6-npiggin/include/asm-generic/pgtable-nopmd.h | 44 ++++++++-------- linux-2.6-npiggin/include/asm-generic/pgtable-nopud.h | 47 ++++++++++++++++++ linux-2.6-npiggin/include/asm-generic/tlb.h | 6 ++ linux-2.6-npiggin/include/asm-i386/pgalloc.h | 2 linux-2.6-npiggin/include/asm-i386/pgtable-3level.h | 16 +++--- 5 files changed, 86 insertions(+), 29 deletions(-)
include/asm-generic/pgtable-nopud.h new file +47 -0
@@ -0,0 +1,47 @@ +#ifndef _PGTABLE_NOPUD_H +#define _PGTABLE_NOPUD_H + +#define PUD_SHIFT PGDIR_SHIFT +#define PTRS_PER_PUD 1 +#define PUD_SIZE (1UL << PUD_SHIFT) +#define PUD_MASK (~(PUD_SIZE-1)) + +/* +* The "pgd_xxx()" functions here are trivial for a folded two or three-level +* setup: the pgd is never bad, and a pud always exists (as it's folded +* into the pgd entry) +*/ +#define pgd_none (pgd) 0 +#define pgd_bad (pgd) 0 +#define pgd_present (pgd) 1 +#define pgd_clear (xp) do { } while (0) +#define pgd_ERROR (pgd) do { } while (0) + +#define pgd_populate (mm, pud, pmd) do { } while (0) + +/* +* (puds are folded into pgds so this doesn't get actually called, +* but the define is needed for a generic inline function.) +*/ +#define set_pud (pudptr, pudval) set_pgd(((pgd_t *)pudptr), *(pgd_t *)&(pudval)) + +#define pud_offset (pgd, address) ((pud_t *)(pgd)) +#define pud_offset_k (pgd, address) ((pud_t *)(pgd)) + +#define pud_val (x) (pgd_val((x).pud)) +#define __pud (x) ((pud_t) { (x) } ) + +#define pud_page (pud) (pgd_page(*(pgd_t *)&(pud))) +#define pud_page_kernel (pud) (pgd_page_kernel(*(pgd_t *)&(pud))) + +/* +* allocating and freeing a pud is trivial: the 1-entry pud is +* inside the pgd, so has no extra memory associated with it. +*/ +#define pud_alloc_one (mm, address) NULL +#define pud_free (x) do { } while (0) +#define __pud_free_tlb (tlb, x) do { } while (0) + +typedef struct {pgd_t pud; }pud_t ; + +#endif /* _PGTABLE_NOPUD_H */
include/asm-generic/pgtable-nopmd.h renamed from include/asm-generic/pgtable-nopmd.h~4level-compat +23 -21
70 lines not on this page · raw message
diff -puN include/asm-i386/pgtable.h~4level-compat include/asm-i386/pgtable.h
include/asm-generic/tlb.h renamed from include/asm-generic/tlb.h~4level-compat +6 -0
@@ -141,6 +141,12 @@ static inline void tlb_remove_page(struc__pte_free_tlb (tlb, ptep); \ } while (0) +#define pud_free_tlb (tlb, pudp) \ + do { \ + tlb->need_flush = 1; \ + __pud_free_tlb(tlb, pudp); \ + } while (0) +#define pmd_free_tlb (tlb, pmdp) \ do { \ tlb->need_flush = 1; \
include/asm-i386/pgtable-3level.h renamed from include/asm-i386/pgtable-3level.h~4level-compat +9 -7
@@ -1,6 +1,8 @@#ifndef _I386_PGTABLE_3LEVEL_H#define _I386_PGTABLE_3LEVEL_H +#include <asm-generic/pgtable-nopud.h> +/* * Intel Physical Address Extension (PAE) Mode - three-level page * tables on PPro+ CPUs.
@@ -12,12 +14,12 @@ printk("%s:%d: bad pte %p(%08lx%08lx).\n", __FILE__, __LINE__, &(e), (e).pte_high, (e).pte_low)#define pmd_ERROR (e) \ printk("%s:%d: bad pmd %p(%016Lx).\n", __FILE__, __LINE__, &(e), pmd_val(e)) -#define pgd_ERROR (e) \ - printk("%s:%d: bad pgd %p(%016Lx).\n", __FILE__, __LINE__, &(e), pgd_val(e)) +#define pud_ERROR (e) \ + printk("%s:%d: bad pud %p(%016Lx).\n", __FILE__, __LINE__, &(e), pud_val(e)) -static inline int pgd_none (pgd_t pgd) {return 0 ; } -static inline int pgd_bad (pgd_t pgd) {return 0 ; } -static inline int pgd_present (pgd_t pgd) {return 1 ; } +#define pud_none (pud) 0 +#define pud_bad (pud) 0 +#define pud_present (pud) 1/* * Is the pte executable?
@@ -68,7 +70,7 @@ static inline void set_pte(pte_t *ptep,* We do not let the generic code free and clear pgd entries due to * this erratum. */ -static inline void pgd_clear (pgd_t * pgd) { } +#define pud_clear (pud) do { } while (0)#define pgd_page (pgd) \ ((unsigned long) __va(pgd_val(pgd) & PAGE_MASK))
@@ -79,7 +81,7 @@ static inline void pgd_clear (pgd_t * pg ((unsigned long )__va (pmd_val (pmd) &PAGE_MASK )) /* Find an entry in the second-level page table.. */ -#define pmd_offset (dir, address) ((pmd_t *) pgd_page(*(dir)) + \ +#define pmd_offset (pud, address) ((pmd_t *) pud_page(*(pud)) + \ pmd_index(address))static inline pte_t ptep_get_and_clear (pte_t *ptep)
include/asm-i386/pgalloc.h renamed from include/asm-i386/pgalloc.h~4level-compat +1 -1
@@ -46,7 +46,7 @@ static inline void pte_free(struct page#define pmd_alloc_one (mm, addr) ({ BUG(); ((pmd_t *)2); })#define pmd_free (x) do { } while (0)#define __pmd_free_tlb (tlb,x) do { } while (0) -#define pgd_populate (mm, pmd, pte) BUG() +#define pud_populate (mm, pmd, pte) BUG()#endif #define check_pgt_cache () do { } while (0)
_
3/4 - core patch
Extend the Linux MM to 4level page tables.
This is the core patch for mm/*, fs/*, include/linux/*
It breaks all architectures, which will be fixed in separate patches.
The conversion is quite straight forward. All the functions walking the page table hierarchy have been changed to deal with another level at the top. The additional level is called pml4.
mm/memory.c has changed a lot because it did most of the heavy lifting here. Most of the changes here are extensions of the previous code.
One exception is copy_page_range() which I rewrote into the standard multiple inlines style. The previous single function goto heaven was not really scalable to 4level.
pgd_offset() and pgd_offset_k() have been renamed to make sure all unconverted code causes an compile error. They are replaced with pml4_offset()/pml4_offset_k() and pml4_pgd_offset()/pml4_pgd_offset_k() Please note than when you use pml4_offset_k() you also have to use pml4_pgd_offset_k() because IA64 requires a special case here.
---
25-akpm/fs/exec.c | 6 25-akpm/include/linux/init_task.h | 2 25-akpm/include/linux/sched.h | 2 25-akpm/kernel/fork.c | 6 25-akpm/mm/fremap.c | 11
---
linux-2.6-npiggin/fs/exec.c | 6 linux-2.6-npiggin/include/linux/init_task.h | 2 linux-2.6-npiggin/include/linux/mm.h | 22 linux-2.6-npiggin/mm/fremap.c | 18 linux-2.6-npiggin/mm/memory.c | 687 ++++++++++++++++++---------- linux-2.6-npiggin/mm/mempolicy.c | 22 linux-2.6-npiggin/mm/mmap.c | 25 - linux-2.6-npiggin/mm/mprotect.c | 65 +- linux-2.6-npiggin/mm/mremap.c | 29 - linux-2.6-npiggin/mm/msync.c | 55 +- linux-2.6-npiggin/mm/rmap.c | 21 linux-2.6-npiggin/mm/swapfile.c | 81 ++- linux-2.6-npiggin/mm/vmalloc.c | 113 +++- 13 files changed, 794 insertions(+), 352 deletions(-)
fs/exec.c renamed from fs/exec.c~4level-core-patch +5 -1
@@ -300,6 +300,7 @@ void install_arg_page(struct vm_area_str {struct mm_struct *mm = vma->vm_mm;pgd_t * pgd; +pud_t * pud;pmd_t * pmd;pte_t * pte;
@@ -310,7 +311,10 @@ void install_arg_page(struct vm_area_str pgd =pgd_offset (mm, address);spin_lock (&mm->page_table_lock); - pmd =pmd_alloc (mm, pgd, address); + pud =pud_alloc (mm, pgd, address); +if (!pud) + goto out; + pmd =pmd_alloc (mm, pud, address);if (!pmd) goto out; pte =pte_alloc_map (mm, pmd, address);
include/linux/init_task.h renamed from include/linux/init_task.h~4level-core-patch +1 -1
@@ -34,7 +34,7 @@#define INIT_MM (name) \ { \ .mm_rb = RB_ROOT, \ - .pgd = swapper_pg_dir, \ + .pgd = swapper_pg_dir, \ .mm_users = ATOMIC_INIT(2), \ .mm_count = ATOMIC_INIT(1), \ .mmap_sem = __RWSEM_INITIALIZER(name.mmap_sem), \
include/linux/mm.h renamed from include/linux/mm.h~4level-core-patch +15 -7
@@ -566,7 +566,7 @@ int unmap_vmas(struct mmu_gather **tlbp, struct vm_area_struct *start_vma, unsigned long start_addr, unsigned long end_addr, unsigned long *nr_accounted, struct zap_details *); -void clear_page_tables (struct mmu_gather *tlb,unsigned long first,int nr); +void clear_page_range (struct mmu_gather *tlb,unsigned long addr,unsigned long end);int copy_page_range (struct mm_struct *dst,struct mm_struct *src,struct vm_area_struct *vma); int zeromap_page_range(struct vm_area_struct *vma, unsigned long from,
@@ -581,7 +581,8 @@ static inline void unmap_shared_mapping_ }extern int vmtruncate (struct inode * inode,loff_t offset); -extern pmd_t *FASTCALL (__pmd_alloc (struct mm_struct *mm,pgd_t *pgd,unsigned long address)); +extern pud_t *FASTCALL (__pud_alloc (struct mm_struct *mm,pgd_t *pgd,unsigned long address)); +extern pmd_t *FASTCALL (__pmd_alloc (struct mm_struct *mm,pud_t *pud,unsigned long address));extern pte_t *FASTCALL (pte_alloc_kernel (struct mm_struct *mm,pmd_t *pmd,unsigned long address));extern pte_t *FASTCALL (pte_alloc_map (struct mm_struct *mm,pmd_t *pmd,unsigned long address));extern int install_page (struct mm_struct *mm,struct vm_area_struct *vma,unsigned long addr,struct page *page,pgprot_t prot);
@@ -626,15 +627,22 @@ extern struct shrinker *set_shrinker(intextern void remove_shrinker (struct shrinker *shrinker);/* -* On a two-level page table, this ends up being trivial. Thus the -* inlining and the symmetry break with pte_alloc_map() that does all +* On a two-level or three-level page table, this ends up being trivial. Thus +* the inlining and the symmetry break with pte_alloc_map() that does all * of this out-of-line. */ -static inline pmd_t *pmd_alloc (struct mm_struct *mm,pgd_t *pgd,unsigned long address) +static inline pud_t *pud_alloc (struct mm_struct *mm,pgd_t *pgd,unsigned long address) {if (pgd_none (*pgd)) -return __pmd_alloc (mm, pgd, address); -return pmd_offset (pgd, address); +return __pud_alloc (mm, pgd, address); +return pud_offset (pgd, address); +} + +static inline pmd_t *pmd_alloc (struct mm_struct *mm,pud_t *pud,unsigned long address) +{ +if (pud_none (*pud)) +return __pmd_alloc (mm, pud, address); +return pmd_offset (pud, address); }extern void free_area_init (unsigned long * zones_size);
diff -puN include/linux/sched.h~4level-core-patch include/linux/sched.h diff -puN kernel/fork.c~4level-core-patch kernel/fork.c
mm/fremap.c renamed from mm/fremap.c~4level-core-patch +14 -4
@@ -60,14 +60,19 @@ int install_page(struct mm_struct *mm, spgoff_t size;int err = -ENOMEM ;pte_t *pte; -pgd_t *pgd;pmd_t *pmd; +pud_t *pud; +pgd_t *pgd;pte_t pte_val; pgd =pgd_offset (mm, addr);spin_lock (&mm->page_table_lock); + + pud =pud_alloc (mm, pgd, addr); +if (!pud) + goto err_unlock; - pmd =pmd_alloc (mm, pgd, addr); + pmd =pmd_alloc (mm, pud, addr);if (!pmd) goto err_unlock;
@@ -112,14 +117,19 @@ int install_file_pte(struct mm_struct *m {int err = -ENOMEM ;pte_t *pte; -pgd_t *pgd;pmd_t *pmd; +pud_t *pud; +pgd_t *pgd;pte_t pte_val; pgd =pgd_offset (mm, addr);spin_lock (&mm->page_table_lock); + + pud =pud_alloc (mm, pgd, addr); +if (!pud) + goto err_unlock; - pmd =pmd_alloc (mm, pgd, addr); + pmd =pmd_alloc (mm, pud, addr);if (!pmd) goto err_unlock;
mm/memory.c renamed from mm/memory.c~4level-core-patch +455 -232
948 lines not on this page · raw message
mm/mempolicy.c renamed from mm/mempolicy.c~4level-core-patch +17 -5
@@ -233,18 +233,29 @@ static struct mempolicy *mpol_new(int mo/* Ensure all existing pages follow the policy. */ static int -verify_pages (unsigned long addr,unsigned long end,unsigned long *nodes) +verify_pages (struct mm_struct *mm, +unsigned long addr,unsigned long end,unsigned long *nodes) {while (addr < end) {struct page *p;pte_t *pte;pmd_t *pmd; -pgd_t *pgd =pgd_offset_k (addr); +pud_t *pud; +pgd_t *pgd; + pgd =pgd_offset (mm, addr);if (pgd_none (*pgd)) { - addr = (addr +PGDIR_SIZE ) &PGDIR_MASK ; +unsigned long next = (addr +PGDIR_SIZE ) &PGDIR_MASK ; +if (next > addr) +break ; + addr = next; +continue ; + } + pud =pud_offset (pgd, addr); +if (pud_none (*pud)) { + addr = (addr +PUD_SIZE ) &PUD_MASK ;continue ; } - pmd =pmd_offset (pgd, addr); + pmd =pmd_offset (pud, addr);if (pmd_none (*pmd)) { addr = (addr +PMD_SIZE ) &PMD_MASK ;continue ;
@@ -282,7 +293,8 @@ check_range(struct mm_struct *mm, unsignif (prev && prev->vm_end < vma->vm_start)return ERR_PTR (-EFAULT );if ((flags &MPOL_MF_STRICT ) && !is_vm_hugetlb_page (vma)) { - err =verify_pages (vma->vm_start, vma->vm_end, nodes); + err =verify_pages (vma->vm_mm, + vma->vm_start, vma->vm_end, nodes);if (err) { first =ERR_PTR (err);break ;
mm/mmap.c renamed from mm/mmap.c~4level-core-patch +13 -12
@@ -1474,7 +1474,7 @@ static void free_pgtables(struct mmu_gat {unsigned long first = start &PGDIR_MASK ;unsigned long last = end +PGDIR_SIZE -1 ; -unsigned long start_index, end_index; +unsigned long start_index;struct mm_struct *mm = tlb->mm;if (!prev) {
@@ -1498,23 +1498,23 @@ static void free_pgtables(struct mmu_gatif (last > next->vm_start) last = next->vm_start; } -if (prev->vm_end > first) +if (prev->vm_end > first) { first = prev->vm_end +PGDIR_SIZE -1 ; +if (first < prev->vm_end) + first =TASK_SIZE ; + }break ; } no_mmaps: -if (last < first)/* for arches with discontiguous pgd indices */ +if (last < first)/* for arches with discontiguous indices */ return ; -/* -* If the PGD bits are not consecutive in the virtual address, the -* old method of shifting the VA >> by PGDIR_SHIFT doesn't work. -*/ start_index =pgd_index (first); -if (start_index <FIRST_USER_PGD_NR ) +if (start_index <FIRST_USER_PGD_NR ) { start_index =FIRST_USER_PGD_NR ; - end_index =pgd_index (last); -if (end_index > start_index) { -clear_page_tables (tlb, start_index, end_index - start_index); + first = start_index *PGDIR_SIZE ; + } +if (last > first) { +clear_page_range (tlb, first, last);flush_tlb_pgtables (mm, first &PGDIR_MASK , last &PGDIR_MASK ); } }
@@ -1844,7 +1844,8 @@ void exit_mmap(struct mm_struct *mm) ~0UL, &nr_accounted, NULL);vm_unacct_memory (nr_accounted);BUG_ON (mm->map_count);/* This is just debugging */ -clear_page_tables (tlb,FIRST_USER_PGD_NR ,USER_PTRS_PER_PGD ); +clear_page_range (tlb,FIRST_USER_PGD_NR *PGDIR_SIZE , + (TASK_SIZE +PGDIR_SIZE -1 ) & ~(PGDIR_SIZE -1 ));tlb_finish_mmu (tlb,0 ,MM_VM_SIZE (mm)); vma = mm->mmap;
mm/mprotect.c renamed from mm/mprotect.c~4level-core-patch +47 -18
96 lines not on this page · raw message
mm/mremap.c renamed from mm/mremap.c~4level-core-patch +23 -6
@@ -25,19 +25,24 @@static pte_t *get_one_pte_map_nested (struct mm_struct *mm,unsigned long addr) {pgd_t *pgd; +pud_t *pud;pmd_t *pmd;pte_t *pte =NULL ; pgd =pgd_offset (mm, addr);if (pgd_none (*pgd)) goto end; -if (pgd_bad (*pgd)) { -pgd_ERROR (*pgd); -pgd_clear (pgd); + + pud =pud_offset (pgd, addr); +if (pud_none (*pud)) + goto end; +if (pud_bad (*pud)) { +pud_ERROR (*pud); +pud_clear (pud); goto end; } - pmd =pmd_offset (pgd, addr); + pmd =pmd_offset (pud, addr);if (pmd_none (*pmd)) goto end;if (pmd_bad (*pmd)) {
@@ -58,12 +63,17 @@ end:static pte_t *get_one_pte_map (struct mm_struct *mm,unsigned long addr) {pgd_t *pgd; +pud_t *pud;pmd_t *pmd; pgd =pgd_offset (mm, addr);if (pgd_none (*pgd))return NULL ; - pmd =pmd_offset (pgd, addr); + + pud =pud_offset (pgd, addr); +if (pud_none (*pud)) +return NULL ; + pmd =pmd_offset (pud, addr);if (!pmd_present (*pmd))return NULL ;return pte_offset_map (pmd, addr);
@@ -71,10 +81,17 @@ static pte_t *get_one_pte_map(struct mm_static inline pte_t *alloc_one_pte_map (struct mm_struct *mm,unsigned long addr) { +pgd_t *pgd; +pud_t *pud;pmd_t *pmd;pte_t *pte =NULL ; - pmd =pmd_alloc (mm,pgd_offset (mm, addr), addr); + pgd =pgd_offset (mm, addr); + + pud =pud_alloc (mm, pgd, addr); +if (!pud) +return NULL ; + pmd =pmd_alloc (mm, pud, addr);if (pmd) pte =pte_alloc_map (mm, pmd, addr);return pte;
mm/msync.c renamed from mm/msync.c~4level-core-patch +43 -12
96 lines not on this page · raw message
mm/rmap.c renamed from mm/rmap.c~4level-core-patch +18 -3
@@ -259,6 +259,7 @@ static int page_referenced_one(struct pastruct mm_struct *mm = vma->vm_mm;unsigned long address;pgd_t *pgd; +pud_t *pud;pmd_t *pmd;pte_t *pte;int referenced =0 ;
@@ -275,7 +276,11 @@ static int page_referenced_one(struct paif (!pgd_present (*pgd)) goto out_unlock; - pmd =pmd_offset (pgd, address); + pud =pud_offset (pgd, address); +if (!pud_present (*pud)) + goto out_unlock; + + pmd =pmd_offset (pud, address);if (!pmd_present (*pmd)) goto out_unlock;
@@ -499,6 +504,7 @@ static int try_to_unmap_one(struct pagestruct mm_struct *mm = vma->vm_mm;unsigned long address;pgd_t *pgd; +pud_t *pud;pmd_t *pmd;pte_t *pte;pte_t pteval;
@@ -520,7 +526,11 @@ static int try_to_unmap_one(struct pageif (!pgd_present (*pgd)) goto out_unlock; - pmd =pmd_offset (pgd, address); + pud =pud_offset (pgd, address); +if (!pud_present (*pud)) + goto out_unlock; + + pmd =pmd_offset (pud, address);if (!pmd_present (*pmd)) goto out_unlock;
@@ -628,6 +638,7 @@ static void try_to_unmap_cluster(unsigne {struct mm_struct *mm = vma->vm_mm;pgd_t *pgd; +pud_t *pud;pmd_t *pmd;pte_t *pte;pte_t pteval;
@@ -653,7 +664,11 @@ static void try_to_unmap_cluster(unsigneif (!pgd_present (*pgd)) goto out_unlock; - pmd =pmd_offset (pgd, address); + pud =pud_offset (pgd, address); +if (!pud_present (*pud)) + goto out_unlock; + + pmd =pmd_offset (pud, address);if (!pmd_present (*pmd)) goto out_unlock;
mm/swapfile.c renamed from mm/swapfile.c~4level-core-patch +60 -21
114 lines not on this page · raw message
mm/vmalloc.c renamed from mm/vmalloc.c~4level-core-patch +83 -30
176 lines not on this page · raw message
_
4/4 - 4level arch changes for i386
i386 works with 2 and 3 levels
---
---
linux-2.6-npiggin/arch/i386/kernel/acpi/sleep.c | 3 ++- linux-2.6-npiggin/arch/i386/kernel/vm86.c | 11 ++++++++++- linux-2.6-npiggin/arch/i386/mm/fault.c | 13 ++++++++++--- linux-2.6-npiggin/arch/i386/mm/hugetlbpage.c | 8 ++++++-- linux-2.6-npiggin/arch/i386/mm/init.c | 2 +- linux-2.6-npiggin/arch/i386/mm/ioremap.c | 7 ++++++- linux-2.6-npiggin/arch/i386/mm/pageattr.c | 10 +++++++--- linux-2.6-npiggin/include/asm-i386/pgalloc.h | 1 - linux-2.6-npiggin/include/asm-i386/pgtable.h | 1 + 9 files changed, 43 insertions(+), 13 deletions(-)
arch/i386/kernel/acpi/sleep.c renamed from arch/i386/kernel/acpi/sleep.c~4level-architecture-changes-for-i386 +2 -1
@@ -7,6 +7,7 @@#include <linux/acpi.h> #include <linux/bootmem.h> +#include <asm/current.h> /* XXX remove me */ #include <asm/smp.h>
@@ -24,7 +25,7 @@ static void init_low_mapping(pgd_t *pgd,int pgd_ofs =0 ;while ((pgd_ofs < pgd_limit) && (pgd_ofs +USER_PTRS_PER_PGD <PTRS_PER_PGD )) { -set_pgd (pgd, *(pgd+USER_PTRS_PER_PGD )); +set_pgd (pgd, (*(pgd+USER_PTRS_PER_PGD ))); pgd_ofs++, pgd++; } }
arch/i386/kernel/vm86.c renamed from arch/i386/kernel/vm86.c~4level-architecture-changes-for-i386 +10 -1
@@ -137,6 +137,7 @@ struct pt_regs * fastcall save_v86_statestatic void mark_screen_rdonly (struct task_struct * tsk) {pgd_t *pgd; +pud_t *pud;pmd_t *pmd;pte_t *pte, *mapped;int i;
@@ -151,7 +152,15 @@ static void mark_screen_rdonly(struct tapgd_clear (pgd); goto out; } - pmd =pmd_offset (pgd,0xA0000 ); + pud =pud_offset (pgd,0xA0000 ); +if (pud_none (*pud)) + goto out; +if (pud_bad (*pud)) { +pud_ERROR (*pud); +pud_clear (pud); + goto out; + } + pmd =pmd_offset (pud,0xA0000 );if (pmd_none (*pmd)) goto out;if (pmd_bad (*pmd)) {
arch/i386/mm/fault.c renamed from arch/i386/mm/fault.c~4level-architecture-changes-for-i386 +10 -3
@@ -518,6 +518,7 @@ vmalloc_fault:int index =pgd_index (address);unsigned long pgd_paddr;pgd_t *pgd, *pgd_k; +pud_t *pud, *pud_k;pmd_t *pmd, *pmd_k;pte_t *pte_k;
@@ -530,11 +531,17 @@ vmalloc_fault:/* * set_pgd(pgd, *pgd_k); here would be useless on PAE -* and redundant with the set_pmd() on non-PAE. +* and redundant with the set_pmd() on non-PAE. As would +* set_pud. */ - pmd =pmd_offset (pgd, address); - pmd_k =pmd_offset (pgd_k, address); + pud =pud_offset (pgd, address); + pud_k =pud_offset (pgd_k, address); +if (!pud_present (*pud_k)) + goto no_context; + + pmd =pmd_offset (pud, address); + pmd_k =pmd_offset (pud_k, address);if (!pmd_present (*pmd_k)) goto no_context;set_pmd (pmd, *pmd_k);
arch/i386/mm/hugetlbpage.c renamed from arch/i386/mm/hugetlbpage.c~4level-architecture-changes-for-i386 +6 -2
@@ -21,20 +21,24 @@static pte_t *huge_pte_alloc (struct mm_struct *mm,unsigned long addr) {pgd_t *pgd; +pud_t *pud;pmd_t *pmd =NULL ; pgd =pgd_offset (mm, addr); - pmd =pmd_alloc (mm, pgd, addr); + pud =pud_alloc (mm, pgd, addr); + pmd =pmd_alloc (mm, pud, addr);return (pte_t *) pmd; }static pte_t *huge_pte_offset (struct mm_struct *mm,unsigned long addr) {pgd_t *pgd; +pud_t *pud;pmd_t *pmd =NULL ; pgd =pgd_offset (mm, addr); - pmd =pmd_offset (pgd, addr); + pud =pud_offset (pgd, addr); + pmd =pmd_offset (pud, addr);return (pte_t *) pmd; }
arch/i386/mm/init.c renamed from arch/i386/mm/init.c~4level-architecture-changes-for-i386 +1 -1
@@ -233,7 +233,7 @@ EXPORT_SYMBOL(kmap_prot);EXPORT_SYMBOL (kmap_pte);#define kmap_get_fixmap_pte (vaddr) \ - pte_offset_kernel(pmd_offset(pgd_offset_k(vaddr), (vaddr)), (vaddr)) + pte_offset_kernel(pmd_offset(pud_offset(pgd_offset_k(vaddr), vaddr), (vaddr)), (vaddr))void __init kmap_init (void ) {
arch/i386/mm/ioremap.c renamed from arch/i386/mm/ioremap.c~4level-architecture-changes-for-i386 +6 -1
@@ -80,9 +80,14 @@ static int remap_area_pages(unsigned lonBUG ();spin_lock (&init_mm.page_table_lock); do { + pud_t *pud; pmd_t *pmd; - pmd = pmd_alloc(&init_mm, dir, address); + error = -ENOMEM; + pud = pud_alloc(&init_mm, dir, address); + if (!pud) + break; + pmd = pmd_alloc(&init_mm, pud, address); if (!pmd) break; if (remap_area_pmd(pmd, address, end - address,
arch/i386/mm/pageattr.c renamed from arch/i386/mm/pageattr.c~4level-architecture-changes-for-i386 +7 -3
@@ -19,11 +19,15 @@ static struct list_head df_list = LIST_Hpte_t *lookup_address (unsigned long address) { -pgd_t *pgd =pgd_offset_k (address); +pgd_t *pgd =pgd_offset_k (address); +pud_t *pud;pmd_t *pmd;if (pgd_none (*pgd))return NULL ; - pmd =pmd_offset (pgd, address); + pud =pud_offset (pgd, address); +if (pud_none (*pud)) +return NULL ; + pmd =pmd_offset (pud, address);if (pmd_none (*pmd))return NULL ;if (pmd_large (*pmd))
@@ -92,7 +96,7 @@ static void set_pmd_pte(pte_t *kpte, unsstatic inline void revert_page (struct page *kpte_page,unsigned long address) {pte_t *linear = (pte_t *) -pmd_offset (pgd_offset (&init_mm, address), address); +pmd_offset (pud_offset (pgd_offset_k (address), address), address);set_pmd_pte (linear, address,pfn_pte ((__pa (address) &LARGE_PAGE_MASK ) >>PAGE_SHIFT ,PAGE_KERNEL_LARGE ));
diff -puN arch/i386/mm/pgtable.c~4level-architecture-changes-for-i386 arch/i386/mm/pgtable.c diff -puN include/asm-i386/mmu_context.h~4level-architecture-changes-for-i386 include/asm-i386/mmu_context.h diff -puN include/asm-i386/page.h~4level-architecture-changes-for-i386 include/asm-i386/page.h
include/asm-i386/pgalloc.h renamed from include/asm-i386/pgalloc.h~4level-architecture-changes-for-i386 +0 -1
@@ -19,7 +19,6 @@ static inline void pmd_populate(struct m/* * Allocate and free page tables. */ -extern pgd_t *pgd_alloc (struct mm_struct *);extern void pgd_free (pgd_t *pgd);
include/asm-i386/pgtable.h renamed from include/asm-i386/pgtable.h~4level-architecture-changes-for-i386 +1 -0
@@ -306,6 +306,7 @@ static inline pte_t pte_modify(pte_t pte* control the given virtual address */ #define pgd_index (address) (((address) >> PGDIR_SHIFT) & (PTRS_PER_PGD-1)) +#define pgd_index_k (addr) pgd_index(addr)/* * pgd_offset() returns a (pgd_t *)
_
Quoted 11 lines · Nick Piggin
4/4 - 4level arch changes for i386
------------------------------------------------------------------------
i386 works with 2 and 3 levels
Signed-off-by Andi Kleen <[email protected]>Signed-off-by Andrew Morton <[email protected]>
^^^^^
Sorry, ignore these of course. I forgot they were still attached. --
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 4 lines · Nick Piggin
Just looking at your 4 level page tables patch, I wondered why the extra level isn't inserted between pgd and pmd, as that would appear to be the least intrusive (conceptually, in the generic code). Also it maybe matches more closely the way that the 2->3 level conversion was done.
I did it the way I did to keep i386 and other archs obviously correct because their logic doesn't change at all for the three lower levels, and the highest level just hands a pointer through.
Regarding intrusiveness in common code: you pretty much have to change most of of mm/memory.c, no matter what you do. Also there are overall only 7 or 8 users that really need the full scale changes, so it's not as bad as it looks. Ok there is ioremap in each architecture, but usually you can cheat for these because you know the architecture will never support 4levels.
I'm sorry, but I don't see much advantage of your patches over mine.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 11 lines · Andi Kleen
Quoted 4 lines · Nick Piggin
Just looking at your 4 level page tables patch, I wondered why the extra level isn't inserted between pgd and pmd, as that would appear to be the least intrusive (conceptually, in the generic code). Also it maybe matches more closely the way that the 2->3 level conversion was done.
I did it the way I did to keep i386 and other archs obviously correct because their logic doesn't change at all for the three lower levels, and the highest level just hands a pointer through.
Yeah true. Although a pointer to a pud is essentially just a pointer to pgd in the case where you've only got three levels instead of four.
So it is really a matter of where you make the "folds" I guess.
Quoted 6 lines
Regarding intrusiveness in common code: you pretty much have to change
most of ofmm/memory.c, no matter what you do. Also there are overall
only 7 or 8 users that really need the full scale changes, so it's not as bad as it looks. Ok there is ioremap in each architecture, but usually you can cheat for these because you know the architecture
will never support 4levels.
Yeah - technically you can ignore the "pud" type in this system as well if you're only using three levels, so architectures should be able to just work. Although really they should just be converted over for cleanliness.
Quoted 2 lines
I'm sorry, but I don't see much advantage of your patches over mine.
Well no there isn't much I guess - if mine were bug free it would nearly compile into the same object code.
The main thing I see is that in my scheme, you have the business ends of the page table - pgd and pte which are always there, and you fold away the middle, "transient" levels when they're not in use. It also allows you to use the same system for both pmd and pud.
But on the other hand yours is maybe as you say a bit less intrusive code-wise, if not logically. And maybe has other advantages as well.
Anyway, this was just a suggestion - as I said I won't have much time for it for the next week, but I might try to flesh it out a bit more after that.
Thanks
Nick
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 5 lines · Nick Piggin
Just looking at your 4 level page tables patch, I wondered why the extra level isn't inserted between pgd and pmd, as that would appear to be the least intrusive (conceptually, in the generic code). Also it maybe matches more closely the way that the 2->3 level conversion was done.
I thought the same, when I finally took a look a week or so ago.
I've scarcely looked at your patches, but notice they change i386.
For me, the attraction of putting the new level in between pgd and pmd was that it seemed that only common code and x86_64 (and whatever else comes to use all four levels in future) would need changing (beyond, perhaps, #including some asm-generic headers). Some casting to combine the two levels into pmd in unchanged arch code, or rename pmd to pld in the changed common code. Andi's arch patches seemed (all?) to spring from replacing mm->pgd by mm->pml4.
But I could well be mistaken, I wasn't so industrious as to actually try it.
Quoted 10 lines
I've been toying with it a little bit. It is mainly just starting with your code and doing straight conversions, although I also attempted to implement a better compatibility layer that does the pagetable "folding" for you if you don't need to use the full range of them.
Caveats are that there is still something slightly broken with it on i386, and so I haven't looked at x86-64 yet. I don't see why this wouldn't work though.
I've called the new level 'pud'. u for upper or something.
Well, yes, your base appetites have led you to the name "pud", where my refined intellect led me to "phd", with h for higher ;)
Quoted 3 lines
Sorry the patch isn't in very good shape at the moment - I won't have time to work on it for a week, so I thought this would be a good point just to solicit initial comments.
I doubt it's worthwhile now, particularly if you do have to patch arches.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 8 lines · Hugh Dickins
Quoted 4 lines · Nick Piggin
Just looking at your 4 level page tables patch, I wondered why the extra level isn't inserted between pgd and pmd, as that would appear to be the least intrusive (conceptually, in the generic code). Also it maybe matches more closely the way that the 2->3 level conversion was done.
Quoted 4 lines
I thought the same, when I finally took a look a week or so ago.
I've scarcely looked at your patches, but notice they change i386.
Yep. The problem is that I was making an asm-generic/ header file to handle pmd folding before even doing anything with 4 levels. Then this meant that pud folding could be just done with a straight copy of the pgtable-nopmd.h file.
Technically, I think, arch code would still run without changing a single line if you didn't want to include those new "folding" headers. (Maybe aside from a few type warnings / errors).
Andi's is much the same *except* that yes, being the top level means names have to be changed.
Quoted 8 lines
For me, the attraction of putting the new level in between pgd and pmd was that it seemed that only common code and
x86_64(and whatever else comes to use all four levels in future) would need changing (beyond, perhaps, #including some asm-generic headers). Some casting to combine the two levels into pmd in unchanged arch code, or rename pmd to pld in the changed common code. Andi's arch patches seemed (all?) to spring from replacingmm->pgdbymm->pml4.
My first attempt was to insert a pld below pmd actually :) It is the most appropriately named!
The problem is that some architectures are actually using this level, it is used in hugepages code, etc. So I decided a 'pud' was the least intrusive.
Quoted 13 lines
But I could well be mistaken, I wasn't so industrious as to actually try it.
Quoted 9 lines
I've been toying with it a little bit. It is mainly just starting with your code and doing straight conversions, although I also attempted to implement a better compatibility layer that does the pagetable "folding" for you if you don't need to use the full range of them.
Caveats are that there is still something slightly broken with it on i386, and so I haven't looked at x86-64 yet. I don't see why this wouldn't work though.
Quoted 6 lines
Quoted 1 line
I've called the new level 'pud'. u for upper or something.
Well, yes, your base appetites have led you to the name "pud", where my refined intellect led me to "phd", with h for higher ;)
Oh now I think that is going to cause you all sorts of problems ;)
Quoted 8 lines
Quoted 4 lines
Sorry the patch isn't in very good shape at the moment - I won't have time to work on it for a week, so I thought this would be a good point just to solicit initial comments.
I doubt it's worthwhile now, particularly if you do have to patch arches.
When I get time I'll do another cut with minimal possible architecture changes first, and put 'improvements' on top of that.
I think I'll hopefully have time to get something more productive to add to the debate before 2.6.10 comes out. I'm not completely adverse to Andi's system, but this is going to be around for the next n-years, so I figure an alternate perspective can't hurt.
Thanks
Nick
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>