Skip to contentSkip to conversation

SCSI breaks 'make allyesconfig'

DISCUSSION Jeff Garzik 3 participants 4 messages Nov 17, 2004

Subsystems (2)
SCSI SCSI tape driver
lore
Share & tools
lore

Jeff Garzik

author
#0 lore raw

Latest -bk:

[jgarzik@pretzel linux-2.6]$ make
CHK include/linux/version.h
make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.

  CHK     include/linux/compile.h
  CHK     usr/initramfs_list
  LD      drivers/scsi/built-in.o

drivers/scsi/osst.o(.bss+0x0): In function `exit_osst':
drivers/scsi/osst.c:195: multiple definition of `ST_partstat' drivers/scsi/st.o(.bss+0x0):drivers/scsi/st.c:244: first defined here make[2]: *** [drivers/scsi/built-in.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

author
#1 lore raw
Quoted 6 lines · Jeff Garzik

[jgarzik@pretzel linux-2.6]$ make
CHK include/linux/version.h
make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.

  CHK     include/linux/compile.h
  CHK     usr/initramfs_list
  LD      drivers/scsi/built-in.o
Quoted 6 lines

drivers/scsi/osst.o(.bss+0x0): In function `exit_osst':
drivers/scsi/osst.c:195: multiple definition of `ST_partstat' drivers/scsi/st.o(.bss+0x0):drivers/scsi/st.c:244: first defined here make[2]: *** [drivers/scsi/built-in.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

...and the attached patch fixes it. 'ST_partstat' is defined in
drivers/scsi/st.h, but never used.

Jeff

===== drivers/scsi/st.h 1.20 vs edited =====

drivers/scsi/st.h +1 -1
@@ -67,7 +67,7 @@
 	u32 last_block_visited;
 	int drv_block;		/* The block where the drive head is */
 	int drv_file;
-} ST_partstat;
+};
 
 #define ST_NBR_PARTITIONS 4
#2 lore raw
Quoted 10 lines · Jeff Garzik
Quoted 6 lines

drivers/scsi/osst.o(.bss+0x0): In function `exit_osst':
drivers/scsi/osst.c:195: multiple definition of `ST_partstat' drivers/scsi/st.o(.bss+0x0):drivers/scsi/st.c:244: first defined here make[2]: *** [drivers/scsi/built-in.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

...and the attached patch fixes it. 'ST_partstat' is defined in
drivers/scsi/st.h, but never used.

Yes, this was reported and fixed yesterday. The fix is already in the SCSI BK repo:

http://linux-scsi.bkbits.net:8080/scsi-rc-fixes-2.6/cset@419a6d19FQrj1AswswaWWZLXreWppw

James

#3 lore raw
In reply to Jeff Garzik
Quoted 3 lines · Jeff Garzik

drivers/scsi/osst.o(.bss+0x0): In function `exit_osst':
drivers/scsi/osst.c:195: multiple definition of `ST_partstat' drivers/scsi/st.o(.bss+0x0):drivers/scsi/st.c:244: first defined here

Reported yesterday, and the patch was sent to linux-scsi.

Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain