Support for Audigy2 Value SB0400
PATCH 1/1 Support for Audigy2 Value SB0400
The following URL contains a patch against the current alsa-driver CVS.
It addes support for the SB0400 version of the Audigy2 Value, that uses the new CA0108 chip.
http://www.alsa-project.org/~james/alsa-driver/audigy2/audigy2_value-support.diff
-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE FREE OODBMS DOWNLOAD - A multidimensional database that combines robust object and relational technologies, making it a perfect match for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
At Sun, 21 Nov 2004 02:03:12 +0000,
Quoted 6 lines · James Courtier-Dutton
The following URL contains a patch against the current alsa-driver CVS. It addes support for the SB0400 version of the Audigy2 Value, that uses the new CA0108 chip.
http://www.alsa-project.org/~james/alsa-driver/audigy2/audigy2_value-support.diff
May I assume that the function of Audigy2-value is identical with Audigy2? (since you set the driver name "Audigy2" for Audigy2 Value.)
The patch looks fine. Could you provide the nice patch description and the signed-off-by lines?
thanks,
Takashi
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
Quoted 2 lines · Takashi Iwai
The patch looks fine. Could you provide the nice patch description and the signed-off-by lines?
Also, I noticed the patch contains some /proc changes. Care to comment a little on these? I was also planning to improve the /proc support, but don't want to duplicate any work.
Lee
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
At Mon, 22 Nov 2004 12:50:18 -0500,
Quoted 8 lines · Lee Revell
Quoted 2 lines · Takashi Iwai
The patch looks fine. Could you provide the nice patch description and the signed-off-by lines?
Also, I noticed the patch contains some /proc changes. Care to comment a little on these? I was also planning to improve the /proc support, but don't want to duplicate any work.
Yep, at best, the patch should be splitting three parts with summary, descrption and signed-off-by lines for each:
- fix for snd_emu10k1_compose_audigy_*() macros
- addition of Audigy2 Value support
- addition to proc for register dump
James, could you do this?
thanks,
Takashi
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
Quoted 21 lines · Takashi Iwai
At Mon, 22 Nov 2004 12:50:18 -0500,
Quoted 8 lines · Lee Revell
Quoted 2 lines · Takashi Iwai
The patch looks fine. Could you provide the nice patch description and the signed-off-by lines?
Also, I noticed the patch contains some /proc changes. Care to comment a little on these? I was also planning to improve the /proc support, but don't want to duplicate any work.
Yep, at best, the patch should be splitting three parts with summary, descrption and signed-off-by lines for each:
- fix for snd_emu10k1_compose_audigy_*() macros
- addition of Audigy2 Value support
- addition to proc for register dump
Quoted 7 lines
James, could you do this?
thanks,
Takashi
I could, but it will have to wait till next weekend.
The register dump should only happen if the driver is built with CONFIG_SND_DEBUG switched on.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/
At Mon, 22 Nov 2004 18:33:47 +0000,
Quoted 27 lines · James Courtier-Dutton
Quoted 25 lines · Takashi Iwai
At Mon, 22 Nov 2004 12:50:18 -0500,
Quoted 8 lines · Lee Revell
Quoted 2 lines · Takashi Iwai
The patch looks fine. Could you provide the nice patch description and the signed-off-by lines?
Also, I noticed the patch contains some /proc changes. Care to comment a little on these? I was also planning to improve the /proc support, but don't want to duplicate any work.
Yep, at best, the patch should be splitting three parts with summary, descrption and signed-off-by lines for each:
- fix for snd_emu10k1_compose_audigy_*() macros
- addition of Audigy2 Value support
- addition to proc for register dumpJames, could you do this?
thanks,
Quoted 7 lines
Quoted 3 lines
Takashi
I could, but it will have to wait till next weekend. The register dump should only happen if the driver is built with
CONFIG_SND_DEBUGswitched on.
Hmm, ok I committed the audigy_fxrt* fix and the audigy2 value support. The patch to emuproc.c isn't committed yet since this would conflict with Lee's work.
Lee, please let me know if it's better to merge James's patch beforehand.
Takashi
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
Quoted 6 lines · Takashi Iwai
Hmm, ok I committed the audigy_fxrt* fix and the audigy2 value support. The patch to
emuproc.cisn't committed yet since this would conflict with Lee's work.Lee, please let me know if it's better to merge James's patch beforehand.
Yeah go ahead and commit this too. There is no conflict with my /proc changes.
Lee
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
At Mon, 22 Nov 2004 19:11:52 -0500,
Quoted 11 lines · Lee Revell
Quoted 6 lines · Takashi Iwai
Hmm, ok I committed the audigy_fxrt* fix and the audigy2 value support. The patch to
emuproc.cisn't committed yet since this would conflict with Lee's work.Lee, please let me know if it's better to merge James's patch beforehand.
Yeah go ahead and commit this too. There is no conflict with my /proc changes.
Ok, done. All patches from James have been applied to CVS.
Takashi
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
Quoted 13 lines · Takashi Iwai
At Sun, 21 Nov 2004 02:03:12 +0000,
Quoted 4 lines · James Courtier-Dutton
The following URL contains a patch against the current alsa-driver CVS.
It addes support for the SB0400 version of the Audigy2 Value, that uses the new CA0108 chip.http://www.alsa-project.org/~james/alsa-driver/audigy2/audigy2_value-support.diff
May I assume that the function of Audigy2-value is identical with Audigy2? (since you set the driver name "Audigy2" for Audigy2 Value.)
Quoted 9 lines
The patch looks fine. Could you provide the nice patch description and the signed-off-by lines?
thanks,
Takashi
The patch makes the Audigy2 Value work exectly the same as the Audigy2 currently works.
patch description:
This adds support for the SB0400 version of the Audigy2 Value, that uses the new CA0108 chip.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/