Skip to contentSkip to conversation

app/testpmd: fix unused variable compile error

dpdk-dev Applied [email protected] 4 participants 5 messages Sep 25, 2019 – Sep 26, 2019

lore
Share & tools
lore
#0 lore raw

From: Zhu Tao <[email protected]>

This minor patch fixes unused variable ‘ret’ compile error When CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.

Fixes f5267e485a2a ("app/testpmd: check status of getting ethdev info")
---
 app/test-pmd/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
app/test-pmd/config.c +1 -1
index 957c61fbe..a3b6cbd08 100644
@@ -1649,10 +1649,10 @@ ring_rx_descriptor_display(const struct rte_memzone *ring_mz,
 #endif
 			   uint16_t desc_id)
 {
-	int ret;
 	struct igb_ring_desc_16_bytes *ring =
 		(struct igb_ring_desc_16_bytes *)ring_mz->addr;
 #ifndef RTE_LIBRTE_I40E_16BYTE_RX_DESC
+	int ret;
 	struct rte_eth_dev_info dev_info;
 
 	ret = eth_dev_info_get_print_err(port_id, &dev_info);
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 app/testpmd: fix unused variable compile error

From: Zhu Tao <[email protected]>

This minor patch fixes unused variable ‘ret’ compile error When CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.

Fixes f5267e485a2a ("app/testpmd: check status of getting ethdev info")
---
 app/test-pmd/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
app/test-pmd/config.c +1 -1
index 957c61fbe..a3b6cbd08 100644
@@ -1649,10 +1649,10 @@ ring_rx_descriptor_display(const struct rte_memzone *ring_mz,
 #endif
 			   uint16_t desc_id)
 {
-	int ret;
 	struct igb_ring_desc_16_bytes *ring =
 		(struct igb_ring_desc_16_bytes *)ring_mz->addr;
 #ifndef RTE_LIBRTE_I40E_16BYTE_RX_DESC
+	int ret;
 	struct rte_eth_dev_info dev_info;
 
 	ret = eth_dev_info_get_print_err(port_id, &dev_info);
Signature · 1 line
2.17.1
Reviewed-by on v2 1/1
#2 lore raw
Quoted 11 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of [email protected]
Sent: Thursday, September 26, 2019 2:03 AM
To: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; Iremonger, Bernard <[email protected]>
Cc: [email protected]; [email protected]; Zhu, TaoX <[email protected]>
Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error

Quoted 8 lines

From: Zhu Tao <[email protected]>

This minor patch fixes unused variable ‘ret’ compile error When CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.

Fixes f5267e485a2a ("app/testpmd: check status of getting ethdev info")
Applied
#3 lore raw
Quoted 13 lines · Qi Z
Quoted 13 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of [email protected]
Sent: Thursday, September 26, 2019 2:03 AM
To: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; Iremonger, Bernard <[email protected]>
Cc: [email protected]; [email protected]; Zhu, TaoX <[email protected]>
Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error

From: Zhu Tao <[email protected]>

Quoted 9 lines
Quoted 6 lines

This minor patch fixes unused variable ‘ret’ compile error When CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.

Fixes f5267e485a2a ("app/testpmd: check status of getting ethdev info")

Applied to dpdk-next-net/master, thanks.