Skip to contentSkip to conversation

ifdef typos: drivers_net_wireless_wavelan_cs.c

PATCH In review Domen Puncer 2 participants 2 messages Nov 24, 2004

Subsystems (2)
Kernel janitors Networking drivers (wireless)
lore
Share & tools
lore

Domen Puncer

author
#0 lore raw

PATCH 5/8 ifdef typos: drivers_net_wireless_wavelan_cs.c

wavelan.p.h defines *_ERROR
wavelan_cs.p.h defines *_ERRORS
Since only second one is included, change #ifdefs

Signed-off-by Domen Puncer <[email protected]>
drivers/net/wireless/wavelan_cs.c +2 -2
@@ -950,7 +950,7 @@ wv_diag(struct net_device *	dev)
 		  OP0_DIAGNOSE, SR0_DIAGNOSE_PASSED))
     ret = TRUE;
 
-#ifdef DEBUG_CONFIG_ERROR
+#ifdef DEBUG_CONFIG_ERRORS
   printk(KERN_INFO "wavelan_cs: i82593 Self Test failed!\n");
 #endif
   return(ret);

@@ -3463,7 +3463,7 @@ wv_ru_stop(struct net_device *	dev)
   /* If there was a problem */
   if(spin <= 0)
     {
-#ifdef DEBUG_CONFIG_ERROR
+#ifdef DEBUG_CONFIG_ERRORS
       printk(KERN_INFO "%s: wv_ru_stop(): The chip doesn't want to stop...\n",
 	     dev->name);
 #endif

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Hi Domen,
nice work :) i never noticed that there are some much typos.

To avoid namespace polution: IMHO its better to define:
wavelan_cd_DEBUG_CONFIG_ERRORS (you get the idea)
stupid long but would avoid conflics with possible other drivers/kernel debug defines.

re,
walter

Quoted 30 lines · Domen Puncer

wavelan.p.h defines *_ERROR
wavelan_cs.p.h defines *_ERRORS
Since only second one is included, change #ifdefs

Signed-off-by Domen Puncer <[email protected]>
drivers/net/wireless/wavelan_cs.c +2 -3
@@ -950,7 +950,7 @@ wv_diag(struct net_device *	dev)
 		  OP0_DIAGNOSE, SR0_DIAGNOSE_PASSED))
     ret = TRUE;
 
-#ifdef DEBUG_CONFIG_ERROR
+#ifdef DEBUG_CONFIG_ERRORS
   printk(KERN_INFO "wavelan_cs: i82593 Self Test failed!\n");
 #endif
   return(ret);

@@ -3463,7 +3463,7 @@ wv_ru_stop(struct net_device *	dev)
   /* If there was a problem */
   if(spin <= 0)
     {
-#ifdef DEBUG_CONFIG_ERROR
+#ifdef DEBUG_CONFIG_ERRORS
       printk(KERN_INFO "%s: wv_ru_stop(): The chip doesn't want to stop...\n",
 	     dev->name);
 #endif
 
 
------------------------------------------------------------------------
Quoted 4 lines

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors