Skip to contentSkip to conversation

BUGFIX: serial setting for kgdb

PATCH New HoJin 2 participants 2 messages Dec 11, 2004 – Aug 5, 2005

lore
Share & tools
lore

HoJin

author
#0 lore raw

PATCH 1/1 BUGFIX: serial setting for kgdb

Hi,

KGDB_SMC_INDEX must be used as the index for brg_map, but it is used
direclty. (compared with function serial_init)
So it does not work properly. I have tested it and it works fine.

I noticed the same problem with 'serial_scc.c', but I could not test it yet.

Patch for only for 'serial_smc.c' is attached.

mpc8260/serial_smc.c (working copy) renamed from mpc8260/serial_smc.c (revision 65) +2 -2
Index: cpu/mpc8260/serial_smc.c
===================================================================
@@ -360,10 +360,10 @@
        /* Set up the baud rate generator.
        */
 #if defined(CONFIG_KGDB_USE_EXTC)
-       m8260_cpm_extcbrg(KGDB_SMC_INDEX, speed,
+       m8260_cpm_extcbrg(brg_map[KGDB_SMC_INDEX], speed,
                CONFIG_KGDB_EXTC_RATE, CONFIG_KGDB_EXTC_PINSEL);
 #else
-       m8260_cpm_setbrg(KGDB_SMC_INDEX, speed);
+       m8260_cpm_setbrg(brg_map[KGDB_SMC_INDEX], speed);
 #endif
 
        /* Make the first buffer the only buffer.
Signature · 1 line
Hojin
#1 lore raw

PATCH 1/1 BUGFIX: serial setting for kgdb

Quoted 4 lines · In message <[email protected]> you wrote:

KGDB_SMC_INDEX must be used as the index for brg_map, but it is used
direclty. (compared with function serial_init)
So it does not work properly. I have tested it and it works fine.

Thanks for pointing out, added.

Quoted 1 line

I noticed the same problem with 'serial_scc.c', but I could not test it yet.

I think the serial_scc.c code is OK, please check again.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Just about every computer on the market today runs Unix,  except  the
Mac (and nobody cares about it).                   - Bill Joy 6/21/85