Skip to contentSkip to conversation

PATCH cpu/at91rm9200/start.S

U-Boot-Users Steven Scholz 2 participants 8 messages Dec 13, 2004 – Mar 31, 2005

lore
Share & tools
lore
#0 lore raw

Hi there,

since enabling the "main oscillator" of Atmel's AT91RM9200 is very board specific and must not be done on some boards (which use external clock oscilators instead of crystals) I suggest

* Patch by Steven Scholz, 13 Dec 2004:
Move code for AT91 "main oscillator" into board specific memsetup.S files

Signature · 5 lines
Steven Scholz
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: u-boot-at91-MOSC.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20041213/06d97997/attachment.txt 
#1 lore raw
Quoted 8 lines · In message <[email protected]> you wrote:

since enabling the "main oscillator" of Atmel's AT91RM9200 is very board specific and must not be done on some boards (which use external clock oscilators instead of crystals) I suggest

* Patch by Steven Scholz, 13 Dec 2004:
Move code for AT91 "main oscillator" into board specific memsetup.S files

I reject this patch as it causes a duplication of the same code into several files. My understanding is that this code is poretty generic for all boards that use it; #undef'fing it for boards which don;t use it seems to be the better choice here.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We don't have to protect the environment -- the Second Coming is  at
hand."                                                   - James Watt
#2 lore raw
Quoted 11 lines · Wolfgang Denk
Quoted 7 lines · In message <[email protected]> you wrote:

since enabling the "main oscillator" of Atmel's AT91RM9200 is very board specific and must not be done on some boards (which use external clock oscilators instead of crystals) I suggest

* Patch by Steven Scholz, 13 Dec 2004:
Move code for AT91 "main oscillator" into board specific memsetup.S files

Quoted 4 lines

I reject this patch as it causes a duplication of the same code into several files. My understanding is that this code is poretty generic for all boards that use it; #undef'fing it for boards which don;t use it seems to be the better choice here.

I did not start the duplication! memsetup.S for at91rm9200dk and cmc_pu2 look pretty much the same already! The clock setup for both boards is done in memsetup.S.

I thought about a CFG_USE_MAIN_OSCILLATOR. But since we want to move cpu/at91rm9200 to cpu/arm920t/at91rm9200 someday we realy should not put such board and SoC specific code into start.S.

I aggree that duplicating code is bad and a generic cpu/at91rm9200/clocks.S would be better. But why did you accept the other patch

* Update for AT91RM9200DK and CMC_PU2 boards:
- Enable booting directly from flash

in the first place???

--
Steven Scholz

#3 lore raw
Quoted 3 lines · In message <[email protected]> you wrote:

I did not start the duplication! memsetup.S for at91rm9200dk and cmc_pu2 look pretty much the same already! The clock setup for both boards is done in memsetup.S.

I know :-(

Quoted 7 lines

I aggree that duplicating code is bad and a generic cpu/at91rm9200/clocks.S would be better. But why did you accept the other patch

* Update for AT91RM9200DK and CMC_PU2 boards:
- Enable booting directly from flash

in the first place???

Because it was needed to get a project running for a paying customer, and I didn't have enough time to clean it upo myself :-(

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You don't have to worry about me. I might have been born yesterday...
but I stayed up all night.
#4 lore raw
Quoted 6 lines · Wolfgang Denk
Quoted 2 lines · In message <[email protected]> you wrote:

I did not start the duplication! memsetup.S for at91rm9200dk and cmc_pu2 look pretty much the same already! The clock setup for both boards is done in memsetup.S.

I know :-(

So would you accept a patch that merges board/at91rm9200dk/memsetup.S and board/cmc_pu2/memsetup.s into a cpu/at91rm9200/lowlevel.S ?

Quoted 2 lines

Because it was needed to get a project running for a paying customer, and I didn't have enough time to clean it upo myself :-(

I guess it does not count if I tell you that I need the sent patch "get a project running for a paying customer" (a.k.a. my boss) ... ;-)

--
Steven

#5 lore raw
Quoted 3 lines · In message <[email protected]> you wrote:

So would you accept a patch that merges board/at91rm9200dk/memsetup.S and board/cmc_pu2/memsetup.s into a cpu/at91rm9200/lowlevel.S ?

Sure.

Quoted 4 lines
Quoted 2 lines

Because it was needed to get a project running for a paying customer, and I didn't have enough time to clean it upo myself :-(

I guess it does not count if I tell you that I need the sent patch "get a project running for a paying customer" (a.k.a. my boss) ... ;-)

Not really - unless he starts paying me, too :-)

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Earth -- mother of the most beautiful women in the universe.
	-- Apollo, "Who Mourns for Adonais?" stardate 3468.1
#6 lore raw
Quoted 6 lines · Wolfgang Denk
Quoted 2 lines · In message <[email protected]> you wrote:

So would you accept a patch that merges board/at91rm9200dk/memsetup.S and board/cmc_pu2/memsetup.s into a cpu/at91rm9200/lowlevel.S ?

Sure.

Ok. Here we go:

* Patch by Steven Scholz, 13 Dec 2004:
Remove duplicated code by merging memsetup.S files for at91rm9200 boards into one cpu/at91rm9200/lowlevel.S

--
Steven
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-at91-lowlevel.patch.bz2
Type: application/octet-stream
Size: 4354 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20041213/10e90381/attachment.obj

#7 lore raw
Quoted 4 lines · In message <[email protected]> you wrote:

* Patch by Steven Scholz, 13 Dec 2004:
Remove duplicated code by merging memsetup.S files for at91rm9200 boards into one cpu/at91rm9200/lowlevel.S

Added, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Schshschshchsch.
	-- The Gorn, "Arena", stardate 3046.2