Skip to contentSkip to conversation

doubt about "switch" - default case in af_inet.c

DISCUSSION Phani Kandula 3 participants 3 messages Dec 9, 2004 – Dec 16, 2004

lore
Share & tools
lore
#0 lore raw

Hi all,

I'm a newbie to the Linux. I'm using 2.6.8 kernel. In /usr/src/linux/net/ipv4/af_inet.c I came across this...
<code>

     switch (sock->state) {
     default:
     //do something..
         goto out;
     case SS_CONNECTED:
     //do something..
         goto out;
     case SS_CONNECTING:
     //do something..
         break;
     case SS_UNCONNECTED:
     //do something..
         break;
     }

</code>

Is there any advantage in having 'default' as the first case? My understanding is that it will be useful only when 'default' is the most likely case (in general).

Even then, my doubt: How will compiler (say gcc) implement 'default' as the first value? Program is supposed to see all the cases and then decide 'default'. Is this correct?

So, is this the best way to do it? please clarify..

Thanks,
Phani

#1 lore raw
Quoted 25 lines · Phani Kandula

Hi all,

I'm a newbie to the Linux. I'm using 2.6.8 kernel. In /usr/src/linux/net/ipv4/af_inet.c I came across this... <code>

    switch (sock->state) {
    default:
    //do something..
        goto out;
    case SS_CONNECTED:
    //do something..
        goto out;
    case SS_CONNECTING:
    //do something..
        break;
    case SS_UNCONNECTED:
    //do something..
        break;
    }

</code>

Is there any advantage in having 'default' as the first case? My understanding is that it will be useful only when 'default' is the most likely case (in general).

Quoted 8 lines

Even then, my doubt: How will compiler (say gcc) implement 'default' as the first value? Program is supposed to see all the cases and then decide 'default'. Is this correct?

So, is this the best way to do it? please clarify..

Thanks,
Phani

Generally speaking when you see "strange" code mixed with gotos, somebody has adjusted the code, often by looking at the assembly output, to maximize the performance.

Of course, when the compiler changes, the code may no longer be optimum.

In principle, if the labels in a switch represent incrementing numbers, the compiler can generate fast code by using that fact. However, often little care is taken in the placement of these labels or the numerical differences between them so the code output degenerates to a bunch of "compares". In this case, the most common value should be the one checked first.

Cheers,
Dick Johnson
Penguin : Linux version 2.6.9 on an i686 machine (5537.79 BogoMips).
Notice : All mail here is now cached for review by John Ashcroft.
98.36% of all statistics are fiction.

#2 lore raw
In reply to Phani Kandula
Quoted 20 lines · Phani Kandula

Hi all,

I'm a newbie to the Linux. I'm using 2.6.8 kernel. In /usr/src/linux/net/ipv4/af_inet.c I came across this...
<code>

     switch (sock->state) {
     default:
     //do something..
         goto out;
     case SS_CONNECTED:
     //do something..
         goto out;
     case SS_CONNECTING:
     //do something..
         break;
     case SS_UNCONNECTED:
     //do something..
         break;
     }

</code>

Quoted 8 lines

Is there any advantage in having 'default' as the first case? My understanding is that it will be useful only when 'default' is the most likely case (in general).

Even then, my doubt: How will compiler (say gcc) implement 'default' as the first value? Program is supposed to see all the cases and then decide 'default'. Is this correct?

So, is this the best way to do it? please clarify..

Just so. The compiler will check some or all of the cases first, and then take the default case. If you look at the code with and without optimization (use -S) you will see that it behaves the same way regardless of the placement of the default case. There is one exception, that is the one where control falls through from one case to another, and the default case is not last and lacks a break, such that the default winds up executing the code from the case(s) following.

Do I have to say that the code doing stuff like that is hard to read?

Signature · 3 lines
   -bill davidsen ([email protected])
"The secret to procrastination is to put things off until the
 last possible moment - but no longer"  -me